Skip to content

fix(gateway): block internal HTTP session overrides#93443

Merged
vincentkoc merged 4 commits into
mainfrom
clownfish/ghcrawl-156813-autonomous-smoke
Jun 16, 2026
Merged

fix(gateway): block internal HTTP session overrides#93443
vincentkoc merged 4 commits into
mainfrom
clownfish/ghcrawl-156813-autonomous-smoke

Conversation

@openclaw-clownfish

Copy link
Copy Markdown
Contributor

Summary

  • repairs and finalizes fix(gateway): block internal HTTP session overrides #55789 in place, preserving @RichardCao's contribution
  • rejects explicit x-openclaw-session-key overrides for reserved internal namespaces on OpenAI-compatible and OpenResponses HTTP paths
  • keeps normal custom session keys and unexpected context/config failures on their existing server-error path

Credit

This continues the implementation from #55789 by @RichardCao. Related prior gateway-boundary work in #45344 by @spence27 informed the review context but is not being merged here.

Validation

  • pnpm exec vitest run src/gateway/http-utils.request-context.test.ts src/gateway/openai-http.test.ts src/gateway/openresponses-http.test.ts
  • pnpm check:changed
  • Codex /review must pass cleanly after repair
  • Include real behavior proof for the OpenAI/OpenResponses HTTP rejection path before merge

Clownfish 🐠 replacement reef notes:

fish notes: model gpt-5.5, reasoning medium; reviewed against b18a288.

@openclaw-clownfish openclaw-clownfish Bot added the clownfish Tracked by Clownfish automation label Jun 16, 2026
@openclaw-barnacle openclaw-barnacle Bot added docs Improvements or additions to documentation gateway Gateway runtime size: S labels Jun 16, 2026
@vincentkoc

Copy link
Copy Markdown
Member

Land-ready maintainer verification:

  • Fresh branch update onto fixed main: head 4b620301a748b37916c9fa48b76f6f77a80814a6.
  • Hosted PR CI is clean: 137 passing checks, 26 skipped, 0 failing checks.
  • The previous inherited blockers are resolved on this head: checks-node-core-fast and checks-node-agentic-gateway-core passed.
  • Diff sanity checked: normal explicit x-openclaw-session-key overrides remain supported, while reserved internal subagent:, cron:, and acp: namespaces are rejected before dispatch on both OpenAI-compatible endpoints.
  • Helper contract checked: the patch uses the existing canonical session-key namespace classifiers from routing/session-key / sessions/session-key-utils.

Merging this PR now.

@vincentkoc
vincentkoc merged commit 8694fe7 into main Jun 16, 2026
165 checks passed
@vincentkoc
vincentkoc deleted the clownfish/ghcrawl-156813-autonomous-smoke branch June 16, 2026 01:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

clownfish Tracked by Clownfish automation docs Improvements or additions to documentation gateway Gateway runtime size: S

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant