fix(outbound): ignore schema-padded poll metadata on send#93441
Merged
Conversation
Co-authored-by: 鄧 偉程 <[email protected]>
25 tasks
Member
|
Land-ready maintainer verification:
Merging this PR now. |
This was referenced Jun 16, 2026
This was referenced Jul 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
message.sendfalse positive from message.send schema overexposes poll/components/modal causing GPT auto-population breakages #43015 where schema-padded channel-extra poll metadata such aspollDurationSeconds: 60can still make a plain send fail.pollQuestion/pollOption) so explicit poll creation behavior remains protected.Validation
pnpm -s vitest run src/poll-params.test.ts src/infra/outbound/message-action-runner.send-validation.test.ts src/infra/outbound/message-action-runner.core-send.test.ts --maxWorkers=1pnpm check:changedFixes #43015.
Source PR credit: #65301 by @weichengdeng.
Clownfish 🐠 replacement reef notes:
fish notes: model gpt-5.5, reasoning medium; reviewed against 4d9329c.