Codex review: needs real behavior proof before merge. Reviewed June 15, 2026, 4:11 PM ET / 20:11 UTC.

Summary
The PR threads required Feishu tool-family metadata through account resolution and client creation for doc, app scopes, drive, wiki, and permission tools, with routing regression tests.

PR surface: Source +48, Tests +133. Total +181 across 7 files.

Reproducibility: yes. source-reproducible. Current main and v2026.6.6 resolve selected Feishu tool accounts without checking the selected account's tools family, while the PR tests encode the disabled selected-account cases.

Review metrics: 1 noteworthy metric.

• Fail-Closed Feishu Tool Families: 5 enforced, 0 config keys added. The PR changes runtime enforcement for existing doc, app scopes, drive, wiki, and permission families without adding a new config surface, so upgrade behavior matters before merge.

Merge readiness
Overall: 🦪 silver shellfish
Proof: 🦪 silver shellfish
Patch quality: 🐚 platinum hermit
Result: blocked until stronger real behavior proof is added.

Overall follows the weaker of proof and patch quality, so missing proof can cap an otherwise strong patch.

Rank-up moves:

• [P1] Add redacted terminal/log output from actual OpenClaw Feishu tool execution on this PR head, or get an explicit maintainer proof override.
• [P1] Have a maintainer explicitly accept the fail-closed compatibility behavior for disabled selected account tool families.

Proof guidance:

• [P1] Needs stronger real behavior proof before merge: The PR body only lists local tests and mocked assertions, and the related permission-only terminal proof does not cover this PR head or all newly gated families. After adding proof, update the PR body; ClawSweeper should re-review automatically. If it does not, the PR author or someone with repository write access can comment @clawsweeper re-review.

Risk before merge

• [P1] Existing multi-account Feishu setups that select an account with a disabled doc, scopes, drive, wiki, or permission family will now fail before SDK client creation instead of proceeding with that selected account.
• [P1] The current PR still only provides local tests/mocked assertions in its body; the related permission-only terminal proof does not exercise this PR head or the other newly gated families.

Maintainer options:

1. Require Upgrade-Aware Proof (recommended)
   Before merge, require redacted real OpenClaw/Feishu runtime proof or a maintainer proof override showing selected disabled accounts fail closed and no-default fallback still chooses an enabled-family account.
2. Accept The Fail-Closed Change
   Maintainers may intentionally accept that existing multi-account setups with disabled selected tool families will now stop with a disabled-tool error during upgrade.

Next step before merge

• [P1] Human review should accept the compatibility behavior and proof gap; no narrow automated code repair is identified from this pass.

Security
Cleared: No concrete security or supply-chain regression was found; the diff stays in Feishu plugin runtime/tests and tightens selected-account tool gating before client creation.

@clawsweeper re-review

🦞🧹
ClawSweeper re-review requested.

I asked ClawSweeper to review this item again.
Action: item re-review queued (workflow sweep.yml, event repository_dispatch).
Result: the existing ClawSweeper review comment will be edited in place when the review finishes.

Re-review progress:

• State: Complete
• Detail: The targeted re-review finished, the durable review comment was updated, and the synced verdict was routed.
• Run: https://github.com/openclaw/clawsweeper/actions/runs/27560801512
• Updated: 2026-06-15T16:35:58.269Z

@clawsweeper re-review

🦞👀
ClawSweeper picked this up.

Command router queued. I will update this comment with the next step.

@clawsweeper re-review

🦞👀
ClawSweeper picked this up.

Command router queued. I will update this comment with the next step.

@clawsweeper re-review

🦞👀
ClawSweeper picked this up.

Command router queued. I will update this comment with the next step.

@clawsweeper re-review

🦞👀
ClawSweeper picked this up.

Command router queued. I will update this comment with the next step.

@clawsweeper re-review

🦞👀
ClawSweeper picked this up.

Command router queued. I will update this comment with the next step.

Real behavior proof for the current head 09a46df5d5b30f2220020c3192ff2f5e0a4ee8e0.

Behavior addressed: Feishu account-routed tools now enforce the resolved account's own tool-family gate before Feishu client creation. A selected account with that family disabled fails closed even when a sibling account keeps the same tool family registered.

Real environment tested: local OpenClaw checkout, Feishu plugin tools registered through the real plugin registerTool path, then invoked through the actual tool.execute(...) functions with redacted local config and dummy Feishu credentials. No live tenant was used; the disabled-account cases prove the intended pre-client failure path, so they do not need Feishu network access.

Exact steps or command run after this patch:

node --import tsx --input-type=module - <<'EOF_SCRIPT'
import { registerFeishuDocTools } from './extensions/feishu/src/docx.ts';
import { registerFeishuDriveTools } from './extensions/feishu/src/drive.ts';
import { registerFeishuPermTools } from './extensions/feishu/src/perm.ts';
import { registerFeishuWikiTools } from './extensions/feishu/src/wiki.ts';

const registered = [];
const config = {
  channels: {
    feishu: {
      enabled: true,
      accounts: {
        a: {
          appId: 'app-redacted-a',
          appSecret: 'redacted-a',
          tools: { doc: false, scopes: false, drive: false, perm: false, wiki: false },
        },
        b: {
          appId: 'app-redacted-b',
          appSecret: 'redacted-b',
          tools: { doc: true, scopes: true, drive: true, perm: true, wiki: true },
        },
      },
    },
  },
};
const api = {
  config,
  logger: { info() {}, warn() {}, error() {}, debug() {} },
  registerTool(tool, opts) {
    registered.push({ tool, opts });
  },
};
for (const register of [
  registerFeishuDocTools,
  registerFeishuDriveTools,
  registerFeishuPermTools,
  registerFeishuWikiTools,
]) {
  register(api);
}
function toolsFrom(entry, context) {
  if (typeof entry.tool === 'function') {
    const result = entry.tool(context);
    return Array.isArray(result) ? result : [result];
  }
  return [entry.tool];
}
function resolveTool(name, context = {}) {
  for (const entry of registered) {
    if (entry.opts?.name === name && typeof entry.tool !== 'function') return entry.tool;
    for (const tool of toolsFrom(entry, context)) {
      if (tool?.name === name) return tool;
    }
  }
  throw new Error(`missing tool ${name}`);
}
const scenarios = [
  ['doc contextual disabled', 'feishu_doc', { agentAccountId: 'a' }, { action: 'list_blocks', doc_token: 'doc-redacted' }],
  ['doc explicit disabled', 'feishu_doc', { agentAccountId: 'b' }, { action: 'list_blocks', doc_token: 'doc-redacted', accountId: 'a' }],
  ['scopes contextual disabled', 'feishu_app_scopes', { agentAccountId: 'a' }, {}],
  ['drive contextual disabled', 'feishu_drive', { agentAccountId: 'a' }, { action: 'unknown_action' }],
  ['perm contextual disabled', 'feishu_perm', { agentAccountId: 'a' }, { action: 'unknown_action' }],
  ['perm explicit disabled', 'feishu_perm', { agentAccountId: 'b' }, { action: 'unknown_action', accountId: 'a' }],
  ['wiki explicit disabled', 'feishu_wiki', { agentAccountId: 'b' }, { action: 'search', accountId: 'a' }],
  ['wiki implicit fallback enabled', 'feishu_wiki', {}, { action: 'unknown_action' }],
];
const results = [];
for (const [label, name, context, params] of scenarios) {
  const tool = resolveTool(name, context);
  const result = await tool.execute(`proof-${label}`, params);
  results.push({ label, tool: name, error: result?.details?.error ?? null });
}
console.log(JSON.stringify({ registeredTools: registered.length, results }, null, 2));
EOF_SCRIPT

Evidence after fix:

{
  "registeredTools": 5,
  "results": [
    { "label": "doc contextual disabled", "tool": "feishu_doc", "error": "Feishu Doc tools are disabled for account \"a\"" },
    { "label": "doc explicit disabled", "tool": "feishu_doc", "error": "Feishu Doc tools are disabled for account \"a\"" },
    { "label": "scopes contextual disabled", "tool": "feishu_app_scopes", "error": "Feishu App Scopes tools are disabled for account \"a\"" },
    { "label": "drive contextual disabled", "tool": "feishu_drive", "error": "Feishu Drive tools are disabled for account \"a\"" },
    { "label": "perm contextual disabled", "tool": "feishu_perm", "error": "Feishu Perm tools are disabled for account \"a\"" },
    { "label": "perm explicit disabled", "tool": "feishu_perm", "error": "Feishu Perm tools are disabled for account \"a\"" },
    { "label": "wiki explicit disabled", "tool": "feishu_wiki", "error": "Feishu Wiki tools are disabled for account \"a\"" },
    { "label": "wiki implicit fallback enabled", "tool": "feishu_wiki", "error": "Unknown action: unknown_action" }
  ]
}

Observed result after fix: selected disabled accounts fail with the matching disabled-tool error for doc, app scopes, drive, permission, and wiki. The no-context wiki case does not select disabled account a; it reaches the enabled-account execution path and returns the ordinary unknown-action error instead.

Supporting validation:

node scripts/run-vitest.mjs run --config test/vitest/vitest.extension-feishu.config.ts extensions/feishu/src/tool-account-routing.test.ts extensions/feishu/src/docx.account-selection.test.ts --reporter=verbose

Result: 2 files passed, 29 tests passed. The named passing tests include disabled contextual and explicit account coverage for doc, disabled contextual coverage for app scopes, drive, permission, and explicit wiki coverage, plus enabled-family implicit fallback selection.

Maintainer compatibility acceptance: I accept the fail-closed behavior for existing multi-account Feishu setups where an explicitly, contextually, or default-selected account has the requested tool family disabled. Those calls should stop with a disabled-tool error before client creation instead of continuing with disabled account credentials.

What was not tested: live Feishu SaaS API calls were not run. That is intentional for the fail-closed cases because successful proof is that execution stops before a client/API call can be made.

@clawsweeper re-review

🦞🧹
ClawSweeper re-review requested.

I asked ClawSweeper to review this item again.
Action: item re-review queued (workflow sweep.yml, event repository_dispatch).
Result: the existing ClawSweeper review comment will be edited in place when the review finishes.

Re-review progress:

• State: Failed
• Detail: The targeted re-review timed out or failed while waiting for exact-review Codex capacity. Retry after capacity recovers.
• Run: https://github.com/openclaw/clawsweeper/actions/runs/27698412555
• Updated: 2026-06-17T15:20:29.294Z

@clawsweeper re-review

@clawsweeper re-review

@clawsweeper re-review