test: fold otel smoke into qa e2e#93181
Conversation
|
Codex review: needs maintainer review before merge. Reviewed June 17, 2026, 4:50 PM ET / 20:50 UTC. Summary PR surface: Tests +8, Other +29. Total +37 across 5 files. Reproducibility: not applicable. this is an internal PR review for QA/script cleanup, not a reported bug. The relevant verification is source and CI inspection of the QA scenario path, changed-test routing, and parent stack state. Review metrics: 2 noteworthy metrics.
Merge readiness Overall follows the weaker of proof and patch quality, so missing proof can cap an otherwise strong patch. Rank-up moves:
Risk before merge
Maintainer options:
Next step before merge
Security Review detailsBest possible solution: Land or retarget this OTEL QA scenario cleanup only after #93114 is green, keeping the scenario metadata, changed-test routing, and surviving OTEL smoke command shape aligned. Do we have a high-confidence way to reproduce the issue? Not applicable: this is an internal PR review for QA/script cleanup, not a reported bug. The relevant verification is source and CI inspection of the QA scenario path, changed-test routing, and parent stack state. Is this the best way to solve the issue? Yes, with the stack caveat: putting the OTEL smoke assertions behind a native QA Lab Vitest scenario is the right owner boundary, but the parent migration should be green and settled before mainline landing. AGENTS.md: found and applied where relevant. Codex review notes: model internal, reasoning high; reviewed against 20534c57b7e8. Label changesLabel justifications:
Evidence reviewedPR surface: Tests +8, Other +29. Total +37 across 5 files. View PR surface stats
What I checked:
Likely related people:
What the crustacean ranks mean
Shiny media proof means a screenshot, video, or linked artifact directly shows the changed behavior. Runtime, network, CSP, and security claims still need visible diagnostics. How this review workflow works
|
32090f8 to
7897a66
Compare
7897a66 to
a63ed23
Compare
606494a to
4fa026e
Compare
a63ed23 to
fd9fc41
Compare
e0571de to
6965711
Compare
fd9fc41 to
771b22a
Compare
771b22a to
b784d63
Compare
This comment has been minimized.
This comment has been minimized.
* test: fold otel smoke into qa e2e * test: eliminate otel smoke script
* test: fold otel smoke into qa e2e * test: eliminate otel smoke script
Summary
scripts/qa-otel-smoke.tstest/e2e/qa-lab/runtime/qa-otel-smoke.e2e.test.tspnpm qa:otel:smokeandpnpm qa:otel:collector-smokeby routing them to the e2e file's--smokemodeqa-otel-smokecoverage metadata scoped to the IDs this scenario actually proves:telemetry.otelandharness.qa-labStacked on #93114.
Verification
node scripts/run-vitest.mjs test/e2e/qa-lab/runtime/qa-otel-smoke.e2e.test.ts test/scripts/test-projects.test.ts --reporter=verbosepnpm qa:otel:smoke -- --output-dir .artifacts/qa-e2e/qa-otel-smoke-script-deleted-trimmedpnpm openclaw qa suite --scenario qa-otel-smoke --output-dir .artifacts/qa-e2e/qa-otel-smoke-scenario-script-deleted-trimmedpnpm openclaw qa coverage --match qa-otel-smoke --jsonpnpm exec oxfmt --check --threads=1 test/e2e/qa-lab/runtime/qa-otel-smoke.e2e.test.tspnpm exec oxfmt --check --threads=1 qa/scenarios/runtime/qa-otel-smoke.yamlgit diff --checkKnown local warning during QA commands: existing state migration warning for
.openclaw/plugins/installs.json.migratedalready being present.