test: fold gateway smoke into qa e2e#93178
Conversation
|
Codex review: needs maintainer review before merge. Reviewed June 15, 2026, 1:46 AM ET / 05:46 UTC. Summary PR surface: Tests +150, Other -172. Total -22 across 5 files. Reproducibility: not applicable. this is a cleanup PR review rather than a bug report. The relevant check is whether the migrated QA e2e test preserves the old script coverage and stale references are removed. Review metrics: none identified. Merge readiness Overall follows the weaker of proof and patch quality, so missing proof can cap an otherwise strong patch. Rank-up moves:
Risk before merge
Maintainer options:
Next step before merge
Security Review detailsBest possible solution: Land this after the base QA migration, keeping Gateway smoke coverage in the QA e2e scenario with no supported references to the deleted dev script. Do we have a high-confidence way to reproduce the issue? Not applicable; this is a cleanup PR review rather than a bug report. The relevant check is whether the migrated QA e2e test preserves the old script coverage and stale references are removed. Is this the best way to solve the issue? Yes; moving the repo-only smoke helper into QA Lab's Vitest scenario is the narrower owner-boundary cleanup, provided the stacked base lands first or this branch is refreshed. AGENTS.md: found and applied where relevant. Codex review notes: model internal, reasoning high; reviewed against b3f315461ba7. Label changesLabel justifications:
Evidence reviewedPR surface: Tests +150, Other -172. Total -22 across 5 files. View PR surface stats
What I checked:
Likely related people:
What the crustacean ranks mean
Shiny media proof means a screenshot, video, or linked artifact directly shows the changed behavior. Runtime, network, CSP, and security claims still need visible diagnostics. How this review workflow works
|
606494a to
4fa026e
Compare
cf371a4 to
e98f8c2
Compare
e0571de to
6965711
Compare
e98f8c2 to
66432d7
Compare
66432d7 to
8411670
Compare
Summary
scripts/dev/gateway-smoke.tsStacked on #93114.
Verification
node scripts/run-vitest.mjs test/e2e/qa-lab/runtime/gateway-smoke.e2e.test.ts test/scripts/test-projects.test.ts packages/gateway-protocol/src/native-protocol-levels.guard.test.ts --reporter=verbosepnpm openclaw qa suite --scenario gateway-smoke --output-dir .artifacts/qa-e2e/gateway-smoke-script-deletedpnpm exec oxfmt --check --threads=1 test/e2e/qa-lab/runtime/gateway-smoke.e2e.test.ts scripts/test-projects.test-support.mjs test/scripts/test-projects.test.ts packages/gateway-protocol/src/native-protocol-levels.guard.test.tsgit diff --check.agents/skills/autoreview/scripts/autoreview --mode local --prompt "Review this stacked RFC #10 cleanup PR. It deletes scripts/dev/gateway-smoke.ts, folds runGatewaySmoke and its connect/health payload validation into test/e2e/qa-lab/runtime/gateway-smoke.e2e.test.ts, removes stale changed-test routing, and updates the protocol guard to stop expecting the deleted dev script. Focus on whether any supported command/docs/package/skill surface still references the deleted script, whether protocol min/max version coverage remains sufficient, whether the e2e test remains proper Vitest without script execution, and whether QA scenario evidence still runs. Ignore .artifacts and node_modules."Known local warning during QA commands: existing state migration warning for
.openclaw/plugins/installs.json.migratedalready being present.