Skip to content

test: fold gateway smoke into qa e2e#93178

Merged
RomneyDa merged 1 commit into
mainfrom
qa-delete-gateway-smoke-script
Jun 17, 2026
Merged

test: fold gateway smoke into qa e2e#93178
RomneyDa merged 1 commit into
mainfrom
qa-delete-gateway-smoke-script

Conversation

@RomneyDa

Copy link
Copy Markdown
Member

Summary

  • delete scripts/dev/gateway-smoke.ts
  • fold Gateway smoke connect/health validation into the QA e2e test
  • remove stale changed-test routing and keep the protocol guard focused on remaining dev/native clients

Stacked on #93114.

Verification

  • node scripts/run-vitest.mjs test/e2e/qa-lab/runtime/gateway-smoke.e2e.test.ts test/scripts/test-projects.test.ts packages/gateway-protocol/src/native-protocol-levels.guard.test.ts --reporter=verbose
  • pnpm openclaw qa suite --scenario gateway-smoke --output-dir .artifacts/qa-e2e/gateway-smoke-script-deleted
  • pnpm exec oxfmt --check --threads=1 test/e2e/qa-lab/runtime/gateway-smoke.e2e.test.ts scripts/test-projects.test-support.mjs test/scripts/test-projects.test.ts packages/gateway-protocol/src/native-protocol-levels.guard.test.ts
  • git diff --check
  • .agents/skills/autoreview/scripts/autoreview --mode local --prompt "Review this stacked RFC #10 cleanup PR. It deletes scripts/dev/gateway-smoke.ts, folds runGatewaySmoke and its connect/health payload validation into test/e2e/qa-lab/runtime/gateway-smoke.e2e.test.ts, removes stale changed-test routing, and updates the protocol guard to stop expecting the deleted dev script. Focus on whether any supported command/docs/package/skill surface still references the deleted script, whether protocol min/max version coverage remains sufficient, whether the e2e test remains proper Vitest without script execution, and whether QA scenario evidence still runs. Ignore .artifacts and node_modules."

Known local warning during QA commands: existing state migration warning for .openclaw/plugins/installs.json.migrated already being present.

@openclaw-barnacle openclaw-barnacle Bot added app: web-ui App: web-ui gateway Gateway runtime scripts Repository scripts size: M maintainer Maintainer-authored PR labels Jun 15, 2026
@clawsweeper

clawsweeper Bot commented Jun 15, 2026

Copy link
Copy Markdown
Contributor

Codex review: needs maintainer review before merge. Reviewed June 15, 2026, 1:46 AM ET / 05:46 UTC.

Summary
The branch deletes scripts/dev/gateway-smoke.ts, folds its connect/health assertions into the QA Lab Gateway smoke e2e test, and updates changed-test routing plus the protocol guard.

PR surface: Tests +150, Other -172. Total -22 across 5 files.

Reproducibility: not applicable. this is a cleanup PR review rather than a bug report. The relevant check is whether the migrated QA e2e test preserves the old script coverage and stale references are removed.

Review metrics: none identified.

Merge readiness
Overall: 🐚 platinum hermit
Proof: 🦞 diamond lobster
Patch quality: 🐚 platinum hermit
Result: ready for maintainer review.

Overall follows the weaker of proof and patch quality, so missing proof can cap an otherwise strong patch.

Rank-up moves:

Risk before merge

Maintainer options:

  1. Decide the mitigation before merge
    Land this after the base QA migration, keeping Gateway smoke coverage in the QA e2e scenario with no supported references to the deleted dev script.
  2. Pause or close
    Do not merge this PR until maintainers decide whether the risk is worth taking.

Next step before merge

  • No automated repair is needed; the protected maintainer label and stacked base call for normal maintainer review and merge ordering.

Security
Cleared: The diff deletes a dev script and moves test coverage without changing dependencies, workflows, permissions, lockfiles, publishing, or secret handling.

Review details

Best possible solution:

Land this after the base QA migration, keeping Gateway smoke coverage in the QA e2e scenario with no supported references to the deleted dev script.

Do we have a high-confidence way to reproduce the issue?

Not applicable; this is a cleanup PR review rather than a bug report. The relevant check is whether the migrated QA e2e test preserves the old script coverage and stale references are removed.

Is this the best way to solve the issue?

Yes; moving the repo-only smoke helper into QA Lab's Vitest scenario is the narrower owner-boundary cleanup, provided the stacked base lands first or this branch is refreshed.

AGENTS.md: found and applied where relevant.

Codex review notes: model internal, reasoning high; reviewed against b3f315461ba7.

Label changes

Label justifications:

  • P3: This is low-risk internal test and QA cleanup rather than a user-facing runtime bug or urgent regression.
  • rating: 🐚 platinum hermit: Overall readiness is 🐚 platinum hermit; proof is 🦞 diamond lobster and patch quality is 🐚 platinum hermit.
  • status: 👀 ready for maintainer look: ClawSweeper has no concrete contributor-facing blocker left for this PR. Not applicable: The external contributor proof gate does not apply to this maintainer/member test cleanup PR; the body records targeted Vitest, QA suite, formatting, diff-check, and autoreview commands.
Evidence reviewed

PR surface:

Tests +150, Other -172. Total -22 across 5 files.

View PR surface stats
Area Files Added Removed Net
Source 0 0 0 0
Tests 3 153 3 +150
Docs 0 0 0 0
Config 0 0 0 0
Generated 0 0 0 0
Other 2 0 172 -172
Total 5 153 175 -22

What I checked:

Likely related people:

  • kesslerio: Current-main blame and PR metadata point to Martin Kessler for the existing Gateway smoke script, its test, and the protocol guard paths now being folded into QA e2e coverage. (role: introduced behavior; confidence: high; commits: aefd49909d41; files: scripts/dev/gateway-smoke.ts, test/scripts/gateway-smoke.test.ts, packages/gateway-protocol/src/native-protocol-levels.guard.test.ts)
  • RomneyDa: Recent merged QA scenario YAML, profile runner, and evidence-shape work owns the QA Lab path this cleanup extends, independent of this PR author role. (role: recent QA Lab contributor; confidence: high; commits: 1f8c4d3958b2, e8db9c3bc0df, fef839407995; files: qa/scenarios/index.yaml, extensions/qa-lab/src/test-file-scenario-runner.ts, extensions/qa-lab/src/suite-launch.runtime.ts)
What the crustacean ranks mean
  • 🦀 challenger crab: rare, exceptional readiness with strong proof, clean implementation, and convincing validation.
  • 🦞 diamond lobster: very strong readiness with only minor maintainer review expected.
  • 🐚 platinum hermit: good normal PR, likely mergeable with ordinary maintainer review.
  • 🦐 gold shrimp: useful signal, but proof or patch confidence is still limited.
  • 🦪 silver shellfish: thin signal; proof, validation, or implementation needs work.
  • 🧂 unranked krab: not merge-ready because proof is missing/unusable or there are serious correctness or safety concerns.
  • 🌊 off-meta tidepool: rating does not apply to this item.

Shiny media proof means a screenshot, video, or linked artifact directly shows the changed behavior. Runtime, network, CSP, and security claims still need visible diagnostics.

How this review workflow works
  • ClawSweeper keeps one durable marker-backed review comment per issue or PR.
  • Re-runs edit this comment so the latest verdict, findings, and automation markers stay together instead of adding duplicate bot comments.
  • A fresh review can be triggered by eligible @clawsweeper re-review comments, exact-item GitHub events, scheduled/background review runs, or manual workflow dispatch.
  • PR/issue authors and users with repository write access can comment @clawsweeper re-review or @clawsweeper re-run on an open PR or issue to request a fresh review only.
  • Maintainers can also comment @clawsweeper review to request a fresh review only.
  • Fresh-review commands do not start repair, autofix, rebase, CI repair, or automerge.
  • Maintainer-only repair and merge flows require explicit commands such as @clawsweeper autofix, @clawsweeper automerge, @clawsweeper fix ci, or @clawsweeper address review.
  • Maintainers can comment @clawsweeper explain to ask for more context, or @clawsweeper stop to stop active automation.

@clawsweeper clawsweeper Bot added rating: 🐚 platinum hermit Good normal PR readiness with ordinary maintainer review expected. status: 👀 ready for maintainer look ClawSweeper has no concrete contributor-facing blocker left for this PR. P3 Low-priority cleanup, docs, polish, ergonomics, or speculative work. labels Jun 15, 2026
@RomneyDa
RomneyDa force-pushed the script-to-test-conversion branch from 606494a to 4fa026e Compare June 16, 2026 21:00
@RomneyDa
RomneyDa force-pushed the qa-delete-gateway-smoke-script branch from cf371a4 to e98f8c2 Compare June 16, 2026 21:01
@RomneyDa
RomneyDa force-pushed the script-to-test-conversion branch 2 times, most recently from e0571de to 6965711 Compare June 17, 2026 19:56
@RomneyDa
RomneyDa force-pushed the qa-delete-gateway-smoke-script branch from e98f8c2 to 66432d7 Compare June 17, 2026 20:17
Base automatically changed from script-to-test-conversion to main June 17, 2026 21:22
@openclaw-barnacle openclaw-barnacle Bot added docker Docker and sandbox tooling size: XL and removed size: XS labels Jun 17, 2026
@RomneyDa
RomneyDa force-pushed the qa-delete-gateway-smoke-script branch from 66432d7 to 8411670 Compare June 17, 2026 21:30
@openclaw-barnacle openclaw-barnacle Bot added size: XS and removed docker Docker and sandbox tooling size: XL labels Jun 17, 2026
@RomneyDa
RomneyDa merged commit f7e5132 into main Jun 17, 2026
294 of 298 checks passed
@RomneyDa
RomneyDa deleted the qa-delete-gateway-smoke-script branch June 17, 2026 21:55
crh-code pushed a commit to crh-code/openclaw that referenced this pull request Jun 18, 2026
github-actions Bot pushed a commit to Desicool/openclaw that referenced this pull request Jun 18, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

extensions: qa-lab maintainer Maintainer-authored PR P3 Low-priority cleanup, docs, polish, ergonomics, or speculative work. rating: 🐚 platinum hermit Good normal PR readiness with ordinary maintainer review expected. scripts Repository scripts size: XS status: 👀 ready for maintainer look ClawSweeper has no concrete contributor-facing blocker left for this PR.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant