#93041: fix(control-ui): restore Codex usage quota pill in sidebar session switcher by qingminglong · Pull Request #93157 · openclaw/openclaw

qingminglong · 2026-06-15T04:10:45Z

Summary

The Codex/OpenAI usage quota pill (shown in the Control UI chat that displays usage limits e.g. "5h remaining") was accidentally removed when the old chat header was replaced with a sidebar in PR #88772 ("calm composer controls").

Root Cause

ui/src/ui/chat/session-controls.ts has a sessionSwitcherOnly flag. When true (as used by the new sidebar), both the model selector AND the quota pill were suppressed:

const modelSelect = sessionSwitcherOnly ? "" : renderChatModelSelect(state);
const quotaPill = sessionSwitcherOnly ? "" : renderChatQuotaPill(state);

The quota pill suppression was unintentional — only the model selector should be hidden in session-switcher mode. The quota data path (fetchCodexUsage, collectQuotaWindowsFromAuthStatus, renderChatQuotaPill) remains intact and functional.

Real behavior proof

behavior

Remove the sessionSwitcherOnly guard from the quota pill rendering so it appears in both the old header and the new sidebar.

environment

OS: Linux
Runtime: Node.js 22
Setup: OpenClaw main at 663fabb

steps

Read the source file to confirm the old guard (sessionSwitcherOnly ? "" : renderChatQuotaPill) is replaced with unconditional renderChatQuotaPill(state)
Run reproduction script to verify
Run test suite

evidence

Source change verification:

Before: quotaPill = sessionSwitcherOnly ? "" : renderChatQuotaPill(state)
After:  quotaPill = renderChatQuotaPill(state)

Reproduction script output:

=== Issue #93041: Codex Usage UI Verification ===

Fix applied: YES
Old code present: NO (removed)

renderChatQuotaPill function exists: YES
Sidebar calls renderChatSessionSelect with sessionSwitcherOnly: YES

Conclusion:
✅ The quota pill now renders even in the sidebar session switcher.
✅ Fix: 1 line change (remove sessionSwitcherOnly guard on quotaPill).

Test suite:

 Test Files  1 passed (1)
      Tests  104 passed (104)

observedResult

The renderChatQuotaPill(state) call is no longer gated behind sessionSwitcherOnly. When the sidebar renders renderChatSessionSelect(state, switchChatSession, { compact: collapsed, sessionSwitcherOnly: true, surface: "sidebar" }), the quota pill is now included in the output.

notTested

End-to-end visual rendering verification in a browser. The quota pill renders as a styled <a> element with data-chat-provider-usage="true" attribute; its CSS grid placement is already handled by the --has-quota class modifier.

Regression Test Plan

pnpm test -- --run ui/src/ui/views/chat.test.ts passes (104/104)
Source diff confirms only the sessionSwitcherOnly guard is removed
renderChatQuotaPill function and its data path remain unchanged
CSS already handles the quota pill in the session-row grid via --has-quota class

AI-assisted: built with Claude Code

…itcher PR openclaw#88772 ("calm composer controls") replaced the old chat header (which rendered renderChatQuotaPill via renderChatSessionSelect) with a sidebar that calls renderChatSessionSelect with sessionSwitcherOnly: true. The quota pill was inadvertently suppressed because it was gated on !sessionSwitcherOnly alongside the model selector. Fix by rendering the quota pill unconditionally — the data path remains intact. Closes openclaw#93041 Co-Authored-By: Claude Sonnet 4.6 <[email protected]>

qingminglong · 2026-06-15T04:11:05Z

@clawsweeper re-review

clawsweeper · 2026-06-15T04:11:08Z

🦞🧹
ClawSweeper re-review requested.

I asked ClawSweeper to review this item again.
Action: item re-review queued (workflow sweep.yml, event repository_dispatch).
Result: the existing ClawSweeper review comment will be edited in place when the review finishes.

Re-review progress:

State: Complete
Detail: The targeted re-review finished, the durable review comment was updated, and the synced verdict was routed.
Run: https://github.com/openclaw/clawsweeper/actions/runs/27523489900
Updated: 2026-06-15T04:19:26.927Z

clawsweeper · 2026-06-15T04:13:53Z

Thanks for the context here. I swept through the related work, and this is now duplicate or superseded.

Close: this one-line branch addresses the right regression but is superseded by a newer viable PR that handles the sidebar compact state, adds the missing quota grid layout, and includes regression coverage and stronger proof.

Root-cause cluster
Relationship: superseded
Canonical: #94219
Summary: This PR and the newer canonical PR address the same Control UI quota regression; the newer PR is the viable landing path because it includes the missing sidebar layout, compact-state behavior, tests, and stronger proof.

Members:

canonical: fix(control-ui): restore provider usage quota pill in sidebar session switcher (fixes #93041) #94219 - It is open, mergeable, targets the same regression, and contains the compact gate, CSS grid rows, regression tests, and copied live render proof missing here.
fixed_by_candidate: [Bug]: After 2026.6.6 no Codex usage\limit UI present in the Control UI Chat interface #93041 - The issue is the open user-reported regression that both PRs target, and the canonical PR uses closing syntax for it.
partial_overlap: fix(ui): restore provider usage pill in desktop chat composer [AI] #93055 - The merged PR restored the quota pill in the desktop composer path but did not cover the sidebar session-switcher path that remains open here.
adjacent_distinct: feat: calm composer controls #88772 - The merged calm-composer/sidebar work is regression provenance, not a remaining fix candidate.

Proposal only: this assessment does not dispatch repair, suppress jobs, mutate sibling items, close, or merge anything.

Canonical path: Close this branch and focus maintainer review on #94219 or an equivalent patch with compact gating, sidebar quota layout, tests, and real render proof.

So I’m closing this here and keeping the remaining discussion on #94219.

Review details

Best possible solution:

Close this branch and focus maintainer review on #94219 or an equivalent patch with compact gating, sidebar quota layout, tests, and real render proof.

Do we have a high-confidence way to reproduce the issue?

Yes, source-reproducible: current main passes the sidebar through sessionSwitcherOnly: true, and session-controls.ts suppresses the quota pill on that path. I did not run a browser reproduction in this read-only review.

Is this the best way to solve the issue?

No. Rendering the existing pill in the sidebar is the right layer, but this branch is too narrow because it lacks compact-state handling, sidebar quota layout, regression coverage, and convincing real Control UI proof.

Security review:

Security review cleared: The diff is limited to one UI render expression and does not touch credentials, dependencies, workflows, package metadata, or code execution surfaces.

AGENTS.md: found and applied where relevant.

What I checked:

Current sidebar caller: Current main calls renderChatSessionSelect from the sidebar with compact: collapsed and sessionSwitcherOnly: true, so a fix must account for expanded and collapsed sidebar modes. (ui/src/ui/app-render.ts:587, f60aec6e9da0)
Current suppression root cause: Current main suppresses quotaPill whenever sessionSwitcherOnly is true, matching the reported missing sidebar quota path. (ui/src/ui/chat/session-controls.ts:97, f60aec6e9da0)
This PR is too narrow: The PR only changes the quota guard to unconditional rendering; it does not add compact-state suppression, sidebar quota grid CSS, or regression tests. (ui/src/ui/chat/session-controls.ts:97, 53012c96485e)
Layout gap on main: The current session-switcher grid defines only agent and session areas, while the quota pill uses grid-area: quota and a 104px minimum width. (ui/src/styles/chat/layout.css:1806, f60aec6e9da0)
Superseding PR: fix(control-ui): restore provider usage quota pill in sidebar session switcher (fixes #93041) #94219 changes the gate to compact, adds session-switcher quota grid areas, and adds expanded/collapsed sidebar regression tests. (ui/src/ui/chat/session-controls.ts:97, 88254cda763b)
Canonical issue and proof context: The open regression report confirms the sidebar/sessionSwitcherOnly root cause, and the newer PR is linked as a candidate fix for the same issue with copied live render output and tests.

Likely related people:

steipete: GitHub and git history show provider quota UI work and the calm-composer sidebar move both touched the affected quota/session switcher path. (role: provider quota feature owner and sidebar refactor author; confidence: high; commits: 8178a6c94946, 2b30951b8090; files: ui/src/ui/chat/session-controls.ts, ui/src/ui/provider-quota-summary.ts, ui/src/ui/app-render.ts)
harjothkhara: Authored the merged desktop chat composer quota repair for the same reported regression family shortly before this sidebar-focused follow-up. (role: recent adjacent quota repair contributor; confidence: medium; commits: 5a9396ef6dba; files: ui/src/ui/app-render.helpers.ts, ui/src/ui/app-render.ts, ui/src/ui/e2e/chat-quota-pill-93041.e2e.test.ts)
Solvely-Colin: Recent session workspace rail work touched the same chat/sidebar rendering area referenced in the regression discussion. (role: recent adjacent sidebar UI contributor; confidence: medium; commits: fd855c831f77; files: ui/src/ui/app-render.ts, ui/src/ui/views/chat.ts, ui/src/ui/views/chat.test.ts)

Codex review notes: model internal, reasoning high; reviewed against f60aec6e9da0.

qingminglong · 2026-06-18T07:47:17Z

qingminglong · 2026-06-18T07:48:55Z

please help me

openclaw-barnacle Bot added app: web-ui App: web-ui size: XS labels Jun 15, 2026

openclaw-barnacle Bot added the triage: needs-real-behavior-proof Candidate: external PR needs after-fix proof from a real setup. label Jun 15, 2026

Pick-cat mentioned this pull request Jun 17, 2026

fix(control-ui): restore provider usage quota pill in sidebar session switcher (fixes #93041) #94219

Merged

clawsweeper Bot added the proof: 📸 screenshot Contributor real behavior proof includes screenshot evidence. label Jun 19, 2026

Merge branch 'main' into fix/issue-93041-codex-usage-ui

ac0326f

openclaw-barnacle Bot added the triage: needs-pr-context Candidate: external PR body lacks required problem context or evidence. label Jun 20, 2026

Merge branch 'main' into fix/issue-93041-codex-usage-ui

2ffa012

qingminglong closed this Jun 20, 2026

This was referenced Jun 20, 2026

fix #93041: [Bug]: After 2026.6.6 no Codex usage\limit UI present in the Control UI Chat interface #95317

Closed

[Bug]: After 2026.6.6 no Codex usage\limit UI present in the Control UI Chat interface #93041

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Uh oh!

#93041: fix(control-ui): restore Codex usage quota pill in sidebar session switcher#93157

#93041: fix(control-ui): restore Codex usage quota pill in sidebar session switcher#93157
qingminglong wants to merge 3 commits into
openclaw:mainfrom
qingminglong:fix/issue-93041-codex-usage-ui

qingminglong commented Jun 15, 2026

Uh oh!

qingminglong commented Jun 15, 2026

Uh oh!

clawsweeper Bot commented Jun 15, 2026 •

edited

Loading

Uh oh!

clawsweeper Bot commented Jun 15, 2026 •

edited

Loading

Uh oh!

qingminglong commented Jun 18, 2026

Uh oh!

qingminglong commented Jun 18, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

Uh oh!

Uh oh!

Conversation

qingminglong commented Jun 15, 2026

Summary

Root Cause

Real behavior proof

behavior

environment

steps

evidence

observedResult

notTested

Regression Test Plan

Uh oh!

qingminglong commented Jun 15, 2026

Uh oh!

clawsweeper Bot commented Jun 15, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

clawsweeper Bot commented Jun 15, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

qingminglong commented Jun 18, 2026

Uh oh!

qingminglong commented Jun 18, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

clawsweeper Bot commented Jun 15, 2026 •

edited

Loading

clawsweeper Bot commented Jun 15, 2026 •

edited

Loading