test: probe temp helper CI warning#93155
Conversation
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
|
Codex review: found issues before merge. Reviewed June 15, 2026, 12:13 AM ET / 04:13 UTC. Summary PR surface: Tests +15. Total +15 across 1 file. Reproducibility: not applicable. as a bug reproduction. The PR's expected behavior was confirmed by the CI check-run annotation on the added line. Review metrics: 1 noteworthy metric.
Merge readiness Overall follows the weaker of proof and patch quality, so missing proof can cap an otherwise strong patch. Rank-up moves:
Risk before merge
Maintainer options:
Next step before merge
Security Review findings
Review detailsBest possible solution: Keep the merged warning reporter from #87298, then either close this probe unmerged or update it to a permanent helper-backed/no-warning test if maintainers want one. Do we have a high-confidence way to reproduce the issue? Not applicable as a bug reproduction. The PR's expected behavior was confirmed by the CI check-run annotation on the added line. Is this the best way to solve the issue? No for landing as-is: the branch is a useful one-off CI probe, but the PR body names the safer final state as using the temp-dir helper once annotation shape is confirmed. Full review comments:
Overall correctness: patch is incorrect AGENTS.md: found and applied where relevant. Codex review notes: model internal, reasoning high; reviewed against 1db8ab373422. Label changesLabel changes:
Label justifications:
Evidence reviewedPR surface: Tests +15. Total +15 across 1 file. View PR surface stats
What I checked:
Likely related people:
What the crustacean ranks mean
Shiny media proof means a screenshot, video, or linked artifact directly shows the changed behavior. Runtime, network, CSP, and security claims still need visible diagnostics. How this review workflow works
|
|
Validation complete. This temporary probe successfully confirmed the report-only temp-dir helper CI behavior:
Result: the validation succeeded. We are keeping the current warning-only implementation for now and closing this probe PR unmerged. |
|
Closing this temporary validation PR unmerged. The temp-dir helper warning behavior was confirmed, and we are keeping the current warning-only implementation for now. |
Summary
fs.mkdtempSync(path.join(os.tmpdir(), ...)).test/helpers/temp-dir.tsso the warning disappears.Expected CI behavior
scripts/report-test-temp-creations.mjsshould emit a GitHub warning ontest/scripts/temp-helper-warning-probe.test.ts:8.Local verification
node scripts/report-test-temp-creations.mjs --base origin/main --head HEAD --jsonGITHUB_ACTIONS=true node scripts/report-test-temp-creations.mjs --base origin/main --head HEADpnpm exec vitest run test/scripts/temp-helper-warning-probe.test.tsgit diff --check origin/main...HEAD