fix(agents): preserve fresh usage after compaction#93084
Conversation
Co-authored-by: HollyChou <[email protected]> Co-authored-by: 吴杨帆 <[email protected]>
Co-authored-by: HollyChou <[email protected]> Co-authored-by: de1ty <[email protected]> Co-authored-by: 吴杨帆 <[email protected]> Co-authored-by: Zhao Shiqi <[email protected]>
|
Codex review: needs changes before merge. Reviewed June 14, 2026, 7:30 PM ET / 23:30 UTC. Summary PR surface: Source +11, Tests +213, Docs 0. Total +224 across 5 files. Reproducibility: yes. Source inspection shows current main runs the cleanup after final compaction and unconditionally zeroes every assistant usage snapshot; I did not run a live TUI/gateway reproduction in this read-only review. Review metrics: none identified. Merge readiness Overall follows the weaker of proof and patch quality, so missing proof can cap an otherwise strong patch. Rank-up moves:
Risk before merge
Maintainer options:
Next step before merge
Security Review findings
Review detailsBest possible solution: Land the shared helper and focused handler tests after dropping the Do we have a high-confidence way to reproduce the issue? Yes. Source inspection shows current main runs the cleanup after final compaction and unconditionally zeroes every assistant usage snapshot; I did not run a live TUI/gateway reproduction in this read-only review. Is this the best way to solve the issue? Mostly yes. The runtime change targets the live compaction handler and shares the replay sanitizer invariant, but the release-owned changelog edit is not part of the correct fix. Full review comments:
Overall correctness: patch is correct AGENTS.md: found and applied where relevant. Codex review notes: model internal, reasoning high; reviewed against f1b8827d20c8. Label changesLabel justifications:
Evidence reviewedPR surface: Source +11, Tests +213, Docs 0. Total +224 across 5 files. View PR surface stats
Acceptance criteria:
What I checked:
Likely related people:
What the crustacean ranks mean
Shiny media proof means a screenshot, video, or linked artifact directly shows the changed behavior. Runtime, network, CSP, and security claims still need visible diagnostics. How this review workflow works
|
* fix(compaction): preserve fresh usage after compaction Co-authored-by: HollyChou <[email protected]> Co-authored-by: 吴杨帆 <[email protected]> * fix(compaction): satisfy stale usage timestamp narrowing * fix(clownfish): address review for ghcrawl-156678-autonomous-smoke (1) Co-authored-by: HollyChou <[email protected]> Co-authored-by: de1ty <[email protected]> Co-authored-by: 吴杨帆 <[email protected]> Co-authored-by: Zhao Shiqi <[email protected]> --------- Co-authored-by: openclaw-clownfish[bot] <280122609+openclaw-clownfish[bot]@users.noreply.github.com> Co-authored-by: 吴杨帆 <[email protected]> Co-authored-by: Vincent Koc <[email protected]> Co-authored-by: Zhao Shiqi <[email protected]>
* fix(compaction): preserve fresh usage after compaction Co-authored-by: HollyChou <[email protected]> Co-authored-by: 吴杨帆 <[email protected]> * fix(compaction): satisfy stale usage timestamp narrowing * fix(clownfish): address review for ghcrawl-156678-autonomous-smoke (1) Co-authored-by: HollyChou <[email protected]> Co-authored-by: de1ty <[email protected]> Co-authored-by: 吴杨帆 <[email protected]> Co-authored-by: Zhao Shiqi <[email protected]> --------- Co-authored-by: openclaw-clownfish[bot] <280122609+openclaw-clownfish[bot]@users.noreply.github.com> Co-authored-by: 吴杨帆 <[email protected]> Co-authored-by: Vincent Koc <[email protected]> Co-authored-by: Zhao Shiqi <[email protected]>
* fix(compaction): preserve fresh usage after compaction Co-authored-by: HollyChou <[email protected]> Co-authored-by: 吴杨帆 <[email protected]> * fix(compaction): satisfy stale usage timestamp narrowing * fix(clownfish): address review for ghcrawl-156678-autonomous-smoke (1) Co-authored-by: HollyChou <[email protected]> Co-authored-by: de1ty <[email protected]> Co-authored-by: 吴杨帆 <[email protected]> Co-authored-by: Zhao Shiqi <[email protected]> --------- Co-authored-by: openclaw-clownfish[bot] <280122609+openclaw-clownfish[bot]@users.noreply.github.com> Co-authored-by: 吴杨帆 <[email protected]> Co-authored-by: Vincent Koc <[email protected]> Co-authored-by: Zhao Shiqi <[email protected]>
* fix(compaction): preserve fresh usage after compaction Co-authored-by: HollyChou <[email protected]> Co-authored-by: 吴杨帆 <[email protected]> * fix(compaction): satisfy stale usage timestamp narrowing * fix(clownfish): address review for ghcrawl-156678-autonomous-smoke (1) Co-authored-by: HollyChou <[email protected]> Co-authored-by: de1ty <[email protected]> Co-authored-by: 吴杨帆 <[email protected]> Co-authored-by: Zhao Shiqi <[email protected]> --------- Co-authored-by: openclaw-clownfish[bot] <280122609+openclaw-clownfish[bot]@users.noreply.github.com> Co-authored-by: 吴杨帆 <[email protected]> Co-authored-by: Vincent Koc <[email protected]> Co-authored-by: Zhao Shiqi <[email protected]>
Summary
completedpayload behavior intact.Credit
Clownfish replacement for #50795. This carries forward attribution for @Hollychou924 in #50845, @leno23 in #82874, @de1tydev in #69270, and @425072024 in #91468.
Validation
Clownfish 🐠 replacement reef notes:
fish notes: model gpt-5.5, reasoning xhigh; reviewed against 0f37405.
Fixes #50795