fix(qqbot): honor durable media roots for cron TTS#92831
Conversation
|
Thanks for the context here. I swept through the related work, and this is now duplicate or superseded. Close in favor of the newer QQBot cron auto-TTS PR: it targets the same linked bug, is cleanly mergeable with sufficient live QQBot proof, and covers the sibling media gates this branch leaves incomplete. Canonical path: Use #92947 as the canonical landing path for the QQBot cron auto-TTS delivery fix, while keeping the already-merged QQBot error-surfacing behavior from #92823. So I’m closing this here and keeping the remaining discussion on #92947 and #92823. Review detailsBest possible solution: Use #92947 as the canonical landing path for the QQBot cron auto-TTS delivery fix, while keeping the already-merged QQBot error-surfacing behavior from #92823. Do we have a high-confidence way to reproduce the issue? Yes, at source level: current main passes durable media roots into channel send contexts while QQBot's local media gates do not accept the cron TTS temp-root file path. I did not run a live QQBot repro for this branch; the replacement PR supplies live after-fix proof. Is this the best way to solve the issue? No. This branch is a plausible partial fix, but the newer replacement PR is the better solution because it fixes the QQBot trust boundary consistently across all gates and includes live QQBot proof. Security review: Security review cleared: No concrete security or supply-chain concern was found in this branch; the blocker is functional completeness and proof, not malicious or dependency-sensitive change. AGENTS.md: found and applied where relevant. What I checked:
Likely related people:
Codex review notes: model internal, reasoning high; reviewed against a0b16f37e835. |
|
ClawSweeper applied the proposed close for this PR.
|
Summary
Testing
Closes #92816