fix(agents): pause yielded subagent runs whose terminal also signals abort#92631
Conversation
|
Codex review: needs maintainer review before merge. Reviewed June 13, 2026, 6:21 AM ET / 10:21 UTC. Summary PR surface: Source +11, Tests +179. Total +190 across 3 files. Reproducibility: yes. Source inspection shows Review metrics: none identified. Merge readiness Overall follows the weaker of proof and patch quality, so missing proof can cap an otherwise strong patch. Rank-up moves:
Risk before merge
Maintainer options:
Next step before merge
Security Review detailsBest possible solution: Land the focused lifecycle precedence fix after maintainer review and required checks, keeping task taxonomy, gateway protocol, config, and plugin surfaces unchanged. Do we have a high-confidence way to reproduce the issue? Yes. Source inspection shows Is this the best way to solve the issue? Yes. The PR changes the narrow owner path, aligns lifecycle event handling with the existing AGENTS.md: found and applied where relevant. Codex review notes: model internal, reasoning high; reviewed against 26281a8a1119. Label changesLabel justifications:
Evidence reviewedPR surface: Source +11, Tests +179. Total +190 across 3 files. View PR surface stats
What I checked:
Likely related people:
What the crustacean ranks mean
Shiny media proof means a screenshot, video, or linked artifact directly shows the changed behavior. Runtime, network, CSP, and security claims still need visible diagnostics. How this review workflow works
|
9d9d054 to
f5fa846
Compare
vincentkoc
left a comment
There was a problem hiding this comment.
Land-ready after maintainer fixup.
Summary:
- Preserves yielded subagent runs as paused even when the embedded runner also reports
aborted: true. - Added a follow-up fix so an already-scheduled lifecycle grace timer is cleared when
agent.wait()later observes the yield. - Added regression coverage for the abort-terminal-before-yield race.
Verification:
node_modules/.bin/oxfmt --check src/agents/subagent-registry.ts src/agents/subagent-registry-run-manager.ts src/agents/subagent-registry.test.ts.agents/skills/autoreview/scripts/autoreview --mode branch --base origin/main-> clean after the accepted timer-race finding was fixed- Crabbox Azure targeted proof:
run_3f25deac43e0/cbx_cbdc2925bc03,node scripts/run-vitest.mjs src/agents/subagent-registry.test.ts-> 63 tests passed - GitHub PR checks on
f5fa8469cb9d6600ec3e77a31fb4a400b02d1021: 132 successful, 0 failing, 0 pending
Notes:
- Blacksmith Testbox-through-Crabbox changed-gate attempts
tbx_01kv070f7dzfnzp0s46nv1ndyfandtbx_01kv07v4bv0akwry5td9ghpfyqboth failed before running project code because the Testbox host DNS did not resolve. GitHub CI covered the broad gate successfully after rerunning the transient opengrep installer failure.
…abort (openclaw#92631) * fix(agents): pause yielded subagent runs whose terminal also signals abort (openclaw#92448) * fix(agents): clear yielded subagent grace timers --------- Co-authored-by: Vincent Koc <[email protected]>
…26.6.8) (#1144) This PR contains the following updates: | Package | Update | Change | |---|---|---| | [ghcr.io/openclaw/openclaw](https://openclaw.ai) ([source](https://github.com/openclaw/openclaw)) | patch | `2026.6.6` → `2026.6.8` | --- ### Release Notes <details> <summary>openclaw/openclaw (ghcr.io/openclaw/openclaw)</summary> ### [`v2026.6.8`](https://github.com/openclaw/openclaw/blob/HEAD/CHANGELOG.md#202668) [Compare Source](openclaw/openclaw@v2026.6.6...v2026.6.8) ##### Highlights - Telegram and WhatsApp channel delivery are richer and less brittle: Telegram can send structured rich text with tables, lists, expandable blockquotes, prompt-preserving CLI backend delivery, retired native draft migration, and safer rich-media boundaries, while WhatsApp now honors configured ACP bindings. ([#​92679](openclaw/openclaw#92679), [#​84082](openclaw/openclaw#84082), [#​89421](openclaw/openclaw#89421), [#​92513](openclaw/openclaw#92513)) Thanks [@​obviyus](https://github.com/obviyus), [@​jzakirov](https://github.com/jzakirov), [@​spacegeologist](https://github.com/spacegeologist), and [@​TurboTheTurtle](https://github.com/TurboTheTurtle). - Agent and Gateway recovery is sharper across account-scoped DM sends, generated media completions, restart shutdown aborts, yielded subagent pauses, yielded cron media, heartbeat dedupe, session identity prompts, and unknown OpenAI agent selector rejection. ([#​92788](openclaw/openclaw#92788), [#​91246](openclaw/openclaw#91246), [#​91357](openclaw/openclaw#91357), [#​92631](openclaw/openclaw#92631), [#​92146](openclaw/openclaw#92146), [#​91287](openclaw/openclaw#91287), [#​92468](openclaw/openclaw#92468), [#​92510](openclaw/openclaw#92510)) Thanks [@​yetval](https://github.com/yetval), [@​TurboTheTurtle](https://github.com/TurboTheTurtle), [@​ooiuuii](https://github.com/ooiuuii), [@​openperf](https://github.com/openperf), [@​IWhatsskill](https://github.com/IWhatsskill), [@​ZengWen-DT](https://github.com/ZengWen-DT), and [@​zhangguiping-xydt](https://github.com/zhangguiping-xydt). - Provider/model handling expands and tightens with GLM-5.2, Claude Haiku 4.5 catalog rows, OpenRouter and Google Vertex provider-prefix normalization, managed SecretRef auth, bounded model browse discovery, storeless OpenAI Responses replay gating, and Claude 4.5 Copilot tool-streaming safety. ([#​92796](openclaw/openclaw#92796), [#​90116](openclaw/openclaw#90116), [#​92627](openclaw/openclaw#92627), [#​91218](openclaw/openclaw#91218), [#​90686](openclaw/openclaw#90686), [#​92247](openclaw/openclaw#92247), [#​90706](openclaw/openclaw#90706), [#​75393](openclaw/openclaw#75393)) Thanks [@​arkyu2077](https://github.com/arkyu2077), [@​liuhao1024](https://github.com/liuhao1024), [@​bymle](https://github.com/bymle), [@​rohitjavvadi](https://github.com/rohitjavvadi), [@​samson910022](https://github.com/samson910022), [@​snowzlm](https://github.com/snowzlm), and [@​Kailigithub](https://github.com/Kailigithub). - `/usage` and reply payload hooks now have a native full footer renderer, default template, fixed-decimal formatting, credential-aware limits, better partial-count handling, and warnings for broken templates instead of silent bad output. ([#​92657](openclaw/openclaw#92657), [#​89835](openclaw/openclaw#89835), [#​89629](openclaw/openclaw#89629)) Thanks [@​Marvinthebored](https://github.com/Marvinthebored). - UI and mobile flows are steadier: workspace files can collapse and start collapsed, WebChat backscroll survives streaming, the sidebar session picker remains interactive above the desktop workbench, reset soft args survive UI dispatch, stale dashboard session parent lineage is preserved, and iOS reconnects stale foreground gateways. ([#​92779](openclaw/openclaw#92779), [#​92622](openclaw/openclaw#92622), [#​92705](openclaw/openclaw#92705), [#​91353](openclaw/openclaw#91353), [#​90658](openclaw/openclaw#90658), [#​92552](openclaw/openclaw#92552)) Thanks [@​shakkernerd](https://github.com/shakkernerd), [@​TurboTheTurtle](https://github.com/TurboTheTurtle), [@​NianJiuZst](https://github.com/NianJiuZst), [@​zhouhe-xydt](https://github.com/zhouhe-xydt), [@​luoyanglang](https://github.com/luoyanglang), and [@​Solvely-Colin](https://github.com/Solvely-Colin). - Memory, state, and diagnostics recover cleaner: oversized OpenAI embedding batches split before 431s, QMD memory search stays available in transient mode, SQLite avoids WAL on NFS state volumes, stuck-session recovery scheduling no longer resets warning backoff, and Infinity chunk limits stay genuinely unbounded. ([#​92650](openclaw/openclaw#92650), [#​92618](openclaw/openclaw#92618), [#​92639](openclaw/openclaw#92639), [#​91247](openclaw/openclaw#91247), [#​92752](openclaw/openclaw#92752), [#​92735](openclaw/openclaw#92735)) Thanks [@​mushuiyu886](https://github.com/mushuiyu886), [@​TurboTheTurtle](https://github.com/TurboTheTurtle), [@​849261680](https://github.com/849261680), [@​gnanam1990](https://github.com/gnanam1990), and [@​yhterrance](https://github.com/yhterrance). ##### Changes - Providers/models: add GLM-5.2 support and Claude Haiku 4.5 catalog entries while keeping provider-qualified model IDs normalized across OpenRouter and Google Vertex paths. ([#​92796](openclaw/openclaw#92796), [#​90116](openclaw/openclaw#90116), [#​92627](openclaw/openclaw#92627), [#​91218](openclaw/openclaw#91218)) Thanks [@​arkyu2077](https://github.com/arkyu2077), [@​liuhao1024](https://github.com/liuhao1024), and [@​bymle](https://github.com/bymle). - Channel plugins: ship Telegram rich-message delivery and WhatsApp ACP binding support, including rich prompt handoff to CLI backends and transport fixtures for richer drafts. ([#​92679](openclaw/openclaw#92679), [#​92513](openclaw/openclaw#92513)) Thanks [@​obviyus](https://github.com/obviyus) and [@​TurboTheTurtle](https://github.com/TurboTheTurtle). - Agent commands: support `/btw` in CLI-backed sessions and keep CLI usage-error exits classified as usage failures instead of successful runs. ([#​92669](openclaw/openclaw#92669), [#​92162](openclaw/openclaw#92162)) Thanks [@​joshavant](https://github.com/joshavant) and [@​Pandah97](https://github.com/Pandah97). - Usage hooks: add built-in full footer rendering, default footer templates, per-turn usage state, credential-aware limits, and fixed-decimal formatting for usage-bar templates. ([#​92657](openclaw/openclaw#92657), [#​89835](openclaw/openclaw#89835), [#​89629](openclaw/openclaw#89629)) Thanks [@​Marvinthebored](https://github.com/Marvinthebored). - Docs and operator guidance: document node config examples, clarify before-install hook scope, correct agent default concurrency comments, refresh ZAI provider docs, and update channel/group docs for current Telegram and WhatsApp behavior. ([#​92677](openclaw/openclaw#92677), [#​92766](openclaw/openclaw#92766), [#​92695](openclaw/openclaw#92695)) Thanks [@​liuhao1024](https://github.com/liuhao1024), [@​sallyom](https://github.com/sallyom), and [@​ArielSmoliar](https://github.com/ArielSmoliar). ##### Fixes - Onboarding/skills: show the Homebrew install recommendation only on macOS and Linux, so FreeBSD and other unsupported platforms no longer get a misleading brew prompt. Fixes [#​68893](openclaw/openclaw#68893); carries forward [#​68894](openclaw/openclaw#68894), [#​68910](openclaw/openclaw#68910), [#​68941](openclaw/openclaw#68941), [#​68943](openclaw/openclaw#68943), [#​69002](openclaw/openclaw#69002), and [#​69545](openclaw/openclaw#69545). Thanks [@​yurivict](https://github.com/yurivict), [@​Sanjays2402](https://github.com/Sanjays2402), [@​Eruditi](https://github.com/Eruditi), [@​JustInCache](https://github.com/JustInCache), [@​nnish16](https://github.com/nnish16), and [@​Mlightsnow](https://github.com/Mlightsnow). - Channels and delivery: preserve account-scoped DM channel send policy, rich Telegram final replies, rich Telegram tables and lists, Telegram thread-create CLI remapping, Slack outbound `message_sent` hooks, contributed message-tool schema optionality, same-channel generated media completions, and channel chunking around surrogate pairs and Infinity limits. ([#​92788](openclaw/openclaw#92788), [#​92679](openclaw/openclaw#92679), [#​89421](openclaw/openclaw#89421), [#​89943](openclaw/openclaw#89943), [#​91137](openclaw/openclaw#91137), [#​91246](openclaw/openclaw#91246), [#​92735](openclaw/openclaw#92735)) Thanks [@​yetval](https://github.com/yetval), [@​obviyus](https://github.com/obviyus), [@​spacegeologist](https://github.com/spacegeologist), [@​rishitamrakar](https://github.com/rishitamrakar), [@​lundog](https://github.com/lundog), [@​TurboTheTurtle](https://github.com/TurboTheTurtle), and [@​yhterrance](https://github.com/yhterrance). - Auto-reply/groups: keep ordinary group text replies on automatic final-reply delivery while allowing `message(action=send)` for files, images, and other attachments to the same group or topic. Carries forward [#​43276](openclaw/openclaw#43276); refs [#​48004](openclaw/openclaw#48004). Thanks [@​NayukiChiba](https://github.com/NayukiChiba) and [@​ShakaRover](https://github.com/ShakaRover). - Auto-reply/skills: preserve multiline payloads for `/skill` and direct skill slash commands while keeping command-head normalization for aliases, colon syntax, and bot mentions. Fixes [#​79155](openclaw/openclaw#79155); carries forward [#​81305](openclaw/openclaw#81305). Thanks [@​web3blind](https://github.com/web3blind). - iMessage: normalize leading NUL sent-message echo prefixes while preserving interior NUL bytes and the leading attributedBody marker handling from [#​73942](openclaw/openclaw#73942). Carries forward [#​63581](openclaw/openclaw#63581). Thanks [@​drvoss](https://github.com/drvoss). - Discord: give generated auto-thread titles a 60-second timeout and 4,096-token reasoning-model output budget, clamped to the selected model output cap. ([#​64734](openclaw/openclaw#64734)) Thanks [@​hanamizuki](https://github.com/hanamizuki). - Agent, cron, and Gateway runtime: mark active main sessions before restart shutdown aborts, pause yielded subagent runs whose terminal also signals abort, preserve yielded media completions, de-duplicate main-session heartbeat events, expose session identity in runtime prompts, reject unknown OpenAI agent selectors, keep generated media completions and slash-command block replies in WebChat, preserve fresh post-compaction usage while clearing stale usage snapshots, and require admin privileges for HTTP session/model override surfaces. ([#​91357](openclaw/openclaw#91357), [#​92631](openclaw/openclaw#92631), [#​92146](openclaw/openclaw#92146), [#​91287](openclaw/openclaw#91287), [#​92468](openclaw/openclaw#92468), [#​92510](openclaw/openclaw#92510), [#​91246](openclaw/openclaw#91246), [#​50795](openclaw/openclaw#50795), [#​50845](openclaw/openclaw#50845), [#​82874](openclaw/openclaw#82874), [#​92651](openclaw/openclaw#92651), [#​92646](openclaw/openclaw#92646)) Thanks [@​ooiuuii](https://github.com/ooiuuii), [@​openperf](https://github.com/openperf), [@​IWhatsskill](https://github.com/IWhatsskill), [@​ZengWen-DT](https://github.com/ZengWen-DT), [@​zhangguiping-xydt](https://github.com/zhangguiping-xydt), [@​Hollychou924](https://github.com/Hollychou924), [@​leno23](https://github.com/leno23), and [@​TurboTheTurtle](https://github.com/TurboTheTurtle). - Agents/exec: default empty-success background completion notices on only for real chat channels, preserving explicit opt-outs and keeping generic providers silent while carrying forward the narrow UX intent from [#​39726](openclaw/openclaw#39726) and [#​46926](openclaw/openclaw#46926). Thanks [@​Sapientropic](https://github.com/Sapientropic) and [@​wenkang-xie](https://github.com/wenkang-xie). - Providers and model replay: preserve storeless OpenAI Responses replay compatibility, avoid eager tool streaming for Claude 4.5 in Copilot, honor profile auth for SecretRef model entries, bound model browsing, strip provider prefixes where runtimes need bare IDs, and surface nested embedding fetch failures. ([#​90706](openclaw/openclaw#90706), [#​75393](openclaw/openclaw#75393), [#​90686](openclaw/openclaw#90686), [#​92247](openclaw/openclaw#92247), [#​92627](openclaw/openclaw#92627), [#​91218](openclaw/openclaw#91218), [#​92628](openclaw/openclaw#92628)) Thanks [@​snowzlm](https://github.com/snowzlm), [@​Kailigithub](https://github.com/Kailigithub), [@​rohitjavvadi](https://github.com/rohitjavvadi), [@​samson910022](https://github.com/samson910022), [@​liuhao1024](https://github.com/liuhao1024), [@​bymle](https://github.com/bymle), and [@​mushuiyu886](https://github.com/mushuiyu886). - Memory, state, diagnostics, and config: split header-too-large embedding batches, keep QMD memory search enabled in transient mode, avoid SQLite WAL on NFS volumes, preserve recovery scheduling outside stuck-session warning backoff, and keep shell environment fallbacks contained in config write tests. ([#​92650](openclaw/openclaw#92650), [#​92618](openclaw/openclaw#92618), [#​92639](openclaw/openclaw#92639), [#​91247](openclaw/openclaw#91247), [#​92752](openclaw/openclaw#92752)) Thanks [@​mushuiyu886](https://github.com/mushuiyu886), [@​TurboTheTurtle](https://github.com/TurboTheTurtle), [@​849261680](https://github.com/849261680), and [@​gnanam1990](https://github.com/gnanam1990). - Workspace setup state: store setup completion outside the workspace dot directory using an OpenClaw-named root file, migrate valid legacy state forward, and avoid clobbering generic root `workspace-state.json` files for TigerFS-style dot-path compatibility. This Clownfish replacement carries forward the focused [#​53326](openclaw/openclaw#53326) fix idea because the original branch was closed and uneditable. ([#​53326](openclaw/openclaw#53326), [#​44783](openclaw/openclaw#44783), [#​39446](openclaw/openclaw#39446)) Thanks [@​1qh](https://github.com/1qh). - UI/mobile/TUI: preserve dashboard session parent lineage, WebChat backscroll, reset soft command args, sidebar session picker interactivity, collapsed workspace files, resolved `/model` confirmation refs, and stale foreground iOS Gateway reconnects. ([#​90658](openclaw/openclaw#90658), [#​92622](openclaw/openclaw#92622), [#​91353](openclaw/openclaw#91353), [#​92705](openclaw/openclaw#92705), [#​92779](openclaw/openclaw#92779), [#​92773](openclaw/openclaw#92773), [#​92552](openclaw/openclaw#92552)) Thanks [@​luoyanglang](https://github.com/luoyanglang), [@​TurboTheTurtle](https://github.com/TurboTheTurtle), [@​zhouhe-xydt](https://github.com/zhouhe-xydt), [@​NianJiuZst](https://github.com/NianJiuZst), [@​shakkernerd](https://github.com/shakkernerd), [@​NarahariRaghava](https://github.com/NarahariRaghava), and [@​Solvely-Colin](https://github.com/Solvely-Colin). - TUI: reload the active session after external `/new` or `/reset` session-change events so stale transcript and stream state clear promptly. Fixes [#​38966](openclaw/openclaw#38966); carries forward [#​40472](openclaw/openclaw#40472). Thanks [@​yizhanzjz](https://github.com/yizhanzjz) and [@​wsyjh8](https://github.com/wsyjh8). - Control UI: preserve Gateway Access tokens during same-normalized WebSocket URL edits and reload gateway-scoped tokens when switching endpoints. Fixes [#​41545](openclaw/openclaw#41545); repairs [#​42001](openclaw/openclaw#42001) with additional source PRs [#​41546](openclaw/openclaw#41546), [#​41552](openclaw/openclaw#41552), and [#​41718](openclaw/openclaw#41718). Thanks [@​wsyjh8](https://github.com/wsyjh8), [@​llagy0020](https://github.com/llagy0020), [@​llagy007](https://github.com/llagy007), [@​pingfanfan](https://github.com/pingfanfan), and [@​zheliu2](https://github.com/zheliu2). - Gateway CLI: tolerate a single transient clean WebSocket close before `hello-ok` so one-shot RPC calls reconnect instead of failing noisily, while repeated clean pre-hello closes still surface. Carries forward source PRs [#​54475](openclaw/openclaw#54475) and [#​54774](openclaw/openclaw#54774); [#​85253](openclaw/openclaw#85253) covered adjacent connect assembly diagnostics. Thanks [@​ruanrrn](https://github.com/ruanrrn). - Gateway/Linux: keep root-owned systemd user service lifecycle commands on root's user manager when a stale `SUDO_USER` remains in a root shell with root's user bus environment. Fixes [#​81410](openclaw/openclaw#81410). Thanks [@​Ericksza](https://github.com/Ericksza) and [@​ChuckClose-tech](https://github.com/ChuckClose-tech). - Release and test reliability: extend slow Gateway/full-suite watchdogs, split local full-suite shards when throttled, stabilize plugin auth marker fixtures, avoid brittle provider-ref error text, and keep QA Lab bootstrap selection assertions aligned with flow-only scenarios. ([#​92652](openclaw/openclaw#92652)) - macOS Peekaboo bridge: update the embedded Peekaboo package to 3.5.2 and route bundled-skill CLI commands through the OpenClaw app bridge so they inherit its Screen Recording and Accessibility grants. - Agent routing: route subagent RPC callbacks addressed to an agent-shaped `--to` target to the correct session key instead of falling back to the main session, so WeChat (and other channel) session-key callbacks reach the intended subagent session. ([#​90231](openclaw/openclaw#90231)) Thanks [@​zhangguiping-xydt](https://github.com/zhangguiping-xydt). - Cron: preserve model, fallback, thinking, timeout, light-context, unsafe-content, and tool allow-list overrides on implicit text payloads by promoting them to agent turns, while explicit system events still prune those fields. Fixes [#​28905](openclaw/openclaw#28905); carries forward [#​64060](openclaw/openclaw#64060) and [#​73946](openclaw/openclaw#73946). Thanks [@​liaoandi](https://github.com/liaoandi). - QQBot delivery: keep markdown table chunks self-contained across message boundaries by preserving table state across block deliveries, flushing unfinished table-row fragments as plain text, and detecting short pipe-terminated rows by column count so split rows are not sent as malformed markdown. ([#​92428](openclaw/openclaw#92428)) Thanks [@​sliverp](https://github.com/sliverp). </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about these updates again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiI0My4xMDEuMSIsInVwZGF0ZWRJblZlciI6IjQzLjEwMS4xIiwidGFyZ2V0QnJhbmNoIjoibWFpbiIsImxhYmVscyI6WyJyZW5vdmF0ZS9jb250YWluZXIiLCJ0eXBlL3BhdGNoIl19--> Reviewed-on: https://git.erwanleboucher.dev/eleboucher/homelab/pulls/1144
…abort (openclaw#92631) * fix(agents): pause yielded subagent runs whose terminal also signals abort (openclaw#92448) * fix(agents): clear yielded subagent grace timers --------- Co-authored-by: Vincent Koc <[email protected]>
…abort (openclaw#92631) * fix(agents): pause yielded subagent runs whose terminal also signals abort (openclaw#92448) * fix(agents): clear yielded subagent grace timers --------- Co-authored-by: Vincent Koc <[email protected]>
Summary
sessions_yieldwhile waiting on its own depth-2 children, the background task that tracks that subagent run is settled ascancelled, and aBackground task cancelled: Subagent task (run <id>)notice is delivered into the requester session and dispatched to the user channel (WhatsApp). Nothing was cancelled: no operatortasks cancel, no cancel tool call. The yielded subagent keeps orchestrating, runs all its planned steps, and produces the final deliverable minutes later — so the user sees a false hard-failure for a job that succeeds.sessions_yieldends the model turn by aborting the run's abort signal (reasonsessions_yield). A yielded subagent run's terminal lifecycle event can therefore carryyielded: truetogether withaborted: true(orstopReason: "aborted"), because the abort is the yield's own mechanism andisTerminalAborted()/ the terminal stop reason still observe the tripped signal. The subagent-registry lifecycle event handler classifies terminal events in this order:isAbortedAgentStopReason(stopReason)→ immediate kill (SUBAGENT_ENDED_REASON_KILLED), thenevt.data?.aborted→ deferred kill viaschedulePendingLifecycleTimeout, and only thenevt.data?.yielded === true→ pause. The aborted branches precede the yielded branch andreturnearly, so a yielded-but-also-aborted terminal is routed to the kill path, which maps to task statuscancelled.shouldAutoDeliverTaskTerminalUpdateauto-delivers a subagent terminal update to the requester only when the status iscancelled, so the false notice reaches the end user. The run-manager wait path already giveswait.yielded === trueprecedence; the event path did not — an asymmetry. This explains both reported timings:stopReason: "aborted"→ same-second kill;aborted: trueflag → ~21s deferred kill via the pending-lifecycle timeout.yielded === trueterminal authoritative — pause the run (matching the wait path) before the abort / stop-reason-aborted / blocked classifications. A yield is intentional model behavior; the abort is merely how the turn ends, so it must not be reclassified as a kill.src/agents/subagent-registry.ts— move theevt.data?.yielded === true→markSubagentRunPausedAfterYieldbranch ahead of the abort / stop-reason-aborted / blocked branches in the lifecycle event handler, and document the yield-via-abort invariant.src/agents/subagent-registry.test.ts— regression covering both yielded-but-aborted terminal shapes.markSubagentRunPausedAfterYield, and the run-manager wait path are unchanged.phase === "error"early path is unchanged (it settlesfailed, not the reportedcancelled).task-executor-policyauto-deliver gate are unchanged.docs/reference/config).extensions/*api/runtime-api, registry/loader).Reproduction
mainspawns a depth-1 subagent (workflow-lead) viasessions_spawn.workflow-leadspawns its own depth-2 child, then callssessions_yieldto wait on it.workflow-lead's run signal, so its terminal lifecycle event carriesyielded: truetogether withaborted: true(orstopReason: "aborted").cancelled(SUBAGENT_ENDED_REASON_KILLED), andshouldAutoDeliverTaskTerminalUpdatedelivers a falseBackground task cancellednotice into the requester session and out to the user channel — while the subagent keeps orchestrating and ultimately succeeds.pauseReason: "sessions_yield"), no kill/farewell fires, and no cancellation notice reaches the requester.Real behavior proof
Behavior addressed (#92448): a subagent run that yields while waiting on children is no longer settled
cancelledwhen its terminal lifecycle event also carries the yield-induced abort signal, and no falseBackground task cancellednotice is delivered to the requester.Real environment tested (Linux, Node 22 — Vitest against the production
subagent-registrylifecycle event handler and live run store): the regression drives the realonAgentEventlifecycle handler with the exact terminal event shapes the embedded runner emits for a yielded-but-aborted run, against the live subagent run registry (registerSubagentRun/listSubagentRunsForRequester).Exact steps or command run after this patch:
node scripts/run-vitest.mjs src/agents/subagent-registry.test.ts;npx oxfmt --check --threads=1andnpx oxlint --tsconfig config/tsconfig/oxlint.core.jsonon the two changed files.Evidence after fix (Vitest output for the touched test file):
Observed result after fix: feeding the handler
{phase:"end", yielded:true, stopReason:"aborted"}and{phase:"end", yielded:true, aborted:true}marks the runpauseReason:"sessions_yield"with noerroroutcome and norunSubagentAnnounceFlow(farewell/notice) call. On the unpatched tree the same two events leavepauseReasonundefined (the run is routed to the kill /cancelledpath), so the regression fails — confirming the test covers the production change.What was not tested: the live WhatsApp gateway end-to-end with a real depth-1 -> depth-2 subagent chain on the reporter's deployment. The defect and fix are proven deterministically at the exact lifecycle-event altitude where the misclassification happens; a full multi-agent gateway round-trip was not driven.
Repro confirmation: both terminal event shapes fail on the unpatched handler (run routed to the kill path,
pauseReasonundefined) and pass with the fix.Risk / Mitigation
evt.data?.yielded === true, which is set solely when the model explicitly calledsessions_yield(yieldDetected); a genuine operator/parent cancel does not setyieldedon the same terminal event, so it still reaches the kill path.wait.yielded === true— the two terminal observers are symmetric.Change Type (select all)
Scope (select all touched areas)
Linked Issue/PR
Fixes #92448