fix: dedupe cleaned assistant transcript entries for session-memory#92571
fix: dedupe cleaned assistant transcript entries for session-memory#92571arkyu2077 wants to merge 1 commit into
Conversation
|
Thanks for the context here. I swept through the related work, and this is now duplicate or superseded. Close: this PR is now superseded by #94401, which is open, mergeable, proof-sufficient, uses the existing transcript-only assistant predicate, and owns the same session-memory duplicate-assistant-lines fix more directly. Root-cause cluster Members:
Proposal only: this assessment does not dispatch repair, suppress jobs, mutate sibling items, close, or merge anything. Canonical path: Close this duplicate branch and continue review on #94401 as the canonical session-memory transcript-only assistant filter for the linked user bug. So I’m closing this here and keeping the remaining discussion on #94401. Review detailsBest possible solution: Close this duplicate branch and continue review on #94401 as the canonical session-memory transcript-only assistant filter for the linked user bug. Do we have a high-confidence way to reproduce the issue? Yes at source level: current main extracts text from every accepted assistant JSONL row, so raw thinking output and cleaned transcript-only assistant rows can both enter generated session-memory content. I did not run tests or live provider flows because this review is read-only. Is this the best way to solve the issue? No, this branch is no longer the best landing path. The newer canonical PR uses the existing shared transcript-only assistant predicate, has focused coverage and proof-sufficient labeling, and avoids keeping another parentId/text dedupe implementation open. Security review: Security review cleared: The diff only changes local transcript filtering and tests; it does not touch dependencies, workflows, secrets, permissions, network calls, or code-execution surfaces. AGENTS.md: found and applied where relevant. What I checked:
Likely related people:
Codex review notes: model internal, reasoning high; reviewed against 23b8f5d03782. |
|
ClawSweeper applied the proposed close for this PR.
|
Summary
Testing
Closes #92563