Skip to content

fix: dedupe cleaned assistant transcript entries for session-memory#92571

Closed
arkyu2077 wants to merge 1 commit into
openclaw:mainfrom
arkyu2077:fix/issue-92563
Closed

fix: dedupe cleaned assistant transcript entries for session-memory#92571
arkyu2077 wants to merge 1 commit into
openclaw:mainfrom
arkyu2077:fix/issue-92563

Conversation

@arkyu2077

Copy link
Copy Markdown
Contributor

Summary

Testing

  • node --import tsx /tmp/issue-92563-check.mjs

Closes #92563

@openclaw-barnacle openclaw-barnacle Bot added size: S triage: needs-real-behavior-proof Candidate: external PR needs after-fix proof from a real setup. labels Jun 13, 2026
@clawsweeper

clawsweeper Bot commented Jun 13, 2026

Copy link
Copy Markdown
Contributor

Thanks for the context here. I swept through the related work, and this is now duplicate or superseded.

Close: this PR is now superseded by #94401, which is open, mergeable, proof-sufficient, uses the existing transcript-only assistant predicate, and owns the same session-memory duplicate-assistant-lines fix more directly.

Root-cause cluster
Relationship: superseded
Canonical: #94401
Summary: This PR is superseded by a newer open, mergeable, proof-sufficient replacement PR for the same session-memory duplicate assistant-lines bug.

Members:

Proposal only: this assessment does not dispatch repair, suppress jobs, mutate sibling items, close, or merge anything.

Canonical path: Close this duplicate branch and continue review on #94401 as the canonical session-memory transcript-only assistant filter for the linked user bug.

So I’m closing this here and keeping the remaining discussion on #94401.

Review details

Best possible solution:

Close this duplicate branch and continue review on #94401 as the canonical session-memory transcript-only assistant filter for the linked user bug.

Do we have a high-confidence way to reproduce the issue?

Yes at source level: current main extracts text from every accepted assistant JSONL row, so raw thinking output and cleaned transcript-only assistant rows can both enter generated session-memory content. I did not run tests or live provider flows because this review is read-only.

Is this the best way to solve the issue?

No, this branch is no longer the best landing path. The newer canonical PR uses the existing shared transcript-only assistant predicate, has focused coverage and proof-sufficient labeling, and avoids keeping another parentId/text dedupe implementation open.

Security review:

Security review cleared: The diff only changes local transcript filtering and tests; it does not touch dependencies, workflows, secrets, permissions, network calls, or code-execution surfaces.

AGENTS.md: found and applied where relevant.

What I checked:

Likely related people:

  • Vincent Koc: Current blame on the session-memory transcript helper and shared transcript-only assistant helper points to recent current-main work. (role: recent area contributor; confidence: high; commits: 78b561807134; files: src/hooks/bundled/session-memory/transcript.ts, src/shared/transcript-only-openclaw-assistant.ts)
  • Peter Steinberger: History shows the internal hooks system introduced the session-memory hook surface and later runtime seam work in this area. (role: introduced behavior and adjacent owner; confidence: high; commits: faba508fe0ae, 8727338372b4; files: src/hooks/bundled/session-memory/handler.ts, src/hooks/bundled/session-memory/HOOK.md, src/hooks/bundled/session-memory/transcript.ts)
  • Tomas Hajek: Added the rotated transcript fallback used by the same session-memory reader path after /new. (role: adjacent transcript fallback contributor; confidence: medium; commits: 19ae7a4e17d8; files: src/hooks/bundled/session-memory/handler.ts, src/hooks/bundled/session-memory/handler.test.ts, src/hooks/bundled/session-memory/transcript.ts)
  • NianJiuZst: Reviewed the newer replacement PR and steered it toward the shared transcript-only helper plus focused regression coverage. (role: reviewer of canonical replacement; confidence: medium; files: src/hooks/bundled/session-memory/transcript.ts, src/hooks/bundled/session-memory/handler.test.ts)

Codex review notes: model internal, reasoning high; reviewed against 23b8f5d03782.

@clawsweeper clawsweeper Bot added the rating: 🌊 off-meta tidepool PR readiness rating does not apply to this item. label Jun 13, 2026
@clawsweeper clawsweeper Bot added rating: 🧂 unranked krab Not merge-ready due to missing proof or serious correctness/safety concerns. status: 📣 needs proof The PR needs real behavior proof before ClawSweeper can clear the contributor ask. P2 Normal backlog priority with limited blast radius. merge-risk: 🚨 session-state 🚨 May lose, corrupt, stale, or mis-associate session, agent, or context state. and removed rating: 🌊 off-meta tidepool PR readiness rating does not apply to this item. rating: 🧂 unranked krab Not merge-ready due to missing proof or serious correctness/safety concerns. status: 📣 needs proof The PR needs real behavior proof before ClawSweeper can clear the contributor ask. labels Jun 15, 2026
@clawsweeper

clawsweeper Bot commented Jun 19, 2026

Copy link
Copy Markdown
Contributor

ClawSweeper applied the proposed close for this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

merge-risk: 🚨 session-state 🚨 May lose, corrupt, stale, or mis-associate session, agent, or context state. P2 Normal backlog priority with limited blast radius. rating: 🧂 unranked krab Not merge-ready due to missing proof or serious correctness/safety concerns. size: S status: 📣 needs proof The PR needs real behavior proof before ClawSweeper can clear the contributor ask. triage: needs-real-behavior-proof Candidate: external PR needs after-fix proof from a real setup.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

session-memory hook duplicates assistant messages when thinking is stripped

1 participant