fix(workboard): let gateway resolve dispatch scopes#92066
Conversation
|
Thanks for the context here. I swept through the related work, and this is now duplicate or superseded. Close: the linked Workboard dispatch failure is now fixed by the merged Gateway attached-registry authorization path, while this PR remains a Workboard-only workaround that would broaden the CLI's requested scopes. Root-cause cluster Members:
Proposal only: this assessment does not dispatch repair, suppress jobs, mutate sibling items, close, or merge anything. Canonical path: Live GitHub data shows #94343 merged on 2026-06-19 with merge commit 27f702d and was merged by steipete. So I’m closing this here and keeping the remaining discussion on #94343. Review detailsBest possible solution: Keep the merged Gateway attached-registry authorization fix, preserve Workboard's explicit CLI read/write scope contract, and close this superseded workaround branch. Do we have a high-confidence way to reproduce the issue? Yes. The old failure is source-reproducible from Workboard's explicit read/write CLI scopes meeting Gateway's old admin fallback, and current main now has an attached-registry authorization regression test for the same method. Is this the best way to solve the issue? No. The merged Gateway attached-registry authorization fix is the owner-boundary solution; this PR is now a narrower workaround that removes a least-privilege Workboard CLI scope contract. Security review: Security review needs attention: The diff removes a least-privilege Workboard CLI scope override and can broaden dispatch to the default admin-capable CLI scope set.
AGENTS.md: found and applied where relevant. What I checked:
Likely related people:
Codex review notes: model internal, reasoning high; reviewed against 07b934901a32; fix evidence: release v2026.6.10, commit 27f702d68fab. |
Summary\n- stop hardcoding workboard dispatch CLI scopes to write/read\n- let the gateway CLI runtime choose scopes for plugin methods it cannot classify locally\n- add coverage that dispatch forwards scope selection to the gateway runtime\n\n## Testing\n- node scripts/run-vitest.mjs extensions/workboard/src/cli.test.ts\n\nFixes #92044