fix(memory): honor configured qmd search timeouts#92065
Conversation
|
Thanks for the context here. I swept through the related work, and this is now duplicate or superseded. Close this PR as superseded: the underlying QMD memory_search timeout bug is still real, but this branch uses the rejected fixed-overhead timeout shape and is now replaced by the canonical issue plus the newer manager-owned candidate PR with real QMD proof. Root-cause cluster Members:
Proposal only: this assessment does not dispatch repair, suppress jobs, mutate sibling items, close, or merge anything. Canonical path: Keep #91947 as the canonical tracker and review #95347, or another manager-owned whole-search budget fix, instead of this branch. So I’m closing this here and keeping the remaining discussion on #91947 and #95347. Review detailsBest possible solution: Keep #91947 as the canonical tracker and review #95347, or another manager-owned whole-search budget fix, instead of this branch. Do we have a high-confidence way to reproduce the issue? Yes. Current main and v2026.6.9 wrap memory_search in a fixed 15s deadline while the linked issue shows QMD query work exceeding that budget with a larger configured QMD timeout. Is this the best way to solve the issue? No. This PR is not the best fix because a single QMD command timeout plus 5s does not cover QMD's whole search lifecycle; the safer replacement is the manager-owned budget in #95347. Security review: Security review cleared: No concrete security or supply-chain concern found; the diff only changes memory-core timeout logic and tests without dependency, workflow, secret, package-resolution, or downloaded-code changes. AGENTS.md: found and applied where relevant. What I checked:
Likely related people:
Codex review notes: model internal, reasoning high; reviewed against 6daf9307e0b9. |
|
ClawSweeper applied the proposed close for this PR.
|
Summary\n- derive the memory_search tool deadline from the configured QMD timeout when the qmd backend is active\n- keep a bounded wrapper overhead so hung searches still fail cleanly\n- add regression coverage for slow successful QMD searches and timeout behavior\n\n## Testing\n- node scripts/run-vitest.mjs extensions/memory-core/src/tools.test.ts\n\nFixes #91947