Skip to content

fix(exec): honor state dir approvals#92056

Merged
vincentkoc merged 1 commit into
mainfrom
fix/exec-approvals-state-dir
Jun 11, 2026
Merged

fix(exec): honor state dir approvals#92056
vincentkoc merged 1 commit into
mainfrom
fix/exec-approvals-state-dir

Conversation

@vincentkoc

Copy link
Copy Markdown
Member

Summary

  • Move exec approvals file/socket defaults under OPENCLAW_STATE_DIR when set.
  • Import the previous approvals file into the custom state dir through doctor/startup migrations, including macOS host support.
  • Fail closed without writing a replacement file while a legacy approvals file is pending or migration is blocked.
  • Update CLI/docs/operator-facing path text for state-dir-aware approvals.

Supersedes #74002 with a guarded migration path and follow-up fixes.

Validation

  • node scripts/run-vitest.mjs src/infra/exec-approvals-store.test.ts src/commands/doctor-state-migrations.test.ts src/commands/doctor-config-preflight.state-migration.test.ts src/cli/program/config-guard.test.ts src/infra/exec-approvals-policy.test.ts src/commands/doctor-security.test.ts src/agents/bash-tools.exec-host-shared.test.ts
  • npm exec --yes [email protected] -- pnpm docs:list
  • ./node_modules/.bin/oxfmt --check --threads=1 ...
  • git diff --check
  • .agents/skills/autoreview/scripts/autoreview --mode uncommitted --base origin/main

Blocked locally:

  • OPENCLAW_TESTBOX=1 npm exec --yes [email protected] -- pnpm check:changed could not start because blacksmith is not installed on this machine.
  • swift test --package-path apps/macos --filter ExecApprovalsStoreRefactorTests is blocked before local tests run by swiftui-math SwiftUI macro plugin resolution failures in this local toolchain.

@openclaw-barnacle openclaw-barnacle Bot added docs Improvements or additions to documentation app: macos App: macos gateway Gateway runtime cli CLI command changes commands Command implementations agents Agent runtime and tooling size: L maintainer Maintainer-authored PR labels Jun 11, 2026
@vincentkoc
vincentkoc marked this pull request as ready for review June 11, 2026 00:19
@vincentkoc
vincentkoc requested a review from a team as a code owner June 11, 2026 00:19
@vincentkoc
vincentkoc force-pushed the fix/exec-approvals-state-dir branch from f4218c7 to 7e5396e Compare June 11, 2026 00:27
@clawsweeper

clawsweeper Bot commented Jun 11, 2026

Copy link
Copy Markdown
Contributor

ClawSweeper status: review started.

I am starting a fresh review of this pull request: fix(exec): honor state dir approvals This is item 1/1 in the current shard. Shard 0/1.

This placeholder means the worker is alive and reading the current context. I will edit this same comment with the actual review when the claws are done clicking.

Crustacean status: shell secured, claws on keyboard, evidence pebbles being sorted.

@vincentkoc
vincentkoc merged commit adad27d into main Jun 11, 2026
48 of 50 checks passed
@vincentkoc
vincentkoc deleted the fix/exec-approvals-state-dir branch June 11, 2026 00:30
github-actions Bot pushed a commit to Desicool/openclaw that referenced this pull request Jun 11, 2026
badgerbees pushed a commit to badgerbees/openclaw that referenced this pull request Jul 8, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

agents Agent runtime and tooling app: macos App: macos cli CLI command changes commands Command implementations docs Improvements or additions to documentation gateway Gateway runtime maintainer Maintainer-authored PR size: XL

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant