fix(test): type overflow resolver mock#91098
Conversation
|
Codex review: needs maintainer review before merge. Reviewed June 7, 2026, 2:36 AM ET / 06:36 UTC. Summary PR surface: Source +14. Total +14 across 1 file. Reproducibility: yes. source-reproducible: current main infers the resolver mock return type without Review metrics: none identified. Merge readiness Overall follows the weaker of proof and patch quality, so missing proof can cap an otherwise strong patch. Rank-up moves:
Risk before merge
Maintainer options:
Next step before merge
Security Review detailsBest possible solution: Land the narrow harness typing fix after required checks/review, keeping the mock partial instead of forcing production-shaped model, auth, and registry objects into focused tests. Do we have a high-confidence way to reproduce the issue? Yes, source-reproducible: current main infers the resolver mock return type without Is this the best way to solve the issue? Yes, this is the narrowest maintainable fix for the test-harness type failure; a full production resolver return type would make focused tests construct irrelevant model, auth, and registry fields. AGENTS.md: found and applied where relevant. Codex review notes: model gpt-5.5, reasoning high; reviewed against cd9c643dc6ef. Label changesLabel changes:
Label justifications:
Evidence reviewedPR surface: Source +14. Total +14 across 1 file. View PR surface stats
What I checked:
Likely related people:
What the crustacean ranks mean
Shiny media proof means a screenshot, video, or linked artifact directly shows the changed behavior. Runtime, network, CSP, and security claims still need visible diagnostics. How this review workflow works
|
Summary
check-test-typesfailure onmainby typing the shared overflow compactionmockedResolveModelAsynctest double with the partial resolved-model shape the harness actually uses.authStorageandmodelRegistrytest doubles while allowing model overrides to includereasoning.Verification
node scripts/run-tsgo.mjs -p test/tsconfig/tsconfig.core.test.json --incremental --tsBuildInfoFile .artifacts/tsgo-cache/core-test.tsbuildinfonode scripts/run-vitest.mjs src/agents/embedded-agent-runner/run.overflow-compaction.loop.test.ts.agents/skills/autoreview/scripts/autoreview --mode localNotes
The CI failure is unrelated to PRs #90780 and #90782. Both were failing the same
check-test-typeserror fromsrc/agents/embedded-agent-runner/run.overflow-compaction.loop.test.ts; currentorigin/mainstill had the stale mock type at the time this branch was created.