fix(voice-call): preserve live Twilio streams in stale reaper#90812
Conversation
|
Codex review: passed. Reviewed June 14, 2026, 3:57 AM ET / 07:57 UTC. Summary PR surface: Source +90, Tests +223. Total +313 across 9 files. Reproducibility: yes. source-level: current main and v2026.6.6 still reap aged non-terminal calls solely because Review metrics: none identified. Merge readiness Overall follows the weaker of proof and patch quality, so missing proof can cap an otherwise strong patch. Rank-up moves:
Risk before merge
Maintainer options:
Next step before merge
Security Review detailsBest possible solution: Land the replacement after exact-head mergeability and checks refresh, preserving stale cleanup for non-live calls while enforcing max duration for live and restored calls. Do we have a high-confidence way to reproduce the issue? Yes, source-level: current main and v2026.6.6 still reap aged non-terminal calls solely because Is this the best way to solve the issue? Yes. The PR fixes the owner plugin path directly and is better than disabling the reaper or adding another config knob because it preserves stuck-call cleanup while backfilling max-duration enforcement for live calls. AGENTS.md: found and applied where relevant. Codex review notes: model internal, reasoning high; reviewed against e99ab385cfe1. Label changesLabel changes:
Label justifications:
Evidence reviewedPR surface: Source +90, Tests +223. Total +313 across 9 files. View PR surface stats
What I checked:
Likely related people:
What the crustacean ranks mean
Shiny media proof means a screenshot, video, or linked artifact directly shows the changed behavior. Runtime, network, CSP, and security claims still need visible diagnostics. How this review workflow works
|
|
🦞✅ Source: What merged:
Automerge notes:
The automerge loop is complete. Automerge progress:
|
|
🦞👀 Command router queued. I will update this comment with the next step. |
060f3de to
02bd1b8
Compare
Co-authored-by: Sahibzada <[email protected]> Co-authored-by: clawsweeper[bot] <274271284+clawsweeper[bot]@users.noreply.github.com>
…0 (1) Co-authored-by: Sahibzada <[email protected]> Co-authored-by: clawsweeper[bot] <274271284+clawsweeper[bot]@users.noreply.github.com>
Co-authored-by: Sahibzada <[email protected]> Co-authored-by: clawsweeper[bot] <274271284+clawsweeper[bot]@users.noreply.github.com>
bd4861d to
5fee2ff
Compare
|
🦞✅ Source: Why human review is needed: What the maintainer can do as a next step: I added |
|
@Takhoffman hi you approved my high priority PR with a P1 label earlier which made the clawsweeper then open this PR; but it's now asking for human review. Since you previously approved my pr which was basically the same as this could you approve this again? Thank you. |
|
@Takhoffman please could you review once again and check my comment above |
…aw#90812) Summary: - The PR updates the voice-call plugin to preserve live `speaking`/`listening` calls without `answeredAt`, backfill max-duration enforcement for live/restored call paths, and add regression tests. - PR surface: Source +90, Tests +223. Total +313 across 9 files. - Reproducibility: yes. source-level: current main and v2026.6.6 still reap aged non-terminal calls solely bec ... king` or `listening` without setting it. I did not run a live Twilio carrier call in this read-only review. Automerge notes: - Ran the ClawSweeper repair loop before final review. - Included post-review commit in the final squash: fix(voice-call): preserve live Twilio streams in stale reaper - Included post-review commit in the final squash: fix(clawsweeper): address review for automerge-openclaw-openclaw-9062… Validation: - ClawSweeper review passed for head 5fee2ff. - Required merge gates passed before the squash merge. Prepared head SHA: 5fee2ff Review: openclaw#90812 (comment) Co-authored-by: Sahibzada Allahyar <[email protected]> Co-authored-by: clawsweeper <274271284+clawsweeper[bot]@users.noreply.github.com> Co-authored-by: clawsweeper[bot] <274271284+clawsweeper[bot]@users.noreply.github.com> Approved-by: takhoffman Co-authored-by: takhoffman <[email protected]>
…aw#90812) Summary: - The PR updates the voice-call plugin to preserve live `speaking`/`listening` calls without `answeredAt`, backfill max-duration enforcement for live/restored call paths, and add regression tests. - PR surface: Source +90, Tests +223. Total +313 across 9 files. - Reproducibility: yes. source-level: current main and v2026.6.6 still reap aged non-terminal calls solely bec ... king` or `listening` without setting it. I did not run a live Twilio carrier call in this read-only review. Automerge notes: - Ran the ClawSweeper repair loop before final review. - Included post-review commit in the final squash: fix(voice-call): preserve live Twilio streams in stale reaper - Included post-review commit in the final squash: fix(clawsweeper): address review for automerge-openclaw-openclaw-9062… Validation: - ClawSweeper review passed for head 5fee2ff. - Required merge gates passed before the squash merge. Prepared head SHA: 5fee2ff Review: openclaw#90812 (comment) Co-authored-by: Sahibzada Allahyar <[email protected]> Co-authored-by: clawsweeper <274271284+clawsweeper[bot]@users.noreply.github.com> Co-authored-by: clawsweeper[bot] <274271284+clawsweeper[bot]@users.noreply.github.com> Approved-by: takhoffman Co-authored-by: takhoffman <[email protected]>
…aw#90812) Summary: - The PR updates the voice-call plugin to preserve live `speaking`/`listening` calls without `answeredAt`, backfill max-duration enforcement for live/restored call paths, and add regression tests. - PR surface: Source +90, Tests +223. Total +313 across 9 files. - Reproducibility: yes. source-level: current main and v2026.6.6 still reap aged non-terminal calls solely bec ... king` or `listening` without setting it. I did not run a live Twilio carrier call in this read-only review. Automerge notes: - Ran the ClawSweeper repair loop before final review. - Included post-review commit in the final squash: fix(voice-call): preserve live Twilio streams in stale reaper - Included post-review commit in the final squash: fix(clawsweeper): address review for automerge-openclaw-openclaw-9062… Validation: - ClawSweeper review passed for head 5fee2ff. - Required merge gates passed before the squash merge. Prepared head SHA: 5fee2ff Review: openclaw#90812 (comment) Co-authored-by: Sahibzada Allahyar <[email protected]> Co-authored-by: clawsweeper <274271284+clawsweeper[bot]@users.noreply.github.com> Co-authored-by: clawsweeper[bot] <274271284+clawsweeper[bot]@users.noreply.github.com> Approved-by: takhoffman Co-authored-by: takhoffman <[email protected]>
…aw#90812) Summary: - The PR updates the voice-call plugin to preserve live `speaking`/`listening` calls without `answeredAt`, backfill max-duration enforcement for live/restored call paths, and add regression tests. - PR surface: Source +90, Tests +223. Total +313 across 9 files. - Reproducibility: yes. source-level: current main and v2026.6.6 still reap aged non-terminal calls solely bec ... king` or `listening` without setting it. I did not run a live Twilio carrier call in this read-only review. Automerge notes: - Ran the ClawSweeper repair loop before final review. - Included post-review commit in the final squash: fix(voice-call): preserve live Twilio streams in stale reaper - Included post-review commit in the final squash: fix(clawsweeper): address review for automerge-openclaw-openclaw-9062… Validation: - ClawSweeper review passed for head 5fee2ff. - Required merge gates passed before the squash merge. Prepared head SHA: 5fee2ff Review: openclaw#90812 (comment) Co-authored-by: Sahibzada Allahyar <[email protected]> Co-authored-by: clawsweeper <274271284+clawsweeper[bot]@users.noreply.github.com> Co-authored-by: clawsweeper[bot] <274271284+clawsweeper[bot]@users.noreply.github.com> Approved-by: takhoffman Co-authored-by: takhoffman <[email protected]>
Makes #90620 merge-ready for the ClawSweeper automerge loop.
The edit pass should inspect the live PR diff, review comments, and failing checks; rebase if needed; keep the contributor branch credited; and stop only when validation is green or an external blocker is proven.
ClawSweeper 🐠 replacement reef notes:
Inherited issue-closing references from the source PR:
Fixes #79121
Co-author credit kept:
fish notes: model gpt-5.5, reasoning high; reviewed against 060f3de.