fix(message): stage buffer-only send attachments#90808
Conversation
|
Codex review: needs real behavior proof before merge. Reviewed June 5, 2026, 10:21 PM ET / 02:21 UTC. Summary PR surface: Source +56, Tests +34. Total +90 across 2 files. Reproducibility: yes. by source inspection: current main exposes buffer input in the message tool schema, but normal Review metrics: none identified. Merge readiness Overall follows the weaker of proof and patch quality, so missing proof can cap an otherwise strong patch. Rank-up moves:
Proof guidance:
Risk before merge
Maintainer options:
Next step before merge
Security Review findings
Review detailsBest possible solution: Land one canonical fix that stages buffer-only sends through the shared outbound media store with existing byte caps and dry-run-safe behavior, then require redacted real runtime or channel proof before merging whichever PR maintainers choose. Do we have a high-confidence way to reproduce the issue? Yes by source inspection: current main exposes buffer input in the message tool schema, but normal Is this the best way to solve the issue? No as submitted. Buffer-to-media staging is the right boundary, but this implementation needs valid media-core imports, shared media-store byte limits, dry-run-safe behavior, and real runtime/channel proof. Full review comments:
Overall correctness: patch is incorrect AGENTS.md: found and applied where relevant. Codex review notes: model gpt-5.5, reasoning high; reviewed against b1e4b6b65e2c. Label changesLabel changes:
Label justifications:
Evidence reviewedPR surface: Source +56, Tests +34. Total +90 across 2 files. View PR surface stats
Security concerns:
What I checked:
Likely related people:
What the crustacean ranks mean
Shiny media proof means a screenshot, video, or linked artifact directly shows the changed behavior. Runtime, network, CSP, and security claims still need visible diagnostics. How this review workflow works
|
|
Superseded by the canonical fix now on The landed version fixes #90768 across local sends, gateway Proof: focused Vitest bundle, clean autoreview, and Testbox-through-Crabbox Thanks @arkyu2077. Closing this PR as superseded by the landed main fix. |
Summary
message.sendattachments into a temp media file before deliveryCloses #90768