refactor: add SQLite embedded run target adapter#90438
Conversation
|
Codex review: needs real behavior proof before merge. Reviewed June 24, 2026, 7:28 PM ET / 23:28 UTC. Summary PR surface: Source +2956, Tests +2164, Generated +220. Total +5340 across 44 files. Reproducibility: yes. Source inspection of PR head shows the explicit compaction file target being dropped when a session key exists, SQLite reads using a schema-creating opener, and session cleanup deleting rows before an enforced export receipt. Review metrics: 2 noteworthy metrics.
Stored data model Root-cause cluster Members:
Proposal only: this assessment does not dispatch repair, suppress jobs, mutate sibling items, close, or merge anything. Merge readiness Overall follows the weaker of proof and patch quality, so missing proof can cap an otherwise strong patch. Rank-up moves:
Proof guidance:
Risk before merge
Maintainer options:
Next step before merge
Security Review findings
Review detailsBest possible solution: Keep the PR open under the tracker, rebase it onto the current stack, fix the storage-safety blockers, and add redacted real SQLite run-target proof before any merge decision. Do we have a high-confidence way to reproduce the issue? Yes. Source inspection of PR head shows the explicit compaction file target being dropped when a session key exists, SQLite reads using a schema-creating opener, and session cleanup deleting rows before an enforced export receipt. Is this the best way to solve the issue? No. The SQLite adapter seam is the intended owner boundary, but the current draft is not the best mergeable shape until it preserves current target behavior, adds no-create read paths, guards transcript deletion, rebases, and provides real proof. Full review comments:
Overall correctness: patch is incorrect AGENTS.md: found and applied where relevant. Codex review notes: model internal, reasoning high; reviewed against 3ab8d6aa609a. Label changesLabel justifications:
Evidence reviewedPR surface: Source +2956, Tests +2164, Generated +220. Total +5340 across 44 files. View PR surface stats
Security concerns:
What I checked:
Likely related people:
What the crustacean ranks mean
Shiny media proof means a screenshot, video, or linked artifact directly shows the changed behavior. Runtime, network, CSP, and security claims still need visible diagnostics. How this review workflow works
|
1ccad0c to
07e48cf
Compare
07e48cf to
ba3d281
Compare
543fb5c to
ffd2ae9
Compare
What
Implements the SQLite adapter side of the embedded-agent run/session target seam. The adapter resolves storage-neutral run/session targets through SQLite-backed session access while retaining the named active artifact boundary needed by current embedded-run internals.
Why
This is the 3.2 counterpart to the file-backed embedded run/session target seam. It proves the target contract can operate under SQLite wiring before the production storage flip.
Changes
Testing
node scripts/run-vitest.mjs src/agents/run-session-target.test.ts src/context-engine/context-engine.test.ts src/commitments/runtime.test.ts src/crestodian/assistant.test.ts src/hooks/llm-slug-generator.test.ts src/talk/agent-consult-runtime.test.ts src/agents/cli-runner/prepare.test.ts src/agents/cli-runner.before-agent-reply-cron.test.ts src/agents/embedded-agent-runner/run.overflow-compaction.test.tsnode scripts/run-vitest.mjs src/config/sessions/session-accessor.conformance.test.ts src/config/sessions/session-accessor.test.ts src/state/openclaw-agent-db.test.ts src/plugin-sdk/session-transcript-hit.test.ts.agents/skills/autoreview/scripts/autoreview --mode branch --base clawdbot-587/32-sqlite-store-foundation --no-web-search --thinking codex=lowRefs #88838