revert(codex): revert first-party marketplace allowlist#89998
Conversation
|
Codex review: needs real behavior proof before merge. Reviewed June 3, 2026, 5:20 PM ET / 21:20 UTC. Summary PR surface: Source -99, Tests -204, Docs -67. Total -370 across 22 files. Reproducibility: yes. Source inspection of the PR head shows non-curated Codex marketplaces are filtered out and SMS runtime fields are omitted; I did not run live behavior because this was a read-only review. Review metrics: 2 noteworthy metrics.
Merge readiness Overall follows the weaker of proof and patch quality, so missing proof can cap an otherwise strong patch. Rank-up moves:
Proof guidance:
Risk before merge
Maintainer options:
Next step before merge
Security Review findings
Review detailsBest possible solution: Keep current-main first-party Codex marketplace support and SMS runtime status projection unless maintainers approve a targeted rollback with migration/docs/proof for the user-visible fallout. Do we have a high-confidence way to reproduce the issue? Yes. Source inspection of the PR head shows non-curated Codex marketplaces are filtered out and SMS runtime fields are omitted; I did not run live behavior because this was a read-only review. Is this the best way to solve the issue? No. A broad revert is not the best fix because current main matches upstream Codex marketplace names and preserves SMS health state; any real concern should be handled by a targeted rollback or policy change with upgrade proof. Full review comments:
Overall correctness: patch is incorrect AGENTS.md: found and applied where relevant. Codex review notes: model gpt-5.5, reasoning high; reviewed against 7b82901e58d3. Label changesLabel justifications:
Evidence reviewedPR surface: Source -99, Tests -204, Docs -67. Total -370 across 22 files. View PR surface stats
What I checked:
Likely related people:
What the crustacean ranks mean
Shiny media proof means a screenshot, video, or linked artifact directly shows the changed behavior. Runtime, network, CSP, and security claims still need visible diagnostics. How this review workflow works
|
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: d8ce81ab18
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| buildAccountSnapshot: ({ account }) => { | ||
| const configured = isSmsAccountConfigured(account); | ||
| return { | ||
| accountId: account.accountId, | ||
| name: account.fromNumber || account.messagingServiceSid || "SMS", | ||
| enabled: account.enabled, | ||
| configured, | ||
| statusState: !account.enabled ? "disabled" : configured ? "configured" : "unconfigured", | ||
| }; |
There was a problem hiding this comment.
Preserve SMS runtime fields in status snapshots
When an SMS account is configured and running, channels.status passes the live runtime snapshot into this hook, but the new implementation only reads account and returns no running, lastError, lastInboundAt, or lastOutboundAt fields. The gateway then evaluates that snapshot as not running (evaluateChannelHealth treats missing running as false), so SMS appears unhealthy/stopped even while the channel task is active; the removed helper immediately above this diff preserved those runtime fields.
Useful? React with 👍 / 👎.
This reverts commit 4f3d8a5.
d8ce81a to
3595795
Compare
|
Landing per maintainer request with the current runner-failure checks ignored. Summary:
Verification:
|
Summary
openai-curated-only marketplace behavior.Codex contract checked locally:
../codex/codex-rs/core-plugins/src/lib.rsdefinesopenai-curatedandopenai-bundled;../codex/codex-rs/cli/src/plugin_cmd.rsnamesopenai-primary-runtime;../codex/codex-rs/core-plugins/src/discoverable.rslists bundled discoverable plugins.Verification
git diff --check origin/mainnode scripts/run-vitest.mjs extensions/codex/src/app-server/config.test.ts extensions/codex/src/app-server/plugin-activation.test.ts extensions/codex/src/app-server/session-binding.test.ts extensions/codex/src/migration/provider.test.ts extensions/sms/src/channel.test.ts extensions/sms/src/inbound.test.ts extensions/sms/src/twilio.test.ts src/config/sessions.cache.test.ts src/gateway/server.agent.gateway-server-agent-b.test.ts src/agents/tools/skill-workshop-tool.test.ts test/scripts/lint-suppressions.test.tsnpx oxfmt --check extensions/codex/src/app-server/config.test.ts extensions/codex/src/app-server/config.ts extensions/codex/src/app-server/plugin-activation.test.ts extensions/codex/src/app-server/plugin-activation.ts extensions/codex/src/app-server/plugin-inventory.ts extensions/codex/src/app-server/session-binding.test.ts extensions/codex/src/app-server/session-binding.ts extensions/codex/src/migration/apply.ts extensions/codex/src/migration/provider.test.ts extensions/sms/src/channel.test.ts extensions/sms/src/channel.ts extensions/sms/src/inbound.test.ts extensions/sms/src/twilio.test.ts src/agents/tools/skill-workshop-tool.ts src/config/sessions.cache.test.ts src/gateway/server.agent.gateway-server-agent-b.test.ts