test(msteams): add comprehensive tests for graph-upload module by RajdeepKushwaha5 · Pull Request #8964 · openclaw/openclaw

RajdeepKushwaha5 · 2026-02-04T17:24:04Z

Summary

Adds unit tests for the MS Teams graph-upload module which previously had no test coverage.

Changes

Add 23 new tests covering all exported functions in graph-upload.ts
Tests cover success cases, error handling, and edge cases
Uses mock fetch pattern consistent with other msteams tests

Testing

All tests pass locally (npx vitest run extensions/msteams/src/graph-upload.test.ts)
No TypeScript errors

Checklist

Tests focused on one module
Follows existing testing patterns
AI-assisted (Claude Opus 4.5 with Copilot)

Greptile Overview

Greptile Summary

This PR adds a new Vitest test suite for the MS Teams graph-upload module, covering OneDrive/SharePoint upload helpers, sharing-link creation, drive-item property lookups, and chat member retrieval via injected fetchFn and a mocked access token provider.

The approach mirrors the module’s dependency-injection pattern (passing fetchFn + token provider) and exercises both success and error paths for the exported functions in extensions/msteams/src/graph-upload.ts.

Confidence Score: 3/5

This PR is low-risk functionally, but several test assertions appear to be incorrect and may fail in CI.
Only a new test file is added, but multiple expectations don’t match the actual error strings thrown by the implementation (notably where response bodies are appended). I couldn’t execute tests in this environment (node/pnpm unavailable), so confidence relies on static verification against the source.
extensions/msteams/src/graph-upload.test.ts

_{(2/5) Greptile learns from your feedback when you react with thumbs up/down!}

greptile-apps

_{1 file reviewed, 3 comments}

_{Edit Code Review Agent Settings | Greptile}

greptile-apps · 2026-02-04T17:25:22Z

extensions/msteams/src/graph-upload.test.ts

+      await expect(
+        uploadToSharePoint({
+          buffer: Buffer.from("test"),
+          filename: "test.txt",
+          tokenProvider,
+          siteId: "site-123",
+          fetchFn: mockFetch,
+        }),
+      ).rejects.toThrow("SharePoint upload failed: 500 Internal Server Error");


Incorrect error expectation

uploadToSharePoint includes the response body in its error message (... - ${body}), but this test asserts the message without the trailing - SharePoint is unavailable. With the current implementation in extensions/msteams/src/graph-upload.ts:197-200, this assertion should fail.

Suggested change

await expect(

uploadToSharePoint({

buffer: Buffer.from("test"),

filename: "test.txt",

tokenProvider,

siteId: "site-123",

fetchFn: mockFetch,

}),

).rejects.toThrow("SharePoint upload failed: 500 Internal Server Error");

).rejects.toThrow("SharePoint upload failed: 500 Internal Server Error - SharePoint is unavailable");

Prompt To Fix With AI

This is a comment left during a code review. Path: extensions/msteams/src/graph-upload.test.ts Line: 336:344 Comment: **Incorrect error expectation** `uploadToSharePoint` includes the response body in its error message (`... - ${body}`), but this test asserts the message without the trailing ` - SharePoint is unavailable`. With the current implementation in `extensions/msteams/src/graph-upload.ts:197-200`, this assertion should fail. ```suggestion ).rejects.toThrow("SharePoint upload failed: 500 Internal Server Error - SharePoint is unavailable"); ``` How can I resolve this? If you propose a fix, please make it concise.

greptile-apps · 2026-02-04T17:25:23Z

extensions/msteams/src/graph-upload.test.ts

+      await expect(
+        getDriveItemProperties({
+          siteId: "site-id",
+          itemId: "item-id",
+          tokenProvider,
+          fetchFn: mockFetch,
+        }),
+      ).rejects.toThrow("DriveItem response missing required properties");


Mismatched error message

getDriveItemProperties throws "DriveItem response missing required properties (eTag, webDavUrl, or name)" when required fields are absent (extensions/msteams/src/graph-upload.ts:269-271), but this test expects "DriveItem response missing required properties". As written, the assertion won’t match the actual thrown error.

Suggested change

await expect(

getDriveItemProperties({

siteId: "site-id",

itemId: "item-id",

tokenProvider,

fetchFn: mockFetch,

}),

).rejects.toThrow("DriveItem response missing required properties");

).rejects.toThrow(

"DriveItem response missing required properties (eTag, webDavUrl, or name)",

);

Prompt To Fix With AI

This is a comment left during a code review. Path: extensions/msteams/src/graph-upload.test.ts Line: 385:392 Comment: **Mismatched error message** `getDriveItemProperties` throws `"DriveItem response missing required properties (eTag, webDavUrl, or name)"` when required fields are absent (`extensions/msteams/src/graph-upload.ts:269-271`), but this test expects `"DriveItem response missing required properties"`. As written, the assertion won’t match the actual thrown error. ```suggestion ).rejects.toThrow( "DriveItem response missing required properties (eTag, webDavUrl, or name)", ); ``` How can I resolve this? If you propose a fix, please make it concise.

greptile-apps · 2026-02-04T17:25:24Z

extensions/msteams/src/graph-upload.test.ts

+      await expect(
+        getChatMembers({
+          chatId: "chat-123",
+          tokenProvider,
+          fetchFn: mockFetch,
+        }),
+      ).rejects.toThrow("Get chat members failed: 403 Forbidden");
+    });


Missing response body in assertion

getChatMembers includes the response body in its thrown error (... - ${body} at extensions/msteams/src/graph-upload.ts:296-299), but this test expects only "Get chat members failed: 403 Forbidden". With text() mocked to return "Missing Chat.Read.All permission", the error message should include that suffix.

Suggested change

await expect(

getChatMembers({

chatId: "chat-123",

tokenProvider,

fetchFn: mockFetch,

}),

).rejects.toThrow("Get chat members failed: 403 Forbidden");

});

).rejects.toThrow(

"Get chat members failed: 403 Forbidden - Missing Chat.Read.All permission",

);

Prompt To Fix With AI

This is a comment left during a code review. Path: extensions/msteams/src/graph-upload.test.ts Line: 451:458 Comment: **Missing response body in assertion** `getChatMembers` includes the response body in its thrown error (`... - ${body}` at `extensions/msteams/src/graph-upload.ts:296-299`), but this test expects only `"Get chat members failed: 403 Forbidden"`. With `text()` mocked to return `"Missing Chat.Read.All permission"`, the error message should include that suffix. ```suggestion ).rejects.toThrow( "Get chat members failed: 403 Forbidden - Missing Chat.Read.All permission", ); ``` How can I resolve this? If you propose a fix, please make it concise.

Copilot

Pull request overview

Adds unit test coverage for the MS Teams graph-upload module to validate Graph upload/sharing behaviors and error handling via mocked token provider + fetch.

Changes:

Introduces graph-upload.test.ts with 23 Vitest cases spanning all exported functions in graph-upload.ts
Covers key success paths plus several validation/error scenarios (upload failures, missing response fields, per-user vs org sharing)
Uses injected fetchFn/token provider mocks to avoid network calls

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copilot · 2026-02-04T17:30:48Z

extensions/msteams/src/graph-upload.test.ts

+  describe("uploadToSharePoint", () => {
+    it("uploads a file to SharePoint site", async () => {
+      const tokenProvider = createMockTokenProvider();
+      const mockFetch = createMockFetch({
+        ok: true,


The uploadToSharePoint implementation also validates that the successful JSON response includes id, webUrl, and name and throws SharePoint upload response missing required fields if any are missing (see graph-upload.ts). There isn't a unit test in this block covering that missing-fields error path; adding one (similar to the OneDrive missing-fields test) would improve coverage.

Copilot · 2026-02-04T17:30:49Z

extensions/msteams/src/graph-upload.test.ts

+  describe("getDriveItemProperties", () => {
+    it("fetches driveItem properties for file card attachments", async () => {
+      const tokenProvider = createMockTokenProvider();
+      const mockFetch = createMockFetch({
+        ok: true,


getDriveItemProperties has a !res.ok failure branch that throws Get driveItem properties failed: <status> <statusText> - <body> (see graph-upload.ts). The tests here cover success + missing properties but not the non-2xx response path; consider adding a test for a 4xx/5xx response to exercise that error handling.

Copilot · 2026-02-04T17:30:49Z

extensions/msteams/src/graph-upload.test.ts

+  describe("createSharePointSharingLink", () => {
+    it("creates organization-scoped link using v1.0 API by default", async () => {
+      const tokenProvider = createMockTokenProvider();
+      const mockFetch = createMockFetch({
+        ok: true,


createSharePointSharingLink throws Create SharePoint sharing link response missing webUrl when the response JSON lacks link.webUrl (see graph-upload.ts). There isn't a test case in this section covering that validation error yet; adding one would complete coverage of this function’s main error branches (analogous to the OneDrive createSharingLink missing-webUrl test).

Addresses openclaw#8947. The '(default)' label was confusing because it didn't clearly indicate that this agent handles incoming channel messages. Changed to '(channel default)' for clarity in both 'agents list' and 'openclaw status' output.

…sions When listing sessions in status/sessions commands, prefer the current model catalog's contextTokens over the stale cached value in sessions.json. Fixes openclaw#8937

RajdeepKushwaha5 · 2026-02-04T22:43:58Z

Summary

Fixes #8937

When listing sessions in status/sessions commands, prefer the current model catalog's contextTokens over the stale cached value in sessions.json.

Problem

The contextTokens value from the model catalog was cached in sessions.json when a session was created. If the catalog later updated with a corrected value (e.g., after a pi-ai update or OpenClaw upgrade), the stale cached value persisted indefinitely.

Solution

When displaying session info, use lookupContextTokens(model) to get the fresh catalog value, falling back to the cached entry?.contextTokens only if the catalog doesn't have the info.

Files Changed

src/gateway/session-utils.ts - Gateway's session listing for status/TUI
src/commands/sessions.ts - CLI sessions command

Testing

All 29 existing tests pass
Formatting and linting pass

openclaw-barnacle · 2026-02-21T04:41:08Z

This pull request has been automatically marked as stale due to inactivity.
Please add updates or it will be closed.

openclaw-barnacle · 2026-03-07T04:13:17Z

This pull request has been automatically marked as stale due to inactivity.
Please add updates or it will be closed.

BradGroux · 2026-03-10T18:20:57Z

Hi @RajdeepKushwaha5 — thanks for the submission. I’m the new Microsoft Teams maintainer for OpenClaw. Please give me a day or two to work through the open Teams backlog. Also, join the Twitter community for daily MS Teams feedback + updates: https://x.com/i/communities/2031170403607974228

BradGroux · 2026-03-10T18:23:28Z

Hi @RajdeepKushwaha5 — thanks for the submission. I’m the new Microsoft Teams maintainer for OpenClaw. Please give me a day or two to work through the open Teams backlog. Also, join the Twitter community for daily MS Teams feedback + updates: https://x.com/i/communities/2031170403607974228

vincentkoc · 2026-03-20T19:24:41Z

Thanks. The idea may still be valid, but this PR no longer maps cleanly to current main during the refactor. If the regression still reproduces on latest main, please open a fresh PR with current failing evidence.

Copilot AI review requested due to automatic review settings February 4, 2026 17:24

openclaw-barnacle bot added the channel: msteams Channel integration: msteams label Feb 4, 2026

Copilot started reviewing on behalf of RajdeepKushwaha5 February 4, 2026 17:24 View session

greptile-apps bot reviewed Feb 4, 2026

View reviewed changes

Copilot AI reviewed Feb 4, 2026

View reviewed changes

test(msteams): add comprehensive tests for graph-upload module

3beed57

RajdeepKushwaha5 force-pushed the main branch from 7abaaed to 3beed57 Compare February 4, 2026 17:32

openclaw-barnacle bot added the commands Command implementations label Feb 4, 2026

RajdeepKushwaha5 and others added 2 commits February 5, 2026 04:01

Merge branch 'openclaw:main' into main

3fca7fb

fix(sessions): refresh contextTokens from catalog when displaying ses…

f4099ba

…sions When listing sessions in status/sessions commands, prefer the current model catalog's contextTokens over the stale cached value in sessions.json. Fixes openclaw#8937

openclaw-barnacle bot added the gateway Gateway runtime label Feb 4, 2026

Merge branch 'openclaw:main' into main

1af5030

thewilloftheshadow force-pushed the main branch from bfc1ccb to f92900f Compare February 15, 2026 18:46

openclaw-barnacle bot added stale Marked as stale due to inactivity and removed stale Marked as stale due to inactivity labels Feb 21, 2026

This comment was marked as spam.

Sign in to view

openclaw-barnacle bot added the stale Marked as stale due to inactivity label Mar 7, 2026

BradGroux self-assigned this Mar 10, 2026

BradGroux mentioned this pull request Mar 17, 2026

WORKING: All Microsoft Issues and PRs #49126

Draft

vincentkoc closed this Mar 20, 2026

Uh oh!

Conversation

RajdeepKushwaha5 commented Feb 4, 2026 • edited by greptile-apps bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

Changes

Testing

Checklist

Greptile Overview

Greptile Summary

Confidence Score: 3/5

Uh oh!

greptile-apps bot left a comment

Choose a reason for hiding this comment

Uh oh!

greptile-apps bot Feb 4, 2026

Choose a reason for hiding this comment

Uh oh!

greptile-apps bot Feb 4, 2026

Choose a reason for hiding this comment

Uh oh!

greptile-apps bot Feb 4, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Copilot AI Feb 4, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Feb 4, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Feb 4, 2026

Choose a reason for hiding this comment

Uh oh!

RajdeepKushwaha5 commented Feb 4, 2026

Summary

Problem

Solution

Files Changed

Testing

Uh oh!

openclaw-barnacle bot commented Feb 21, 2026

Uh oh!

This comment was marked as spam.

openclaw-barnacle bot commented Mar 7, 2026

Uh oh!

BradGroux commented Mar 10, 2026

Uh oh!

BradGroux commented Mar 10, 2026

Uh oh!

vincentkoc commented Mar 20, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

RajdeepKushwaha5 commented Feb 4, 2026 •

edited by greptile-apps bot

Loading