fix(status): show effective channel model override#89602
Conversation
|
Codex review: needs real behavior proof before merge. Reviewed June 29, 2026, 11:23 PM ET / 03:23 UTC. Summary PR surface: Source +10, Tests +31. Total +41 across 2 files. Reproducibility: yes. at source level. Configure a Review metrics: none identified. Root-cause cluster Members:
Proposal only: this assessment does not dispatch repair, suppress jobs, mutate sibling items, close, or merge anything. Merge readiness Overall follows the weaker of proof and patch quality, so missing proof can cap an otherwise strong patch. Rank-up moves:
Proof guidance:
Mantis proof suggestion Risk before merge
Maintainer options:
Next step before merge
Security Review findings
Review detailsBest possible solution: Derive one effective channel model/provider state before Do we have a high-confidence way to reproduce the issue? Yes, at source level. Configure a Is this the best way to solve the issue? No, not as currently patched. The direction is useful, but applying the override inside Full review comments:
Overall correctness: patch is incorrect AGENTS.md: found and applied where relevant. Codex review notes: model internal, reasoning high; reviewed against 54b09580f61b. Label changesLabel justifications:
Evidence reviewedPR surface: Source +10, Tests +31. Total +41 across 2 files. View PR surface stats
What I checked:
Likely related people:
What the crustacean ranks mean
Shiny media proof means a screenshot, video, or linked artifact directly shows the changed behavior. Runtime, network, CSP, and security claims still need visible diagnostics. How this review workflow works
Review history (1 earlier review cycle)
|
|
This pull request has been automatically marked as stale due to inactivity. |
Summary
channels.modelByChanneloverrides in/statuseven when they differ from the session/default modelFixes #89532
Tests
node scripts/run-vitest.mjs src/auto-reply/status.test.ts src/auto-reply/reply/commands-status.test.ts src/channels/model-overrides.test.ts