Config: preserve implicit main route bindings#89490
Conversation
|
Codex review: needs real behavior proof before merge. Reviewed June 15, 2026, 5:20 AM ET / 09:20 UTC. Summary PR surface: Source +6, Tests +52. Total +58 across 4 files. Reproducibility: yes. source-level. A non-empty Review metrics: 1 noteworthy metric.
Merge readiness Overall follows the weaker of proof and patch quality, so missing proof can cap an otherwise strong patch. Rank-up moves:
Proof guidance:
Risk before merge
Maintainer options:
Next step before merge
Security Review findings
Review detailsBest possible solution: Make exact Do we have a high-confidence way to reproduce the issue? Yes, source-level. A non-empty Is this the best way to solve the issue? No. Preserving Full review comments:
Overall correctness: patch is incorrect AGENTS.md: found and applied where relevant. Codex review notes: model internal, reasoning high; reviewed against 233b48daaab4. Label changesLabel justifications:
Evidence reviewedPR surface: Source +6, Tests +52. Total +58 across 4 files. View PR surface stats
What I checked:
Likely related people:
What the crustacean ranks mean
Shiny media proof means a screenshot, video, or linked artifact directly shows the changed behavior. Runtime, network, CSP, and security claims still need visible diagnostics. How this review workflow works
|
|
Thanks @dahifi for the focused fix and proof notes. I am closing this as superseded by #89419 (#89419) because both PRs target the same #89412 route-binding bug, and #89419 is the current canonical path with the stricter exact-main guard plus expanded schema and doctor regression coverage. Clownfish will keep credit and source PR attribution for this work from #89490 (#89490) in the canonical thread/context. If your branch has a different reproduction path or still catches behavior after the canonical fix lands, please reply and we can reopen or split it back out. |
Summary
mainas an allowed route binding target during config validation, even whenagents.listis populated.mainroute bindings during doctor compatibility pruning while continuing to prune genuinely missing agent ids.codex/claudeinagents.listand fallback bindings tomain.Fixes #89412
Test plan
node scripts/run-vitest.mjs src/config/config.schema-regressions.test.ts --runfailed on the newmainbinding validation regression.node scripts/run-vitest.mjs src/commands/doctor/shared/legacy-config-migrate.test.ts --runfailed on the new doctor preservation regression.node scripts/run-vitest.mjs src/config/config.schema-regressions.test.ts src/commands/doctor/shared/legacy-config-migrate.test.ts --runpassed: 2 Vitest shards, 137 tests.pnpm checkpassed.pnpm buildpassed.— Seraphel