refactor: add QMD session artifact identity mapping#89360
Conversation
|
Codex review: needs real behavior proof before merge. Reviewed June 22, 2026, 12:34 AM ET / 04:34 UTC. Summary PR surface: Source +425, Tests +242. Total +667 across 4 files. Reproducibility: not applicable. this is an internal staged refactor/migration PR rather than a standalone bug report. Source inspection shows the intended mapped-identity path, but this PR body and comments do not show real QMD export/search proof. Review metrics: 1 noteworthy metric.
Stored data model Merge readiness Overall follows the weaker of proof and patch quality, so missing proof can cap an otherwise strong patch. Rank-up moves:
Proof guidance:
Risk before merge
Maintainer options:
Next step before merge
Security Review detailsBest possible solution: Park this protected draft while maintainers resolve or review #95087 as the combined replacement, or explicitly revive this smaller slice with real QMD mapped-identity proof. Do we have a high-confidence way to reproduce the issue? Not applicable: this is an internal staged refactor/migration PR rather than a standalone bug report. Source inspection shows the intended mapped-identity path, but this PR body and comments do not show real QMD export/search proof. Is this the best way to solve the issue? Unclear for this PR as the landing path: the QMD mapping shape is plausible, but the author now points to #95087 as the combined replacement. The best solution depends on maintainer stack direction and a clean replacement branch or fresh proof for this smaller slice. AGENTS.md: found and applied where relevant. Codex review notes: model internal, reasoning high; reviewed against a594d2ce7325. Label changesLabel justifications:
Evidence reviewedPR surface: Source +425, Tests +242. Total +667 across 4 files. View PR surface stats
What I checked:
Likely related people:
What the crustacean ranks mean
Shiny media proof means a screenshot, video, or linked artifact directly shows the changed behavior. Runtime, network, CSP, and security claims still need visible diagnostics. How this review workflow works
|
|
Superseded by #95087. The replacement draft bundles this QMD artifact identity mapping slice with its memory session sync identity dependency from #89348, stacked on #95030. That keeps the QMD search-visibility behavior and identity-targeted refresh API together under one current review/proof bundle. |
What
Adds an internal QMD session artifact identity mapping so generated QMD Markdown session artifacts resolve back to stable transcript memory/session identity before deprecated filename fallback.
Why
Path 3 needs QMD search hits to stop treating generated Markdown artifact names as canonical session identity. QMD still needs Markdown files to index transcript content, but those files are search artifacts; identity should come from a storage-neutral transcript memory key/session mapping.
Refs #88838. Builds on #89348.
Changes
extensions/memory-core/src/qmd-session-artifacts.tsextensions/memory-core/src/memory/qmd-manager.tsextensions/memory-core/src/session-search-visibility.tsextensions/memory-core/src/session-search-visibility.test.tsTesting
node scripts/run-vitest.mjs extensions/memory-core/src/session-search-visibility.test.ts extensions/memory-core/src/memory/qmd-manager.slugified-paths.test.tspnpm exec oxfmt --check <touched files>node scripts/run-oxlint.mjs <touched files>pnpm tsgo:extensionspnpm tsgo:test:extensionsgit diff --checkThis uses memory-core's existing QMD SQLite index/cache only. It does not add a public
SessionCorpusEntrySDK, 3.2 session/transcript SQLite store modules, production storage flip, runtime dual-read/fallback, JSON sidecar, or doctor migration.