refactor: add public transcript identity API#89261
Conversation
|
Codex review: needs real behavior proof before merge. Reviewed June 19, 2026, 4:18 AM ET / 08:18 UTC. Summary PR surface: Source +825, Tests +579, Docs +3, Config +4, Generated 0, Other +4. Total +1415 across 20 files. Reproducibility: yes. Source inspection shows the public reader delegates to a parse-all loader, and the public identity helper delegates to a target resolver whose callee can persist session metadata; I did not run tests because this was a read-only cleanup review. Review metrics: 1 noteworthy metric.
Stored data model Root-cause cluster Members:
Proposal only: this assessment does not dispatch repair, suppress jobs, mutate sibling items, close, or merge anything. Merge readiness Overall follows the weaker of proof and patch quality, so missing proof can cap an otherwise strong patch. Rank-up moves:
Proof guidance:
Risk before merge
Maintainer options:
Next step before merge
Security Review findings
Review detailsBest possible solution: Keep the stack PR open, make public identity reads non-mutating and malformed-row tolerant, then land only after maintainer API approval, branch refresh, and redacted real plugin/runtime proof. Do we have a high-confidence way to reproduce the issue? Yes. Source inspection shows the public reader delegates to a parse-all loader, and the public identity helper delegates to a target resolver whose callee can persist session metadata; I did not run tests because this was a read-only cleanup review. Is this the best way to solve the issue? No, not as a final landing shape. The identity boundary is plausible for the SQLite migration, but the public SDK contract should use read-only identity resolution, tolerate malformed transcript rows, and have maintainer API approval plus real proof before publishing. Full review comments:
Overall correctness: patch is incorrect AGENTS.md: found and applied where relevant. Codex review notes: model internal, reasoning high; reviewed against 86b24ac2b2fc. Label changesLabel justifications:
Evidence reviewedPR surface: Source +825, Tests +579, Docs +3, Config +4, Generated 0, Other +4. Total +1415 across 20 files. View PR surface stats
What I checked:
Likely related people:
What the crustacean ranks mean
Shiny media proof means a screenshot, video, or linked artifact directly shows the changed behavior. Runtime, network, CSP, and security claims still need visible diagnostics. How this review workflow works
|
a0e06d4 to
8432a1b
Compare
cb112eb to
57aa52c
Compare
What
Adds the public SDK transcript identity API used by Path 3 session/transcript seam work. The PR introduces storage-neutral transcript identity and memory-hit key helpers so plugin and memory consumers can stop deriving transcript identity from file basenames or
sessionFilepaths.Refs #88838. Stacked on #89201.
Why
The SQLite migration needs plugin-facing transcript consumers to address transcript state by stable session identity before the storage backend can change. File-path and basename matching are not portable to SQLite, but the compatibility surface still needs an additive SDK path for existing callers.
Changes
Changes Walkthrough
src/plugin-sdk/session-transcript-runtime.tssrc/plugin-sdk/session-transcript-hit.tssrc/config/sessions/session-accessor.tssrc/config/sessions/transcript-runtime-state.tsdocs/plugins/sdk-runtime.mddocs/plugins/sdk-subpaths.mdscripts/lib/plugin-sdk-entrypoints.jsondocs/.generated/plugin-sdk-api-baseline.sha256Testing