refactor: route gateway sessions through session seam#89120
Conversation
|
Codex review: needs real behavior proof before merge. Reviewed June 4, 2026, 4:42 PM ET / 20:42 UTC. Summary PR surface: Source +35, Tests -2. Total +33 across 5 files. Reproducibility: not applicable. this is a refactor PR, not a bug report with a failing current-main reproduction path. The review evidence is source/diff inspection plus the contributor's listed focused validation. Review metrics: 1 noteworthy metric.
Merge readiness Overall follows the weaker of proof and patch quality, so missing proof can cap an otherwise strong patch. Rank-up moves:
Proof guidance:
Risk before merge
Maintainer options:
Next step before merge
Security Review detailsBest possible solution: Keep the PR open for maintainer review, settle the base accessor seam first, then require redacted real gateway runtime proof for an affected session RPC before merge. Do we have a high-confidence way to reproduce the issue? Not applicable: this is a refactor PR, not a bug report with a failing current-main reproduction path. The review evidence is source/diff inspection plus the contributor's listed focused validation. Is this the best way to solve the issue? Unclear until maintainer review of the base seam is complete. The slice is a plausible narrow step for the Path 3 migration, but it should not be treated as the best final path until #88840 is accepted or revised. AGENTS.md: found and applied where relevant. Codex review notes: model gpt-5.5, reasoning high; reviewed against d5ce1edf7e79. Label changesLabel justifications:
Evidence reviewedPR surface: Source +35, Tests -2. Total +33 across 5 files. View PR surface stats
What I checked:
Likely related people:
What the crustacean ranks mean
Shiny media proof means a screenshot, video, or linked artifact directly shows the changed behavior. Runtime, network, CSP, and security claims still need visible diagnostics. How this review workflow works
|
f18f99c to
b39023f
Compare
2dfcbbb to
9aecae2
Compare
What
Path 3 / PR 3.1b gateway entry moves gateway session entry/list read callers onto the 3.1a session accessor seam while keeping the current file-backed behavior. This covers the gateway combined-store loader, single-entry row lookup,
sessions.describe,sessions.get, and key-basedsessions.resolvecanonicalization. Tracker: #88838.Why
This branch-by-abstraction slice reduces direct gateway dependence on file-store reads before the SQLite storage flip. It keeps accessor return shapes storage-agnostic and intentionally does not add SQLite schema/store modules, runtime dual-read/fallback, or any storage flip.
Changes
listSessionEntriesTesting
clawdbot-ce2/31b-gateway-entry-seam, commits42952f53a3and2dfcbbbd99(2dfcbbbd99is the current final source commit; earliere0e03ee6b5was superseded by rebasing onto the current 3.1a base).integration/sqlite-flip-gateway-entryat63fb7f6261.pnpm exec oxfmt --check src/gateway/server-methods/sessions.ts src/gateway/sessions-resolve.ts src/gateway/sessions-resolve.test.ts src/gateway/session-utils.ts src/config/sessions/combined-store-gateway.ts src/config/sessions/session-accessor.ts src/config/sessions/session-accessor.test.tsnode scripts/run-vitest.mjs src/gateway/sessions-resolve.test.ts src/gateway/server.sessions.create.test.ts src/gateway/server.sessions.preview-resolve.test.ts src/gateway/session-utils.test.ts src/gateway/session-utils.search.test.ts src/gateway/session-utils.subagent.test.ts src/gateway/session-utils.single-row-cache.test.ts src/config/sessions/session-accessor.test.tspassed: 186 tests.node scripts/run-oxlint.mjs src/gateway/server-methods/sessions.ts src/gateway/sessions-resolve.ts src/gateway/sessions-resolve.test.ts src/gateway/session-utils.ts src/config/sessions/combined-store-gateway.ts src/config/sessions/session-accessor.ts src/config/sessions/session-accessor.test.tsgit diff --checkrg "loadSessionStore" src/gateway/server-methods/sessions.ts src/gateway/sessions-resolve.tsreturned no matches.Blockers: none. Next dependency: base branch
clawdbot-9c3/session-accessor-seam/ PR #88840.