fix: retry transient recurring cron failures#87871
Conversation
|
Codex review: needs real behavior proof before merge. Reviewed May 28, 2026, 11:49 PM ET / 03:49 UTC. Summary PR surface: Source +95, Tests +178, Docs +6, Other -3. Total +276 across 6 files. Reproducibility: yes. source-reproducible: current main applies transient retry policy only to one-shot jobs while recurring errors use normal error backoff. I did not run tests because this was a read-only review. Review metrics: 1 noteworthy metric.
Merge readiness Overall follows the weaker of proof and patch quality, so missing proof can cap an otherwise strong patch. Rank-up moves:
Proof guidance:
Risk before merge
Maintainer options:
Next step before merge
Security Review findings
Review detailsBest possible solution: Land only after removing the changelog edit, aligning schema help/type docs with the recurring retry contract, and adding redacted real behavior proof or a maintainer proof override for the cron retry path. Do we have a high-confidence way to reproduce the issue? Yes, source-reproducible: current main applies transient retry policy only to one-shot jobs while recurring errors use normal error backoff. I did not run tests because this was a read-only review. Is this the best way to solve the issue? No, not merge-ready as-is: the runtime approach is plausible, but the release-owned changelog edit, stale config help/type docs, and missing real behavior proof need resolution first. Full review comments:
Overall correctness: patch is incorrect AGENTS.md: found and applied where relevant. Codex review notes: model gpt-5.5, reasoning high; reviewed against e7fb8cabb681. Label changesLabel changes:
Label justifications:
Evidence reviewedPR surface: Source +95, Tests +178, Docs +6, Other -3. Total +276 across 6 files. View PR surface stats
What I checked:
Likely related people:
What the crustacean ranks mean
Shiny media proof means a screenshot, video, or linked artifact directly shows the changed behavior. Runtime, network, CSP, and security claims still need visible diagnostics. How this review workflow works
|
…-cron-failover # Conflicts: # src/cron/schedule-identity.ts # src/tui/gateway-chat.test.ts
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: cd0bc51953
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| ## Unreleased | ||
|
|
||
| ### Fixes | ||
|
|
||
| - Cron: retry recurring jobs after transient model rate limits before waiting for the next scheduled slot. |
There was a problem hiding this comment.
Remove normal fix from the changelog
This is a normal bug-fix commit, but the repo rules in AGENTS.md say CHANGELOG.md is release-owned and should not be edited for normal PRs or direct fixes; release notes should instead go in the PR body/squash/direct commit context. Leaving this Unreleased entry makes release generation mix hand-written and generated changelog content.
Useful? React with 👍 / 👎.
Summary
Proof