fix(agents): broaden local model lean profile#87617
Conversation
|
Codex review: found issues before merge. Reviewed June 24, 2026, 4:13 PM ET / 20:13 UTC. Summary PR surface: Source +24, Tests +55, Docs +7. Total +86 across 7 files. Reproducibility: yes. for the review findings: current source and the PR diff show the existing three-tool lean contract and the PR's broadened deny set under the same flag. No live local-model run is needed to reproduce that compatibility change. Review metrics: 2 noteworthy metrics.
Merge readiness Overall follows the weaker of proof and patch quality, so missing proof can cap an otherwise strong patch. Rank-up moves:
Risk before merge
Maintainer options:
Next step before merge
Security Review findings
Review detailsBest possible solution: Keep current basic lean behavior for existing configs, and land the broader trim only behind an explicit strict opt-in profile or after maintainer-approved upgrade-break documentation and proof. Do we have a high-confidence way to reproduce the issue? Yes for the review findings: current source and the PR diff show the existing three-tool lean contract and the PR's broadened deny set under the same flag. No live local-model run is needed to reproduce that compatibility change. Is this the best way to solve the issue? No. Broadening the existing boolean is a plausible mitigation, but the safer maintainable solution is an explicit strict opt-in profile or a clearly documented maintainer-approved compatibility break. Full review comments:
Overall correctness: patch is incorrect AGENTS.md: found and applied where relevant. Codex review notes: model internal, reasoning high; reviewed against f0f5da0e3941. Label changesLabel justifications:
Evidence reviewedPR surface: Source +24, Tests +55, Docs +7. Total +86 across 7 files. View PR surface stats
What I checked:
Likely related people:
What the crustacean ranks mean
Shiny media proof means a screenshot, video, or linked artifact directly shows the changed behavior. Runtime, network, CSP, and security claims still need visible diagnostics. How this review workflow works
|
|
ClawSweeper PR egg: ✨ hatched 🥚 common Tiny Branchling. Rarity: 🥚 common. Trait: polishes edge cases. DetailsShare on X: post this hatch
About:
|
1c0a50b to
e6fe146
Compare
e6fe146 to
5de7591
Compare
5de7591 to
7f1c188
Compare
7f1c188 to
d1ad46e
Compare
|
Verification refresh after rebase onto
Blacksmith Testbox is still unavailable on this machine because |
5aa1b3b to
8a0d598
Compare
8a0d598 to
f3ff929
Compare
04d5691 to
23e8dab
Compare
51cde35 to
52d8aca
Compare
52d8aca to
e66d7c6
Compare
|
Closing this stale branch. It broadens the meaning of existing Broader trimming should be a separate opt-in contract with live provider proof, not an in-place expansion of the shipped boolean. Thanks for the work and verification. |
Summary
localModelLeanso small/local models avoid heavyweight web, media, session orchestration, node, channel, and subagent tool families.Verification
git diff --check origin/main...HEADnode scripts/format-docs.mjs --check docs/concepts/experimental-features.md docs/gateway/local-models.md docs/providers/ollama.mdnode scripts/check-docs-mdx.mjs docs/concepts/experimental-features.md docs/gateway/local-models.md docs/providers/ollama.md./node_modules/.bin/oxfmt --check --threads=1 src/agents/local-model-lean.ts src/agents/local-model-lean.test.ts src/agents/agent-tools.model-provider-collision.test.ts src/config/schema.help.ts./node_modules/.bin/oxlint src/agents/local-model-lean.ts src/agents/local-model-lean.test.ts src/agents/agent-tools.model-provider-collision.test.ts src/config/schema.help.tsnode scripts/run-vitest.mjs src/agents/local-model-lean.test.ts src/agents/agent-tools.model-provider-collision.test.ts src/config/schema.help.quality.test.ts src/config/schema.hints.test.ts src/config/plugins-runtime-boundary.test.ts- 5 files / 55 tests passed.node scripts/run-vitest.mjs src/agents/sessions/extensions/loader.test.ts- 2 files / 4 tests passed, covering the previously failedchecks-node-agentic-agentsloader surface..agents/skills/autoreview/scripts/autoreview --mode branch --base origin/main- clean, no accepted/actionable findings.check:changed: provideraws, leasecbx_e10934f873f7, slugharbor-shrimp, runrun_3cdcf7eb920b, exit0, cleanupleaseStopped=true.Rebase note
The previous
checks-node-agentic-agentsfailure was stale-base drift around@openclaw/net-policy/ipresolution insrc/agents/sessions/extensions/loader.test.ts, not this PR's lean-profile diff. Rebased ontoorigin/main8c0aaee88237e3ac98c63df222c3762972b8a92e; the exact loader test and the AWS Crabbox changed gate now pass.Real behavior proof
Behavior addressed:
localModelLeanpreviously trimmed onlybrowser,cron, andmessage, which left many large web/media/channel/orchestration schemas visible to smaller local models.Real environment tested: AWS Crabbox Linux runner, provider
aws, leasecbx_e10934f873f7, runrun_3cdcf7eb920b, branch head23e8dabab06c6367aab951b8ceab7917fed99781, changed gate from base8c0aaee88237e3ac98c63df222c3762972b8a92e.Exact steps or command run after this patch: rebased the branch to current main, kept the diff to the 7 intended lean-profile files, checked docs/format/lint, ran the focused lean/profile/config Vitest set locally, ran the previously failing loader test locally, ran autoreview, and ran remote
pnpm check:changedthrough AWS Crabbox.Evidence after fix: Crabbox changed gate completed with exit
0; focused local Vitest reported 5 files / 55 tests passed; loader test reported 2 files / 4 tests passed; autoreview reported no accepted/actionable findings; docs formatter and MDX checks passed.Observed result after fix: lean mode keeps
read,write,edit,exec,apply_patch,process,session_status, andupdate_plan, while trimming heavyweight browser/web/media/channel/session/subagent surfaces.What was not tested: live Ollama or hosted-provider calls in this PR; this PR changes local lean tool visibility and validates the changed code/docs paths.
Related: #86599