fix(diagnostics): clear stale session activity#87550
Conversation
|
Thanks for the context here. I swept through the related work, and this is now duplicate or superseded. Close: this replacement PR is now superseded by the newer, mergeable, proof-positive fix at #90750, while this branch is conflicting and based on an older cleanup shape. Canonical path: Close this conflicting replacement PR and continue the fix review on #90750. So I’m closing this here and keeping the remaining discussion on #90750. Review detailsBest possible solution: Close this conflicting replacement PR and continue the fix review on #90750. Do we have a high-confidence way to reproduce the issue? Yes. Source inspection shows current main leaves tool/model markers untouched when the reply-run wrapper ends with clearRunActivity: false, and the newer canonical PR supplies before/after runtime logs showing the blocked_tool_call path disappearing. Is this the best way to solve the issue? No. This PR was a plausible early repair, but current main and the newer clean PR make the narrower owner-less reply-run cleanup the better maintainable path. Security review: Security review cleared: No concrete security or supply-chain concern was found in this superseded diff; it touches runtime diagnostics/session cleanup and tests, not dependencies, workflows, secrets, or install scripts. AGENTS.md: found and applied where relevant. What I checked:
Likely related people:
Codex review notes: model internal, reasoning high; reviewed against 663fabbe30eb. |
|
ClawSweeper PR egg: ✨ hatched 🥚 common Cosmic Crabkin. Rarity: 🥚 common. Trait: guards the happy path. DetailsShare on X: post this hatch
About:
|
|
🦞🔧 Source: I will update this PR branch, or open a safe credited replacement, if the repair worker finds a narrow CI fix. Automerge progress:
|
6c204a4 to
1bd8516
Compare
2bca356 to
99b4d3d
Compare
99b4d3d to
5dda835
Compare
Co-authored-by: Andy Ye <[email protected]> Co-authored-by: clawsweeper[bot] <274271284+clawsweeper[bot]@users.noreply.github.com>
Co-authored-by: Andy Ye <[email protected]> Co-authored-by: clawsweeper[bot] <274271284+clawsweeper[bot]@users.noreply.github.com>
Co-authored-by: Andy Ye <[email protected]> Co-authored-by: clawsweeper[bot] <274271284+clawsweeper[bot]@users.noreply.github.com>
d72c7d5 to
e32fc45
Compare
|
🦞✅ Source: Why human review is needed: What the maintainer can do as a next step: I added |
|
ClawSweeper applied the proposed close for this PR.
|
Makes #87374 merge-ready for the ClawSweeper automerge loop.
The edit pass should inspect the live PR diff, review comments, and failing checks; rebase if needed; keep the contributor branch credited; and stop only when validation is green or an external blocker is proven.
ClawSweeper 🐠 replacement reef notes:
Inherited issue-closing references from the source PR:
Closes #87310
Co-author credit kept:
fish notes: model gpt-5.5, reasoning high; reviewed against dce1dc0.