fix: prevent sessions_yield completion wake freeze#87330
Conversation
|
Codex review: needs real behavior proof before merge. Reviewed June 29, 2026, 7:51 AM ET / 11:51 UTC. Summary PR surface: Source +37, Tests +8. Total +45 across 6 files. Reproducibility: yes. at source level, but not with live runtime proof yet: current main lacks the proposed sessions_yield abort acceptance gate, and the active completion path can still queue into an active requester before falling back. Review metrics: 1 noteworthy metric.
Merge readiness Overall follows the weaker of proof and patch quality, so missing proof can cap an otherwise strong patch. Rank-up moves:
Proof guidance:
Mantis proof suggestion Risk before merge
Maintainer options:
Next step before merge
Security Review findings
Review detailsBest possible solution: Port any still-useful guard to current embedded-agent-runner paths, reconcile it with the active completion delivery contract, and require redacted real runtime or transport proof before merge. Do we have a high-confidence way to reproduce the issue? Yes at source level, but not with live runtime proof yet: current main lacks the proposed sessions_yield abort acceptance gate, and the active completion path can still queue into an active requester before falling back. Is this the best way to solve the issue? No as submitted: the guard is on obsolete files and the direct-handoff semantics need maintainer agreement against the current delivery contract. Full review comments:
Overall correctness: patch is incorrect AGENTS.md: found and applied where relevant. Codex review notes: model internal, reasoning high; reviewed against db2488b6e3d6. Label changesLabel justifications:
Evidence reviewedPR surface: Source +37, Tests +8. Total +45 across 6 files. View PR surface stats
What I checked:
Likely related people:
What the crustacean ranks mean
Shiny media proof means a screenshot, video, or linked artifact directly shows the changed behavior. Runtime, network, CSP, and security claims still need visible diagnostics. How this review workflow works
|
|
ClawSweeper PR egg 🎁 Pass real behavior proof to wake the egg and unlock a hatchable treat. Where did the egg go?
|
This comment was marked as spam.
This comment was marked as spam.
|
@adam-birddog thanks for the PR. ClawSweeper is still waiting on real behavior proof before this can move forward. Useful proof can be a screenshot, short video, terminal output, copied live output, linked artifact, or redacted logs that show the changed behavior after the fix. Please redact private tokens, phone numbers, private endpoints, customer data, and anything else sensitive. Once proof is added to the PR body or a comment, ClawSweeper or a maintainer can re-check it. |
|
This pull request has been automatically marked as stale due to inactivity. |
|
ClawSweeper status: review started. I am starting a fresh review of this pull request: fix: prevent sessions_yield completion wake freeze This is item 1/1 in the current shard. Shard 2/25. This placeholder means the worker is alive and reading the current context. I will edit this same comment with the actual review when the claws are done clicking. Crustacean status: shell secured, claws on keyboard, evidence pebbles being sorted. |
Summary
Tests
BR-0593