fix: install gogcli and add linuxbrew to global PATH#86749
fix: install gogcli and add linuxbrew to global PATH#86749jarvis-ai-gregmoser wants to merge 1 commit into
Conversation
|
Thanks for the contribution. I reviewed the branch, and this PR is not a good landing base for OpenClaw. Close this PR: it targets an obsolete root Dockerfile path, is currently conflicting, and broadens the common sandbox image dependency/PATH behavior without proof or maintainer-confirmed default-image direction. The separate current gog onboarding failure is already tracked by a cleaner open fix candidate. So I’m closing this PR rather than keeping an unmergeable branch open. A new narrow PR that carries only the useful part is welcome. Review detailsBest possible solution: Close this stale branch; land the focused gog skill metadata fix in #95019 for the current install failure, and use a maintainer-sponsored current-Dockerfile PR only if Do we have a high-confidence way to reproduce the issue? No high-confidence runtime reproduction is present. Source inspection shows the current common image does not install Is this the best way to solve the issue? No. As submitted, this is not the best fix because it edits an obsolete path and broadens common-image defaults; the current install failure is better handled by the focused skill metadata PR, while any default-image addition needs a new maintainer-approved current-Dockerfile proposal. Security review: Security review needs attention: The diff adds a new Homebrew package install to the common sandbox image, which needs supply-chain and build reliability acceptance before any replacement lands.
AGENTS.md: found and applied where relevant. What I checked:
Likely related people:
Codex review notes: model internal, reasoning high; reviewed against f8675b3b70d3. |
|
ClawSweeper PR egg 🎁 Pass real behavior proof to wake the egg and unlock a hatchable treat. Where did the egg go?
|
|
ClawSweeper applied the proposed close for this PR.
|
Fixes missing gogcli and PATH issues for sandbox image.