Skip to content

refactor: share realtime voice activation helpers#86615

Merged
steipete merged 1 commit into
mainfrom
refactor/generic-voice-activation
May 25, 2026
Merged

refactor: share realtime voice activation helpers#86615
steipete merged 1 commit into
mainfrom
refactor/generic-voice-activation

Conversation

@steipete

Copy link
Copy Markdown
Contributor

Summary

  • Move realtime voice activation-name normalization, exact/fuzzy edge matching, and transcript stripping into shared src/talk helpers exported through openclaw/plugin-sdk/realtime-voice.
  • Move forced-consult transcript skip classification into shared realtime voice code and keep Discord as the platform adapter.
  • Reuse the shared activation-name helpers in Discord doctor wake-name validation/repair, update the Plugin SDK API baseline, and add focused shared tests.

Verification

  • node scripts/run-vitest.mjs src/talk/activation-name.test.ts src/talk/consult-transcript.test.ts extensions/discord/src/doctor.test.ts
  • pnpm test -- extensions/discord/src/voice/manager.e2e.test.ts -t "wake-name|configured wake|OpenClaw as a default wake"
  • pnpm plugin-sdk:api:check
  • pnpm build
  • env -u OPENCLAW_TESTBOX pnpm check:changed
  • .agents/skills/autoreview/scripts/autoreview --mode local clean after regenerating the Plugin SDK API baseline hash

Real behavior proof

Behavior addressed: shared generic realtime voice activation-name matching and forced-consult transcript screening while preserving Discord wake-name behavior.
Real environment tested: local macOS checkout with repo Vitest wrappers, Plugin SDK API baseline check, production build, changed gate, and structured autoreview.
Exact steps or command run after this patch: pnpm test -- extensions/discord/src/voice/manager.e2e.test.ts -t "wake-name|configured wake|OpenClaw as a default wake"
Evidence after fix: Discord wake-name e2e subset passed 3 tests with 113 skipped in extensions/discord/src/voice/manager.e2e.test.ts; shared activation/consult tests plus Discord doctor tests passed 22 tests across 3 files.
Observed result after fix: Discord still accepts default/configured/fuzzy wake names and rejects unsupported long names, while the reusable helpers are covered in src/talk.
What was not tested: live Discord voice audio, browser voice, and Google Meet runtime sessions were not exercised; this patch only extracts pure transcript logic and keeps existing Discord integration behavior covered by unit/e2e tests.

@openclaw-barnacle openclaw-barnacle Bot added docs Improvements or additions to documentation channel: discord Channel integration: discord size: L maintainer Maintainer-authored PR labels May 25, 2026
@clawsweeper

clawsweeper Bot commented May 25, 2026

Copy link
Copy Markdown
Contributor

ClawSweeper status: review started.

I am starting a fresh review of this pull request: refactor: share realtime voice activation helpers This is item 1/1 in the current shard. Shard 0/1.

This placeholder means the worker is alive and reading the current context. I will edit this same comment with the actual review when the claws are done clicking.

Crustacean status: shell secured, claws on keyboard, evidence pebbles being sorted.

@steipete
steipete merged commit d0ab0d9 into main May 25, 2026
128 of 132 checks passed
@steipete
steipete deleted the refactor/generic-voice-activation branch May 25, 2026 19:25
github-actions Bot pushed a commit to Desicool/openclaw that referenced this pull request May 26, 2026
SebTardif pushed a commit to SebTardif/openclaw that referenced this pull request May 26, 2026
SebTardif pushed a commit to SebTardif/openclaw that referenced this pull request May 26, 2026
SebTardif pushed a commit to SebTardif/openclaw that referenced this pull request May 26, 2026
jameslcowan pushed a commit to jameslcowan/openclaw that referenced this pull request Jun 2, 2026
SYU8384 pushed a commit to SYU8384/openclaw that referenced this pull request Jun 3, 2026
sablehead pushed a commit to sablehead/openclaw that referenced this pull request Jun 10, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

channel: discord Channel integration: discord docs Improvements or additions to documentation maintainer Maintainer-authored PR size: L

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant