refactor: share realtime voice activation helpers#86615
Merged
Conversation
Contributor
|
ClawSweeper status: review started. I am starting a fresh review of this pull request: refactor: share realtime voice activation helpers This is item 1/1 in the current shard. Shard 0/1. This placeholder means the worker is alive and reading the current context. I will edit this same comment with the actual review when the claws are done clicking. Crustacean status: shell secured, claws on keyboard, evidence pebbles being sorted. |
github-actions Bot
pushed a commit
to Desicool/openclaw
that referenced
this pull request
May 26, 2026
SebTardif
pushed a commit
to SebTardif/openclaw
that referenced
this pull request
May 26, 2026
SebTardif
pushed a commit
to SebTardif/openclaw
that referenced
this pull request
May 26, 2026
SebTardif
pushed a commit
to SebTardif/openclaw
that referenced
this pull request
May 26, 2026
jameslcowan
pushed a commit
to jameslcowan/openclaw
that referenced
this pull request
Jun 2, 2026
SYU8384
pushed a commit
to SYU8384/openclaw
that referenced
this pull request
Jun 3, 2026
sablehead
pushed a commit
to sablehead/openclaw
that referenced
this pull request
Jun 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
src/talkhelpers exported throughopenclaw/plugin-sdk/realtime-voice.Verification
node scripts/run-vitest.mjs src/talk/activation-name.test.ts src/talk/consult-transcript.test.ts extensions/discord/src/doctor.test.tspnpm test -- extensions/discord/src/voice/manager.e2e.test.ts -t "wake-name|configured wake|OpenClaw as a default wake"pnpm plugin-sdk:api:checkpnpm buildenv -u OPENCLAW_TESTBOX pnpm check:changed.agents/skills/autoreview/scripts/autoreview --mode localclean after regenerating the Plugin SDK API baseline hashReal behavior proof
Behavior addressed: shared generic realtime voice activation-name matching and forced-consult transcript screening while preserving Discord wake-name behavior.
Real environment tested: local macOS checkout with repo Vitest wrappers, Plugin SDK API baseline check, production build, changed gate, and structured autoreview.
Exact steps or command run after this patch:
pnpm test -- extensions/discord/src/voice/manager.e2e.test.ts -t "wake-name|configured wake|OpenClaw as a default wake"Evidence after fix: Discord wake-name e2e subset passed 3 tests with 113 skipped in
extensions/discord/src/voice/manager.e2e.test.ts; shared activation/consult tests plus Discord doctor tests passed 22 tests across 3 files.Observed result after fix: Discord still accepts default/configured/fuzzy wake names and rejects unsupported long names, while the reusable helpers are covered in
src/talk.What was not tested: live Discord voice audio, browser voice, and Google Meet runtime sessions were not exercised; this patch only extracts pure transcript logic and keeps existing Discord integration behavior covered by unit/e2e tests.