fix(feishu): render native presentation buttons by clawsweeper[bot] · Pull Request #86588 · openclaw/openclaw

clawsweeper · 2026-05-25T17:34:51Z

Makes #86017 merge-ready for the ClawSweeper automerge loop.
The edit pass should inspect the live PR diff, review comments, and failing checks; rebase if needed; keep the contributor branch credited; and stop only when validation is green or an external blocker is proven.

ClawSweeper 🐠 replacement reef notes:

Cluster: automerge-openclaw-openclaw-86017
Source PRs: fix(feishu): render native presentation buttons #86017
Credit: Source PR: fix(feishu): render native presentation buttons #86017
Validation: pnpm check:changed
Replacement reason: ClawSweeper could not update the source PR branch directly, so it opened a writable replacement PR instead.
Automerge requested by: @Takhoffman

Repair fallback: GitHub rejected the repair branch push because it updates workflow files and the ClawSweeper app token does not have workflows permission

Inherited issue-closing references from the source PR:
Fixes #85959

Co-author credit kept:

@NianJiuZst: Co-authored-by: NianJiu [email protected]

fish notes: model gpt-5.5, reasoning high; reviewed against 261d5a8.

clawsweeper · 2026-05-25T17:36:35Z

🦞✅
ClawSweeper merged this PR after the passing review.

Source: clawsweeper[bot]
Feedback: structured ClawSweeper verdict: pass (sha=36d6a363235650f2a10162014a9649fd520b53d0)
Merge status: merged by ClawSweeper automerge
Merged at: 2026-05-25T19:20:43Z
Merge commit: 170e0aac2a54

What merged:

The PR replaces Feishu presentation/action card fallback rendering with a shared JSON 2.0 button/behaviors renderer, updates native card sanitization, and expands Feishu channel/outbound tests.
PR surface: Source +118, Tests +223. Total +341 across 5 files.
Reproducibility: yes. source-reproducible: current main renders Feishu presentation button blocks through ma ... help` fallback. I did not run local tests because this review was required to keep the checkout read-only.

Automerge notes:

PR branch already contained follow-up commit before automerge: fix(feishu): render native presentation buttons
PR branch already contained follow-up commit before automerge: fix(clawsweeper): address review for automerge-openclaw-openclaw-8601…

The automerge loop is complete.

Automerge progress:

2026-05-25 18:34:54 UTC validation and review 1 9d37b689e728 (base moved) in 16m 38s Run: https://github.com/openclaw/clawsweeper/actions/runs/26414006151 rebased

2026-05-25 18:34:58 UTC repair completed 9d37b689e728 (branch updated) in 16m 42s Run: https://github.com/openclaw/clawsweeper/actions/runs/26414006151 initial automerge rebase is delegated to Codex repair

2026-05-25 18:34:58 UTC review queued 9d37b689e728 (after repair)

2026-05-25 18:45:01 UTC automerge wait 9d37b689e728 (waiting) in 26m 45s Run: https://github.com/openclaw/clawsweeper/actions/runs/26414006151 waiting for exact-head ClawSweeper review pass

2026-05-25 18:45:02 UTC repair finished 9d37b689e728 (pushed) in 26m 46s Run: https://github.com/openclaw/clawsweeper/actions/runs/26414006151 repair_contributor_branch

2026-05-25 18:45:47 UTC review requested repair 9d37b689e728 (structured ClawSweeper marker: fix-required (finding=review-feedback sha=9d37b6...)

2026-05-25 18:46:05 UTC repair queued 9d37b689e728 (autonomous) Run: https://github.com/openclaw/clawsweeper/actions/runs/26415066122

2026-05-25 18:47:44 UTC repair started (running) in 0s Run: https://github.com/openclaw/clawsweeper/actions/runs/26415066122 automerge-openclaw-openclaw-86017

2026-05-25 18:48:00 UTC validation plan (passed) in 16s Run: https://github.com/openclaw/clawsweeper/actions/runs/26415066122 node scripts/run-vitest.mjs extensions/feishu/src/channel.test.ts extensions/feishu/src/outbound.test.ts; pnpm check:changed; pnpm lint; pnpm check:test-types

2026-05-25 18:48:12 UTC Codex write preflight (passed) in 28s Run: https://github.com/openclaw/clawsweeper/actions/runs/26415066122 danger-full-access

2026-05-25 18:56:03 UTC Codex edit 1 02363c0075cc (complete) in 8m 19s Run: https://github.com/openclaw/clawsweeper/actions/runs/26415066122 exit 0

2026-05-25 18:54:49 UTC review queued 9d37b689e728 (queued)

2026-05-25 19:09:31 UTC validation and review 1 36d6a3632356 (base moved) in 21m 47s Run: https://github.com/openclaw/clawsweeper/actions/runs/26415066122 rebased

2026-05-25 19:10:06 UTC repair finished 36d6a3632356 (opened) in 22m 22s Run: https://github.com/openclaw/clawsweeper/actions/runs/26415066122 open_fix_pr

2026-05-25 19:20:32 UTC review passed 36d6a3632356 (structured ClawSweeper verdict: pass (sha=36d6a363235650f2a10162014a9649fd520b5...)

2026-05-25 19:20:45 UTC merged 36d6a3632356 (merged by ClawSweeper automerge)

clawsweeper · 2026-05-25T17:38:56Z

Codex review: passed. Reviewed May 25, 2026, 3:16 PM ET / 19:16 UTC.

Summary
The PR replaces Feishu presentation/action card fallback rendering with a shared JSON 2.0 button/behaviors renderer, updates native card sanitization, and expands Feishu channel/outbound tests.

PR surface: Source +118, Tests +223. Total +341 across 5 files.

Reproducibility: yes. source-reproducible: current main renders Feishu presentation button blocks through markdown fallback text, and the old test expectation covered the - Run help fallback. I did not run local tests because this review was required to keep the checkout read-only.

Review metrics: 1 noteworthy metric.

Feishu card payload contract: 1 payload shape changed. The PR intentionally changes presentation and sanitized native-card buttons to JSON 2.0 button behaviors, which is a delivery contract maintainers should notice before merge.

Merge readiness
Overall: 🐚 platinum hermit
Proof: 🐚 platinum hermit ✨ media proof bonus
Patch quality: 🦞 diamond lobster
Result: ready for maintainer review.

Overall follows the weaker of proof and patch quality, so missing proof can cap an otherwise strong patch.

Rank-up moves:

none

Mantis proof suggestion
A Feishu/Lark visual or log-backed proof would still materially reduce the residual native-button delivery and callback risk. A maintainer can ask Mantis to capture proof by posting a new PR comment that starts with the OpenClaw Mantis account mention, followed by:

visual task: verify a Feishu/Lark presentation send displays native buttons and a value-button callback is received.

Risk before merge

The PR changes Feishu card delivery and callback payload shape from legacy action/value output to JSON 2.0 button/behaviors output; repository tests and proof checks are positive, but real Feishu/Lark tenants remain the final arbiter for visible rendering and callback delivery.

Maintainer options:

Proceed with exact-head gated automerge (recommended)
Allow the automerge lane to land this head after required checks pass, accepting the residual live Feishu/Lark delivery risk for the new button/behaviors payload.
Ask for live tenant confirmation
Before merge, a maintainer can request a redacted Feishu/Lark send plus callback proof showing the current button/behaviors payload renders and routes correctly.

Next step before merge
No ClawSweeper repair lane is needed; this PR is already in the automerge path with no actionable code findings, while checks and maintainer acceptance of the delivery-risk label should gate merge.

Security
Cleared: No concrete security or supply-chain regression was found; the diff stays in Feishu runtime/tests and preserves http(s)-only URL sanitization for card buttons.

Review details

Best possible solution:

Land the shared JSON 2.0 button/behaviors renderer through the exact-head automerge gate once required checks are green, with the residual Feishu/Lark delivery risk explicitly accepted or covered by live proof.

Do we have a high-confidence way to reproduce the issue?

Yes, source-reproducible: current main renders Feishu presentation button blocks through markdown fallback text, and the old test expectation covered the - Run help fallback. I did not run local tests because this review was required to keep the checkout read-only.

Is this the best way to solve the issue?

Yes. The shared Feishu presentation-card helper is the narrow maintainable fix because it removes duplicate rendering logic and updates both message-tool and outbound paths; the remaining concern is platform delivery proof, not a code-shape blocker.

AGENTS.md: found and applied where relevant.

Codex review notes: model gpt-5.5, reasoning high; reviewed against 423f7d22bc67.

Label changes

Label changes:

remove rating: 🧂 unranked krab: Current PR rating is rating: 🐚 platinum hermit, so this older rating label is no longer current.
remove status: 👀 ready for maintainer look: Current PR status label is status: 🚀 automerge armed.

Label justifications:

P2: This is a normal-priority Feishu channel bug fix with visible message-delivery impact but limited blast radius.
merge-risk: 🚨 message-delivery: Merging changes Feishu/Lark card button rendering and callback routing, so a live tenant could expose delivery behavior not settled by unit tests alone.
rating: 🐚 platinum hermit: Overall readiness is 🐚 platinum hermit; proof is 🐚 platinum hermit and patch quality is 🦞 diamond lobster.
status: 🚀 automerge armed: This PR is in ClawSweeper's automerge lane. Sufficient (linked_artifact): The current head has a successful GitHub Real behavior proof check and proof: sufficient label; no contributor proof action remains for this ClawSweeper replacement PR.
proof: sufficient: Contributor real behavior proof is sufficient. The current head has a successful GitHub Real behavior proof check and proof: sufficient label; no contributor proof action remains for this ClawSweeper replacement PR.

Evidence reviewed

PR surface:

Source +118, Tests +223. Total +341 across 5 files.

View PR surface stats

Area	Files	Added	Removed	Net
Source	3	289	171	+118
Tests	2	251	28	+223
Docs	0	0	0	0
Config	0	0	0	0
Generated	0	0	0	0
Other	0	0	0	0
Total	5	540	199	+341

What I checked:

Repository policy read: Read the full root policy and scoped extensions policy; their plugin-boundary, dependency-contract, and channel-delivery proof guidance affected the review. (AGENTS.md:1, 423f7d22bc67)
Current main bug surface: Current main's Feishu message-tool presentation-card builder emits one markdown fallback element from renderMessagePresentationFallbackText, which flattens button blocks instead of producing native Feishu buttons. (extensions/feishu/src/channel.ts:186, 423f7d22bc67)
PR implementation: The PR head builds direct Feishu card button elements with open_url/callback behaviors and structured OpenClaw callback envelopes. (extensions/feishu/src/presentation-card.ts:53, 36d6a3632356)
Native-card sanitizer path: Caller-supplied native cards are normalized into safe JSON 2.0 button behaviors while unsupported elements and unsafe URLs are dropped. (extensions/feishu/src/outbound.ts:108, 36d6a3632356)
Regression coverage: The branch tests presentation value buttons, webApp link buttons, unsafe URL dropping, and caller-supplied native-card normalization for the new button/behaviors shape. (extensions/feishu/src/outbound.test.ts:493, 36d6a3632356)
Proof and CI signal: The current head has a successful GitHub Real behavior proof check and successful focused gates including prod types, lint, test types, and build artifacts; automerge still gates the exact head. (36d6a3632356)

Likely related people:

vincentkoc: Commit 2161b46 added Feishu native interactive card payload sends in the same outbound sanitizer/send surface this PR changes. (role: introduced adjacent native-card behavior; confidence: high; commits: 2161b46032e0; files: extensions/feishu/src/outbound.ts, extensions/feishu/src/outbound.test.ts)
steipete: Commit ad861d4 added presentation capability limits across the Feishu channel/outbound files and the shared interactive payload contract. (role: recent presentation-contract contributor; confidence: medium; commits: ad861d4c9df8; files: extensions/feishu/src/channel.ts, extensions/feishu/src/outbound.ts, src/interactive/payload.ts)
wittam-01: Commit ebb72ba recently touched Feishu outbound behavior for document/comment session work, making this a useful routing candidate for Feishu callback or comment-delivery regressions. (role: adjacent Feishu contributor; confidence: low; commits: ebb72baba3cd; files: extensions/feishu/src/outbound.ts)

What the crustacean ranks mean

🦀 challenger crab: rare, exceptional readiness with strong proof, clean implementation, and convincing validation.
🦞 diamond lobster: very strong readiness with only minor maintainer review expected.
🐚 platinum hermit: good normal PR, likely mergeable with ordinary maintainer review.
🦐 gold shrimp: useful signal, but proof or patch confidence is still limited.
🦪 silver shellfish: thin signal; proof, validation, or implementation needs work.
🧂 unranked krab: not merge-ready because proof is missing/unusable or there are serious correctness or safety concerns.
🌊 off-meta tidepool: rating does not apply to this item.

Shiny media proof means a screenshot, video, or linked artifact directly shows the changed behavior. Runtime, network, CSP, and security claims still need visible diagnostics.

How this review workflow works

ClawSweeper keeps one durable marker-backed review comment per issue or PR.
Re-runs edit this comment so the latest verdict, findings, and automation markers stay together instead of adding duplicate bot comments.
A fresh review can be triggered by eligible @clawsweeper re-review comments, exact-item GitHub events, scheduled/background review runs, or manual workflow dispatch.
PR/issue authors and users with repository write access can comment @clawsweeper re-review or @clawsweeper re-run on an open PR or issue to request a fresh review only.
Maintainers can also comment @clawsweeper review to request a fresh review only.
Fresh-review commands do not start repair, autofix, rebase, CI repair, or automerge.
Maintainer-only repair and merge flows require explicit commands such as @clawsweeper autofix, @clawsweeper automerge, @clawsweeper fix ci, or @clawsweeper address review.
Maintainers can comment @clawsweeper explain to ask for more context, or @clawsweeper stop to stop active automation.

clawsweeper · 2026-05-25T17:51:23Z

ClawSweeper PR egg

✨ Hatched: 💎 rare Mossy Crabkin

Hatch command

Comment @clawsweeper hatch when this PR is hatchable.

Hatchability rules:

Merged PRs are hatchable.
Open PRs are hatchable when they are status: 👀 ready for maintainer look, status: 🚀 automerge armed, or labeled clawsweeper:automerge.
Closed unmerged PRs are hatchable only when one of those hatchable labels is still present in the durable record.

Rarity: 💎 rare.
Trait: polishes edge cases.
Image traits: location release reef; accessory commit compass; palette violet, aqua, and starlight; mood celebratory; pose nestled inside a glowing shell; shell frosted glass shell; lighting soft studio lighting; background miniature CI buoys.
Share on X: post this hatch
Copy: My PR egg hatched a 💎 rare Mossy Crabkin in ClawSweeper.

What is this egg doing here?

Eggs appear after the PR passes real-behavior proof. It is here for vibes, not verdicts: it does not change labels, ratings, merge decisions, or automation.
The shell reacts to review momentum: open follow-up work warms it up, re-review makes it wobble, and a clean final review lets it hatch.
Hatchability usually comes from sufficient real-behavior proof, no blocking P0/P1/P2 findings, no security attention needed, and clean correctness. A merged PR is already final, so merge makes the egg hatchable independently.
The hatch is seeded from this repository and PR number, so the same PR keeps the same creature; the reviewed head SHA can only change safe visual details.
Rarity is just collectible sparkle: 🥚 common, 🌱 uncommon, 💎 rare, ✨ glimmer, and 🌈 legendary.

Co-authored-by: NianJiu <[email protected]> Co-authored-by: clawsweeper[bot] <274271284+clawsweeper[bot]@users.noreply.github.com>

…7 (1) Co-authored-by: NianJiu <[email protected]> Co-authored-by: clawsweeper[bot] <274271284+clawsweeper[bot]@users.noreply.github.com>

Summary: - The PR replaces Feishu presentation/action card fallback rendering with a shared JSON 2.0 button/behaviors renderer, updates native card sanitization, and expands Feishu channel/outbound tests. - PR surface: Source +118, Tests +223. Total +341 across 5 files. - Reproducibility: yes. source-reproducible: current main renders Feishu presentation button blocks through ma ... help` fallback. I did not run local tests because this review was required to keep the checkout read-only. Automerge notes: - PR branch already contained follow-up commit before automerge: fix(feishu): render native presentation buttons - PR branch already contained follow-up commit before automerge: fix(clawsweeper): address review for automerge-openclaw-openclaw-8601… Validation: - ClawSweeper review passed for head 36d6a36. - Required merge gates passed before the squash merge. Prepared head SHA: 36d6a36 Review: openclaw#86588 (comment) Co-authored-by: NianJiuZst <[email protected]> Co-authored-by: clawsweeper <274271284+clawsweeper[bot]@users.noreply.github.com> Co-authored-by: clawsweeper[bot] <274271284+clawsweeper[bot]@users.noreply.github.com> Approved-by: takhoffman Co-authored-by: takhoffman <[email protected]>

clawsweeper Bot mentioned this pull request May 25, 2026

fix(feishu): render native presentation buttons #86017

Closed

openclaw-barnacle Bot removed the proof: supplied External PR includes structured after-fix real behavior proof. label May 25, 2026

clawsweeper Bot force-pushed the clawsweeper/automerge-openclaw-openclaw-86017 branch from 261d5a8 to e535556 Compare May 25, 2026 18:10

openclaw-barnacle Bot added size: L and removed size: M labels May 25, 2026

clawsweeper Bot force-pushed the clawsweeper/automerge-openclaw-openclaw-86017 branch 2 times, most recently from 9d37b68 to 91dc3ad Compare May 25, 2026 18:56

NianJiuZst and others added 5 commits May 25, 2026 19:09

fix(feishu): render native presentation buttons

7d847c7

fix(feishu): render native presentation buttons

d3e7c42

fix(feishu): render native presentation buttons

a719833

fix(feishu): render native presentation buttons

4662e20

fix(feishu): render native presentation buttons

236733f

Co-authored-by: NianJiu <[email protected]> Co-authored-by: clawsweeper[bot] <274271284+clawsweeper[bot]@users.noreply.github.com>

fix(clawsweeper): address review for automerge-openclaw-openclaw-8601…

36d6a36

…7 (1) Co-authored-by: NianJiu <[email protected]> Co-authored-by: clawsweeper[bot] <274271284+clawsweeper[bot]@users.noreply.github.com>

clawsweeper Bot force-pushed the clawsweeper/automerge-openclaw-openclaw-86017 branch from 0942586 to 36d6a36 Compare May 25, 2026 19:09

clawsweeper Bot added size: M proof: supplied External PR includes structured after-fix real behavior proof. proof: sufficient ClawSweeper judged the real behavior proof convincing. labels May 25, 2026

openclaw-barnacle Bot removed the size: M label May 25, 2026

clawsweeper Bot added rating: 🐚 platinum hermit Good normal PR readiness with ordinary maintainer review expected. status: 👀 ready for maintainer look ClawSweeper has no concrete contributor-facing blocker left for this PR. labels May 25, 2026

openclaw-barnacle Bot removed the proof: supplied External PR includes structured after-fix real behavior proof. label May 25, 2026

clawsweeper Bot removed rating: 🧂 unranked krab Not merge-ready due to missing proof or serious correctness/safety concerns. status: 👀 ready for maintainer look ClawSweeper has no concrete contributor-facing blocker left for this PR. labels May 25, 2026

clawsweeper Bot merged commit 170e0aa into main May 25, 2026
134 of 145 checks passed

clawsweeper Bot deleted the clawsweeper/automerge-openclaw-openclaw-86017 branch May 25, 2026 19:20

github-actions Bot mentioned this pull request May 25, 2026

📡 Upstream Digest — 2026-05-25 20:57 UTC curtismercier/openclaw-mods#946

Open

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Uh oh!

fix(feishu): render native presentation buttons#86588

fix(feishu): render native presentation buttons#86588
clawsweeper[bot] merged 6 commits into
mainfrom
clawsweeper/automerge-openclaw-openclaw-86017

clawsweeper Bot commented May 25, 2026

Uh oh!

clawsweeper Bot commented May 25, 2026 •

edited

Loading

Uh oh!

clawsweeper Bot commented May 25, 2026 •

edited

Loading

Uh oh!

clawsweeper Bot commented May 25, 2026 •

edited

Loading

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

Uh oh!

Uh oh!

Conversation

clawsweeper Bot commented May 25, 2026

Uh oh!

clawsweeper Bot commented May 25, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

clawsweeper Bot commented May 25, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

clawsweeper Bot commented May 25, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Hatch command

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

clawsweeper Bot commented May 25, 2026 •

edited

Loading

clawsweeper Bot commented May 25, 2026 •

edited

Loading

clawsweeper Bot commented May 25, 2026 •

edited

Loading