Avoid post-run auth success lane delay#85829
Conversation
|
Codex review: needs maintainer review before merge. Reviewed June 28, 2026, 6:59 PM ET / 22:59 UTC. Summary PR surface: Source +34, Tests +17. Total +51 across 2 files. Reproducibility: yes. at source level: current main and v2026.6.10 await Review metrics: 1 noteworthy metric.
Root-cause cluster Members:
Proposal only: this assessment does not dispatch repair, suppress jobs, mutate sibling items, close, or merge anything. Merge readiness Overall follows the weaker of proof and patch quality, so missing proof can cap an otherwise strong patch. Rank-up moves:
Risk before merge
Maintainer options:
Next step before merge
Security Review detailsBest possible solution: Land the latency fix after maintainers either accept the bounded stale-auth-metadata risk or require the background auth-success write to be tracked by a drainable lifecycle without re-blocking reply delivery. Do we have a high-confidence way to reproduce the issue? Yes at source level: current main and v2026.6.10 await Is this the best way to solve the issue? Acceptable mitigation, with one maintainer decision remaining. Targeting shared embedded-runner auth bookkeeping is better than a Discord-only workaround, but maintainers must decide whether fire-and-forget persistence is acceptable or should be made drainable. AGENTS.md: found and applied where relevant. Codex review notes: model internal, reasoning high; reviewed against 87aae9f11d27. Label changesLabel justifications:
Evidence reviewedPR surface: Source +34, Tests +17. Total +51 across 2 files. View PR surface stats
What I checked:
Likely related people:
What the crustacean ranks mean
Shiny media proof means a screenshot, video, or linked artifact directly shows the changed behavior. Runtime, network, CSP, and security claims still need visible diagnostics. How this review workflow works
|
|
ClawSweeper PR egg ✨ Hatched: 🌱 uncommon Tiny Shellbean Hatch commandComment Hatchability rules:
Rarity: 🌱 uncommon. What is this egg doing here?
|
|
Added the live gateway-backed proof ClawSweeper asked for to the PR body. Tested commit: The redacted ordering proof shows durable delivery completed at @clawsweeper re-review |
|
🦞🧹 I asked ClawSweeper to review this item again. Re-review progress:
|
|
Production confirmation from 2026.5.22: making We applied the equivalent local dist hotfix plus a separate stale-lock fix and restarted Gateway. Discord delivery dropped from the previous ~50-60s post-run tail to:
The underlying waiter in our case was a stale Separate stale-lock bug filed as #86814 because current |
This comment was marked as spam.
This comment was marked as spam.
25abd9b to
6bf4978
Compare
6bf4978 to
4be7576
Compare
0a5e39b to
37d534c
Compare
37d534c to
b152946
Compare
b152946 to
fe90336
Compare
* fix: avoid post-run auth success lane delay * fix: redact post-run auth profile logs * Fix embedded runner auth-success test rename
* fix: avoid post-run auth success lane delay * fix: redact post-run auth profile logs * Fix embedded runner auth-success test rename
* fix: avoid post-run auth success lane delay * fix: redact post-run auth profile logs * Fix embedded runner auth-success test rename
* fix: avoid post-run auth success lane delay * fix: redact post-run auth profile logs * Fix embedded runner auth-success test rename
Summary
Fixes #85822
Real behavior proof
fix/post-run-auth-success-nonblocking-85822, head25abd9b133e837d929f8fae8dc6977618325344a./Users/andy/openclaw/openclaw-85521/node_modules/.bin/oxfmt --write --threads=1 src/agents/pi-embedded-runner/run.tsnode scripts/run-vitest.mjs src/agents/pi-embedded-runner/run.overflow-compaction.loop.test.ts src/agents/auth-profiles/profiles.test.ts src/process/command-queue.test.tsnode scripts/run-vitest.mjs src/agents/pi-embedded-runner/run/attempt-stage-timing.test.ts src/logging/diagnostic-stuck-session-recovery.runtime.test.tsnode scripts/check-changed.mjs --base upstream/mainnode scripts/pr85829-live-proof.mjsfrom a temporary PR worktree with local-only proof instrumentation and a 3000ms auth-success bookkeeping delayqa-channeldurable transport, an isolatedOPENCLAW_HOME, and a mock OpenAI Responses endpoint. The only extra local instrumentation added proof markers and injected a 3000ms delay inside post-run auth-profile success bookkeeping after embedded run completion.runEmbeddedPiAgentpath with auth-success bookkeeping intentionally left unresolved, and the run still resolves successfully instead of waiting for that bookkeeping promise. The live gateway-backed proof shows durable qa-channel delivery completed at02:23:38.477Z, while delayed post-run auth-success bookkeeping completed at02:23:41.313Z, about 2.8s later.qa-channeltransport rather than a live Discord API send, so Discord-specific API behavior was not exercised. The gateway reply/durable-delivery ordering ClawSweeper requested is covered.Validation
/Users/andy/openclaw/openclaw-85521/node_modules/.bin/oxfmt --write --threads=1 src/agents/pi-embedded-runner/run.tsnode scripts/run-vitest.mjs src/agents/pi-embedded-runner/run.overflow-compaction.loop.test.ts src/agents/auth-profiles/profiles.test.ts src/process/command-queue.test.tsnode scripts/run-vitest.mjs src/agents/pi-embedded-runner/run/attempt-stage-timing.test.ts src/logging/diagnostic-stuck-session-recovery.runtime.test.tsnode scripts/check-changed.mjs --base upstream/mainnode scripts/pr85829-live-proof.mjsAttribution
If this PR is squashed or reworked, please preserve author attribution or include:
Co-authored-by: Andy Ye [email protected]