fix(memory-core): bound managed dreaming under pressure#84848
Open
galiniliev wants to merge 4 commits into
Open
fix(memory-core): bound managed dreaming under pressure#84848galiniliev wants to merge 4 commits into
galiniliev wants to merge 4 commits into
Conversation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Motivation
Change Type (select all)
Scope (select all touched areas)
Linked Issue/PR
Real behavior proof (required for external PRs)
pnpm format:fix extensions/memory-core/src/dreaming.ts extensions/memory-core/src/dreaming.test.ts src/auto-reply/reply/get-reply.ts src/auto-reply/reply/get-reply.before-agent-reply.test.ts src/agents/cli-runner.ts src/agents/cli-runner.before-agent-reply-cron.test.ts src/agents/pi-embedded-runner/run.ts src/agents/pi-embedded-runner/run.before-agent-reply-cron.test.ts src/plugins/hook-types.ts;git diff --check;pnpm run lint:extensions:bundled;node scripts/run-oxlint.mjs src/plugins/hook-types.ts src/auto-reply/reply/get-reply.ts src/auto-reply/reply/get-reply.before-agent-reply.test.ts src/agents/cli-runner.ts src/agents/cli-runner.before-agent-reply-cron.test.ts src/agents/pi-embedded-runner/run.ts src/agents/pi-embedded-runner/run.before-agent-reply-cron.test.ts;pnpm tsgo:extensions;pnpm tsgo:core;AUTOREVIEW_AUTO_TESTS=0 .agents/skills/autoreview/scripts/autoreview --mode local.OPENCLAW_VITEST_MAX_WORKERS=1 timeout 180s node scripts/run-vitest.mjs ...timed out after printing only the Vitest banner. Remote focused Vitest proof was also blocked here: Blacksmith Testbox is unavailable because theblacksmithCLI is not installed, and direct AWS Crabbox is unavailable because AWS credentials/IMDS are not present. A live multi-workspace gateway run with private agent/session data was not rerun.memory-core: dreaming promotion complete (workspaces=10, candidates=10, applied=1, failed=0) observed managed background task duration: 69621ms memory pressure warning: rssBytes=1827979264 heapUsedBytes=684072312 thresholdBytes=1610612736 liveness warning: eventLoopUtilization=0.991 cpuCoreRatio=1.107 active=0 waiting=0 queued=0Root Cause (if applicable)
Regression Test Plan (if applicable)
extensions/memory-core/src/dreaming.test.ts,src/auto-reply/reply/get-reply.before-agent-reply.test.ts,src/agents/cli-runner.before-agent-reply-cron.test.ts,src/agents/pi-embedded-runner/run.before-agent-reply-cron.test.tsUser-visible / Behavior Changes
Scheduled memory dreaming still uses
dreaming.frequencyas the cadence for a full configured-workspace sweep. When gateway RSS or heap usage is above the warning threshold before a workspace starts, or before the detached Dream Diary narrative is scheduled, scheduled dreaming waits before continuing. The wait starts at 30 seconds, doubles, and caps at 5 minutes between retries. No remaining workspaces are intentionally deferred to a later cron tick by memory-core; the run continues when pressure clears unless the enclosing cron run aborts/times out.Diagram (if applicable)
Security Impact (required)
Yes/No) NoYes/No) NoYes/No) NoYes/No) NoYes/No) NoYes, explain risk + mitigation: N/ARepro + Verification
Environment
Steps
Expected
Actual
Evidence
Attach at least one:
Human Verification (required)
What you personally verified (not just CI), and how:
Review Conversations
If a bot review conversation is addressed by this PR, resolve that conversation yourself. Do not leave bot review conversation cleanup for maintainers.
Compatibility / Migration
Yes/No) YesYes/No) NoYes/No) NoRisks and Mitigations