fix(memory-core): allow bounded dreaming session cleanup by clawsweeper[bot] · Pull Request #84802 · openclaw/openclaw

clawsweeper · 2026-05-21T04:14:47Z

Makes #70464 merge-ready for the ClawSweeper automerge loop.
The edit pass should inspect the live PR diff, review comments, and failing checks; rebase if needed; keep the contributor branch credited; and stop only when validation is green or an external blocker is proven.

ClawSweeper 🐠 replacement reef notes:

Cluster: automerge-openclaw-openclaw-70464
Source PRs: fix(memory-core): allow bounded dreaming session cleanup #70464
Credit: Source PR: fix(memory-core): allow bounded dreaming session cleanup #70464
Validation: pnpm check:changed
Replacement reason: ClawSweeper could not update the source PR branch directly, so it opened a writable replacement PR instead.
Automerge requested by: @Takhoffman

Repair fallback: GitHub rejected the repair branch push because it updates workflow files and the ClawSweeper app token does not have workflows permission

Co-author credit kept:

@chiyouYCH: Co-authored-by: chiyouYCH [email protected]

fish notes: model gpt-5.5, reasoning high; reviewed against c752d0f.

clawsweeper · 2026-05-21T04:16:16Z

Codex review: passed.

Workflow note: Future ClawSweeper reviews update this same comment in place.

How this review workflow works

ClawSweeper keeps one durable marker-backed review comment per issue or PR.
Re-runs edit this comment so the latest verdict, findings, and automation markers stay together instead of adding duplicate bot comments.
A fresh review can be triggered by eligible @clawsweeper re-review comments, exact-item GitHub events, scheduled/background review runs, or manual workflow dispatch.
PR/issue authors and users with repository write access can comment @clawsweeper re-review or @clawsweeper re-run on an open PR or issue to request a fresh review only.
Maintainers can also comment @clawsweeper review to request a fresh review only.
Fresh-review commands do not start repair, autofix, rebase, CI repair, or automerge.
Maintainer-only repair and merge flows require explicit commands such as @clawsweeper autofix, @clawsweeper automerge, @clawsweeper fix ci, or @clawsweeper address review.
Maintainers can comment @clawsweeper explain to ask for more context, or @clawsweeper stop to stop active automation.

Summary
The PR changes memory-core dreaming narratives to use stable workspace-and-phase session keys, timestamped idempotency keys, serialized pre/final cleanup, focused tests, and a changelog entry.

Reproducibility: yes. Source inspection of current main shows the session key includes nowMs and is reused as the idempotency key, which explains timestamp-scoped dreaming-narrative-* session accumulation without needing a new product decision.

PR rating
Overall: 🦞 diamond lobster
Proof: 🦞 diamond lobster
Patch quality: 🦞 diamond lobster
Summary: Above-average PR: the fix is focused, tested around the risky session-key behavior, and backed by sufficient real-behavior proof.

What the crustacean ranks mean

🦀 challenger crab: rare, exceptional readiness with strong proof, clean implementation, and convincing validation.
🦞 diamond lobster: very strong readiness with only minor maintainer review expected.
🐚 platinum hermit: good normal PR, likely mergeable with ordinary maintainer review.
🦐 gold shrimp: useful signal, but proof or patch confidence is still limited.
🦪 silver shellfish: thin signal; proof, validation, or implementation needs work.
🧂 unranked krab: not merge-ready because proof is missing/unusable or there are serious correctness or safety concerns.
🌊 off-meta tidepool: rating does not apply to this item.

Shiny media proof means a screenshot, video, or linked artifact directly shows the changed behavior. Runtime, network, CSP, and security claims still need visible diagnostics.

Real behavior proof
Sufficient (live_output): The linked source PR provides after-fix live output showing stable keys, timestamp idempotency, daemon health/connectivity, and successful dreaming-session cleanup.

Risk before merge

This read-only pass did not rerun the reported validation commands; exact-head required checks should remain the final merge gate.

Maintainer options:

Decide the mitigation before merge
Land this scoped memory-core fix after required exact-head checks, keeping cleanup ownership in the plugin-owned session contract rather than changing gateway semantics.
Pause or close
Do not merge this PR until maintainers decide whether the risk is worth taking.

Next step before merge
No ClawSweeper repair lane is needed; this automerge-opted PR has no actionable review findings and should continue through exact-head checks and mergeability gates.

Security
Cleared: The diff does not change workflows, dependencies, secrets, or package execution paths, and session deletion stays behind the existing plugin-owned gateway authorization check.

Review details

Best possible solution:

Land this scoped memory-core fix after required exact-head checks, keeping cleanup ownership in the plugin-owned session contract rather than changing gateway semantics.

Do we have a high-confidence way to reproduce the issue?

Yes. Source inspection of current main shows the session key includes nowMs and is reused as the idempotency key, which explains timestamp-scoped dreaming-narrative-* session accumulation without needing a new product decision.

Is this the best way to solve the issue?

Yes. The PR is the narrow maintainable fix because it changes memory-core session ownership only, preserves timestamp-specific idempotency, serializes same-key cleanup, and relies on the existing plugin-owned sessions.delete contract.

Label justifications:

P1: The PR targets memory-core dreaming session pollution and stale narrative context, which can affect real user session state and storage until fixed.
rating: 🦞 diamond lobster: Current PR rating is 🦞 diamond lobster because proof is 🦞 diamond lobster, patch quality is 🦞 diamond lobster, and Above-average PR: the fix is focused, tested around the risky session-key behavior, and backed by sufficient real-behavior proof.
status: 🚀 automerge armed: This PR is in ClawSweeper's automerge lane. Sufficient (live_output): The linked source PR provides after-fix live output showing stable keys, timestamp idempotency, daemon health/connectivity, and successful dreaming-session cleanup.
proof: sufficient: Contributor real behavior proof is sufficient. The linked source PR provides after-fix live output showing stable keys, timestamp idempotency, daemon health/connectivity, and successful dreaming-session cleanup.

What I checked:

Current-main source reproduces the old session accumulation path: Current main builds the dreaming narrative session key with nowMs and passes that same sessionKey as the idempotencyKey, so each sweep timestamp creates a distinct dreaming-narrative-* session key. (extensions/memory-core/src/dreaming-narrative.ts:212, 168f8a758e64)
PR keeps session identity stable and idempotency per run: The PR head changes idempotencyKey to include nowMs while removing nowMs from buildNarrativeSessionKey, leaving the session stable per workspace and phase. (extensions/memory-core/src/dreaming-narrative.ts:223, d519bbecac5a)
PR serializes reuse and bounds cleanup: The PR wraps narrative generation in withNarrativeSessionLock, pre-cleans stale attempt sessions before reuse, and preserves final best-effort cleanup after accepted runs. (extensions/memory-core/src/dreaming-narrative.ts:551, d519bbecac5a)
Focused tests cover the changed behavior: The PR updates expectations for stable session keys, timestamped idempotency, double cleanup, request-scoped cleanup suppression, and same-key detached narrative serialization. (extensions/memory-core/src/dreaming-narrative.test.ts:648, d519bbecac5a)
Existing gateway contract keeps deletion plugin-owned: The existing runtime dispatches plugin deleteSession through sessions.delete with plugin owner metadata, and the gateway rejects plugin-runtime deletion of sessions owned by a different plugin. (src/gateway/server-plugins.ts:532, 168f8a758e64)
Security boundary test exists for plugin-owned cleanup: Current tests assert that a memory-core plugin-runtime client cannot delete a foreign plugin session through sessions.delete. (src/gateway/server.sessions.delete-lifecycle.test.ts:88, 168f8a758e64)

Likely related people:

Peter Steinberger: Current-main blame in this checkout attributes the central dreaming narrative and plugin session cleanup lines to commit 99c8862, and shortlog shows the highest sampled recent count in these files. (role: recent area contributor; confidence: medium; commits: 99c88629c336; files: extensions/memory-core/src/dreaming-narrative.ts, extensions/memory-core/src/dreaming-phases.test.ts, src/gateway/server-plugins.ts)
Vignesh Natarajan: Commit 61e61cc added the dreaming diary surface and the central dreaming narrative/phases files that this PR changes. (role: introduced behavior; confidence: high; commits: 61e61ccc182f; files: extensions/memory-core/src/dreaming-narrative.ts, extensions/memory-core/src/dreaming-phases.ts, extensions/memory-core/src/dreaming-narrative.test.ts)
Sergiusz: Commit 079eb18 substantially hardened dreaming narrative session cleanup in the same implementation and test files. (role: cleanup-area contributor; confidence: high; commits: 079eb18bf73b; files: extensions/memory-core/src/dreaming-narrative.ts, extensions/memory-core/src/dreaming-narrative.test.ts)
Tak Hoffman: Commit 847739d repaired polluted dreaming artifacts and touched the same narrative and phase-test surfaces; the PR body also records @Takhoffman as the automerge requester. (role: adjacent owner; confidence: high; commits: 847739d82c60; files: extensions/memory-core/src/dreaming-narrative.ts, extensions/memory-core/src/dreaming-phases.test.ts)

Codex review notes: model gpt-5.5, reasoning high; reviewed against 168f8a758e64.

clawsweeper · 2026-05-21T04:22:34Z

ClawSweeper PR egg

✨ Hatched: 🥚 common Cosmic Merge Sprite

Hatch command

Comment @clawsweeper hatch when this PR is hatchable.

Hatchability rules:

Merged PRs are hatchable.
Open PRs are hatchable when they are status: 👀 ready for maintainer look, status: 🚀 automerge armed, or labeled clawsweeper:automerge.
Closed unmerged PRs are hatchable only when one of those hatchable labels is still present in the durable record.

Rarity: 🥚 common.
Trait: keeps receipts.
Image traits: location status garden; accessory review stamp; palette violet, aqua, and starlight; mood calm; pose leaning over a miniature review desk; shell glossy opal shell; lighting soft underwater shimmer; background small review tokens.
Share on X: post this hatch
Copy: My PR egg hatched a 🥚 common Cosmic Merge Sprite in ClawSweeper.

What is this egg doing here?

Eggs appear after the PR passes real-behavior proof. It is here for vibes, not verdicts: it does not change labels, ratings, merge decisions, or automation.
The shell reacts to review momentum: open follow-up work warms it up, re-review makes it wobble, and a clean final review lets it hatch.
Hatchability usually comes from sufficient real-behavior proof, no blocking P0/P1/P2 findings, no security attention needed, and clean correctness. A merged PR is already final, so merge makes the egg hatchable independently.
The hatch is seeded from this repository and PR number, so the same PR keeps the same creature; the reviewed head SHA can only change safe visual details.
Rarity is just collectible sparkle: 🥚 common, 🌱 uncommon, 💎 rare, ✨ glimmer, and 🌈 legendary.

clawsweeper · 2026-05-21T04:22:52Z

🦞✅
ClawSweeper merged this PR after the passing review.

Source: clawsweeper[bot]
Feedback: structured ClawSweeper verdict: pass (sha=d519bbecac5ae98a597a1f2c6205824ae54f7e7a)
Merge status: merged by ClawSweeper automerge
Merged at: 2026-05-21T04:45:19Z
Merge commit: 0671a2a788a6

What merged:

The PR changes memory-core dreaming narratives to use stable workspace-and-phase session keys, timestamped idempotency keys, serialized pre/final cleanup, focused tests, and a changelog entry.
Reproducibility: yes. Source inspection of current main shows the session key includes nowMs and is reused a ... plains timestamp-scoped dreaming-narrative-* session accumulation without needing a new product decision.

Automerge notes:

PR branch already contained follow-up commit before automerge: fix(memory-core): allow bounded dreaming session cleanup
PR branch already contained follow-up commit before automerge: fix(clawsweeper): address review for automerge-openclaw-openclaw-7046…

The automerge loop is complete.

Automerge progress:

2026-05-21 04:22:33 UTC review passed c752d0f75850 (structured ClawSweeper verdict: pass (sha=c752d0f758508916e6da0f39f107c0bcf0183...)

2026-05-21 04:22:52 UTC repair queued c752d0f75850 (autonomous) Run: https://github.com/openclaw/clawsweeper/actions/runs/26205269643

2026-05-21 04:27:33 UTC repair started (running) in 0s Run: https://github.com/openclaw/clawsweeper/actions/runs/26205269643 automerge-openclaw-openclaw-70464

2026-05-21 04:27:45 UTC validation plan (passed) in 12s Run: https://github.com/openclaw/clawsweeper/actions/runs/26205269643 node scripts/run-vitest.mjs extensions/memory-core/src/dreaming-narrative.test.ts extensions/memory-core/src/dreaming-phases.test.ts; pnpm exec oxfmt --check -...

2026-05-21 04:27:59 UTC Codex write preflight (passed) in 27s Run: https://github.com/openclaw/clawsweeper/actions/runs/26205269643 danger-full-access

2026-05-21 04:32:27 UTC Codex edit 1 77371134140a (complete) in 4m 55s Run: https://github.com/openclaw/clawsweeper/actions/runs/26205269643 exit 0

2026-05-21 04:37:35 UTC validation and review 1 d519bbecac5a (base moved) in 10m 3s Run: https://github.com/openclaw/clawsweeper/actions/runs/26205269643 rebased

2026-05-21 04:37:39 UTC repair completed d519bbecac5a (branch updated) in 10m 6s Run: https://github.com/openclaw/clawsweeper/actions/runs/26205269643 initial automerge rebase is delegated to Codex repair

2026-05-21 04:37:38 UTC review queued d519bbecac5a (after repair)

2026-05-21 04:45:24 UTC automerge wait d519bbecac5a (merged) in 17m 51s Run: https://github.com/openclaw/clawsweeper/actions/runs/26205269643 pull request already merged

2026-05-21 04:45:08 UTC review passed d519bbecac5a (structured ClawSweeper verdict: pass (sha=d519bbecac5ae98a597a1f2c6205824ae54f7...)

2026-05-21 04:45:22 UTC merged d519bbecac5a (merged by ClawSweeper automerge)

2026-05-21 04:45:25 UTC repair finished d519bbecac5a (pushed) in 17m 53s Run: https://github.com/openclaw/clawsweeper/actions/runs/26205269643 repair_contributor_branch

…4 (1)

) Summary: - The PR changes memory-core dreaming narratives to use stable workspace-and-phase session keys, timestamped idempotency keys, serialized pre/final cleanup, focused tests, and a changelog entry. - Reproducibility: yes. Source inspection of current main shows the session key includes nowMs and is reused a ... plains timestamp-scoped `dreaming-narrative-*` session accumulation without needing a new product decision. Automerge notes: - PR branch already contained follow-up commit before automerge: fix(memory-core): allow bounded dreaming session cleanup - PR branch already contained follow-up commit before automerge: fix(clawsweeper): address review for automerge-openclaw-openclaw-7046… Validation: - ClawSweeper review passed for head d519bbe. - Required merge gates passed before the squash merge. Prepared head SHA: d519bbe Review: openclaw#84802 (comment) Co-authored-by: chiyouYCH <[email protected]> Co-authored-by: clawsweeper <274271284+clawsweeper[bot]@users.noreply.github.com> Co-authored-by: clawsweeper[bot] <274271284+clawsweeper[bot]@users.noreply.github.com> Approved-by: takhoffman Co-authored-by: takhoffman <[email protected]>

openclaw-barnacle Bot added size: M and removed size: S labels May 21, 2026

clawsweeper Bot added rating: 🐚 platinum hermit Good normal PR readiness with ordinary maintainer review expected. status: 👀 ready for maintainer look ClawSweeper has no concrete contributor-facing blocker left for this PR. clawsweeper Tracked by ClawSweeper automation labels May 21, 2026

clawsweeper Bot mentioned this pull request May 21, 2026

fix(memory-core): allow bounded dreaming session cleanup #70464

Closed

openclaw-barnacle Bot removed the proof: supplied External PR includes structured after-fix real behavior proof. label May 21, 2026

chiyouYCH and others added 3 commits May 21, 2026 04:37

fix(memory-core): bound dreaming narrative sessions

87db694

fix(memory-core): allow bounded dreaming session cleanup

a9a4847

fix(clawsweeper): address review for automerge-openclaw-openclaw-7046…

d519bbe

…4 (1)

clawsweeper Bot force-pushed the clawsweeper/automerge-openclaw-openclaw-70464 branch from c752d0f to d519bbe Compare May 21, 2026 04:37

clawsweeper Bot merged commit 0671a2a into main May 21, 2026
92 checks passed

clawsweeper Bot deleted the clawsweeper/automerge-openclaw-openclaw-70464 branch May 21, 2026 04:45

github-actions Bot mentioned this pull request May 21, 2026

📡 Upstream Digest — 2026-05-21 07:42 UTC curtismercier/openclaw-mods#906

Open

dimonnld mentioned this pull request May 27, 2026

[Bug] memory-core dreaming: stable narrative session is archived by post-completion cleanup before host plugin can call getSessionMessages → narrative text lost #87182

Open

clawsweeper Bot mentioned this pull request May 30, 2026

Dreaming narrative sessions become orphaned — visible in sidebar but undeletable via session management #88322

Closed

vincentkoc mentioned this pull request Jun 16, 2026

fix(memory-core): silence expected operator.admin scope miss in dreaming cleanup #68020

Closed

6 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Uh oh!

fix(memory-core): allow bounded dreaming session cleanup#84802

fix(memory-core): allow bounded dreaming session cleanup#84802
clawsweeper[bot] merged 3 commits into
mainfrom
clawsweeper/automerge-openclaw-openclaw-70464

clawsweeper Bot commented May 21, 2026

Uh oh!

clawsweeper Bot commented May 21, 2026 •

edited

Loading

Uh oh!

clawsweeper Bot commented May 21, 2026

Uh oh!

clawsweeper Bot commented May 21, 2026 •

edited

Loading

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

Uh oh!

Uh oh!

Conversation

clawsweeper Bot commented May 21, 2026

Uh oh!

clawsweeper Bot commented May 21, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

clawsweeper Bot commented May 21, 2026

Hatch command

Uh oh!

clawsweeper Bot commented May 21, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

clawsweeper Bot commented May 21, 2026 •

edited

Loading

clawsweeper Bot commented May 21, 2026 •

edited

Loading