Skip to content

Revert "fix: prompt Codex to send visible channel replies"#84442

Merged
pashpashpash merged 1 commit into
mainfrom
revert-84397-fix/codex-message-tool-visible-replies
May 20, 2026
Merged

Revert "fix: prompt Codex to send visible channel replies"#84442
pashpashpash merged 1 commit into
mainfrom
revert-84397-fix/codex-message-tool-visible-replies

Conversation

@pashpashpash

Copy link
Copy Markdown
Contributor

Reverts #84397

@openclaw-barnacle openclaw-barnacle Bot added gateway Gateway runtime agents Agent runtime and tooling extensions: codex size: S maintainer Maintainer-authored PR labels May 20, 2026
@clawsweeper

clawsweeper Bot commented May 20, 2026

Copy link
Copy Markdown
Contributor

Codex review: needs real behavior proof before merge.

Workflow note: Future ClawSweeper reviews update this same comment in place.

How this review workflow works
  • ClawSweeper keeps one durable marker-backed review comment per issue or PR.
  • Re-runs edit this comment so the latest verdict, findings, and automation markers stay together instead of adding duplicate bot comments.
  • A fresh review can be triggered by eligible @clawsweeper re-review comments, exact-item GitHub events, scheduled/background review runs, or manual workflow dispatch.
  • PR/issue authors and users with repository write access can comment @clawsweeper re-review or @clawsweeper re-run on an open PR or issue to request a fresh review only.
  • Maintainers can also comment @clawsweeper review to request a fresh review only.
  • Fresh-review commands do not start repair, autofix, rebase, CI repair, or automerge.
  • Maintainer-only repair and merge flows require explicit commands such as @clawsweeper autofix, @clawsweeper automerge, @clawsweeper fix ci, or @clawsweeper address review.
  • Maintainers can comment @clawsweeper explain to ask for more context, or @clawsweeper stop to stop active automation.

Summary
This PR reverts the recently merged Codex/message prompt guidance, test expectations, prompt snapshots, and changelog entry that told message-tool-only Codex turns to use message(action="send") for visible channel replies.

Reproducibility: We have a high-confidence source-level reproduction of the patch regression: current tests and prompt snapshots require explicit message-tool delivery guidance, while the PR replaces it with generic wording. I did not run a live Telegram or Discord turn in this read-only review.

PR rating
Overall: 🧂 unranked krab
Proof: 🧂 unranked krab
Patch quality: 🧂 unranked krab
Summary: The PR reverts a current message-delivery fix, has a blocking correctness finding, and lacks real behavior proof.

Rank-up moves:

  • Keep or restore explicit message(action="send") before-ending and private-final guidance on every message-tool-only prompt surface.
  • Add redacted real transport proof, preferably a Telegram or Discord recording/log showing the visible reply path after the change.
What the crustacean ranks mean
  • 🦀 challenger crab: rare, exceptional readiness with strong proof, clean implementation, and convincing validation.
  • 🦞 diamond lobster: very strong readiness with only minor maintainer review expected.
  • 🐚 platinum hermit: good normal PR, likely mergeable with ordinary maintainer review.
  • 🦐 gold shrimp: useful signal, but proof or patch confidence is still limited.
  • 🦪 silver shellfish: thin signal; proof, validation, or implementation needs work.
  • 🧂 unranked krab: not merge-ready because proof is missing/unusable or there are serious correctness or safety concerns.
  • 🌊 off-meta tidepool: rating does not apply to this item.

Shiny media proof means a screenshot, video, or linked artifact directly shows the changed behavior. Runtime, network, CSP, and security claims still need visible diagnostics.

Real behavior proof
Needs real behavior proof before merge: No after-change real behavior proof is present; before merge, add redacted Telegram/Discord proof or live logs showing the message-tool-only visible reply path and update the PR body so ClawSweeper can re-review.

Mantis proof suggestion
A Telegram Desktop proof would directly show whether a message-tool-only Codex direct reply is visibly posted after the prompt change. A maintainer can ask Mantis to capture proof by posting a new PR comment that starts with the OpenClaw Mantis account mention, followed by:

telegram desktop proof: verify a message-tool-only Codex Telegram direct reply calls message(action="send") and appears visibly in the chat.

Risk before merge

  • Merging this would remove explicit message(action="send") before-ending and private-final guidance from message-tool-only Codex prompts, so visible channel replies can stay private again instead of being delivered to Telegram or Discord.
  • The PR has no after-change real transport proof and carries a protected maintainer label, so any intentional revert needs explicit human owner sign-off.

Maintainer options:

  1. Close unless a concrete regression is supplied (recommended)
    If there is no specific regression caused by the current prompt wording, leave current main intact and close or pause this revert.
  2. Rewrite as a narrower prompt adjustment
    If maintainers want shorter wording, keep the explicit message(action="send") before-ending contract and private-final warning, then prove the channel reply path live.

Next step before merge
Protected maintainer handling is needed because the branch is a revert of a current message-delivery fix and the safe next action is a human decision to close, pause, or request a narrower proven prompt change.

Security
Cleared: Cleared: the diff is limited to prompt text, tests, snapshots, and changelog content, with no dependency, workflow, credential, or code-execution surface changes.

Review findings

  • [P1] Keep the explicit message-tool delivery instruction — extensions/codex/src/app-server/thread-lifecycle.ts:887
Review details

Best possible solution:

Keep the current explicit delivery contract from #84397; if a prompt wording regression exists, replace it with narrower wording that still preserves the before-ending message(action="send") requirement and private-final semantics.

Do we have a high-confidence way to reproduce the issue?

We have a high-confidence source-level reproduction of the patch regression: current tests and prompt snapshots require explicit message-tool delivery guidance, while the PR replaces it with generic wording. I did not run a live Telegram or Discord turn in this read-only review.

Is this the best way to solve the issue?

No. Reverting the current fix is not the best solution because it removes the explicit prompt contract that keeps message-tool-only Codex replies visible; a narrower, live-proven wording adjustment would be safer if a maintainer wants different copy.

Label changes:

  • add P1: The PR would regress an agent/channel reply path where visible user-facing messages can remain private instead of being delivered.
  • add merge-risk: 🚨 message-delivery: The diff removes the prompt contract that tells Codex how to visibly send replies when automatic source delivery is suppressed.
  • add rating: 🧂 unranked krab: Current PR rating is 🧂 unranked krab because proof is 🧂 unranked krab, patch quality is 🧂 unranked krab, and The PR reverts a current message-delivery fix, has a blocking correctness finding, and lacks real behavior proof.
  • add status: 📣 needs proof: The PR needs real behavior proof before ClawSweeper can clear the contributor ask. Needs real behavior proof before merge: No after-change real behavior proof is present; before merge, add redacted Telegram/Discord proof or live logs showing the message-tool-only visible reply path and update the PR body so ClawSweeper can re-review.
  • add mantis: telegram-visible-proof: Mantis should capture Telegram visible proof. This touches Telegram message-tool-only prompt snapshots and visible reply behavior that a short Telegram Desktop proof can demonstrate.

Label justifications:

  • P1: The PR would regress an agent/channel reply path where visible user-facing messages can remain private instead of being delivered.
  • merge-risk: 🚨 message-delivery: The diff removes the prompt contract that tells Codex how to visibly send replies when automatic source delivery is suppressed.
  • rating: 🧂 unranked krab: Current PR rating is 🧂 unranked krab because proof is 🧂 unranked krab, patch quality is 🧂 unranked krab, and The PR reverts a current message-delivery fix, has a blocking correctness finding, and lacks real behavior proof.
  • status: 📣 needs proof: The PR needs real behavior proof before ClawSweeper can clear the contributor ask. Needs real behavior proof before merge: No after-change real behavior proof is present; before merge, add redacted Telegram/Discord proof or live logs showing the message-tool-only visible reply path and update the PR body so ClawSweeper can re-review.
  • mantis: telegram-visible-proof: Mantis should capture Telegram visible proof. This touches Telegram message-tool-only prompt snapshots and visible reply behavior that a short Telegram Desktop proof can demonstrate.

Full review comments:

  • [P1] Keep the explicit message-tool delivery instruction — extensions/codex/src/app-server/thread-lifecycle.ts:887
    This replaces the message-tool-only Codex guidance with a generic use the message tool sentence. In this mode automatic source delivery is suppressed and normal final text is private, so dropping the action="send" before-ending instruction reintroduces the hidden-reply path that the reverted fix and changelog tie to direct replies staying private.
    Confidence: 0.93

Overall correctness: patch is incorrect
Overall confidence: 0.91

What I checked:

Likely related people:

  • Josh Avant: git blame shows the explicit message-tool-only delivery guidance in the Codex prompt, message tool description, inbound metadata, and group/direct prompt text came from the merged fix commit for fix: prompt Codex to send visible channel replies #84397. (role: introduced current fix; confidence: high; commits: 47eb4ca14fcc; files: extensions/codex/src/app-server/thread-lifecycle.ts, src/agents/tools/message-tool.ts, src/auto-reply/reply/inbound-meta.ts)
  • Dallin Romney: The shallow current history shows the surrounding message-tool-only prompt and tool-description scaffolding in the grafted baseline commit, so this is a relevant adjacent history signal rather than sole ownership. (role: earlier area contributor; confidence: medium; commits: 3d96111a5a; files: extensions/codex/src/app-server/thread-lifecycle.ts, src/agents/tools/message-tool.ts, src/auto-reply/reply/groups.ts)
  • pash-openai: git blame shows adjacent buildVisibleReplyInstruction structure in thread-lifecycle.ts came from the recent Codex developer-instruction move, so this person is relevant for Codex prompt-layer routing beyond the PR branch itself. (role: recent adjacent Codex prompt contributor; confidence: medium; commits: e0d1a2a9b9; files: extensions/codex/src/app-server/thread-lifecycle.ts)

Codex review notes: model gpt-5.5, reasoning high; reviewed against 5c39e0019d2f.

@clawsweeper clawsweeper Bot added rating: 🧂 unranked krab Not merge-ready due to missing proof or serious correctness/safety concerns. status: 📣 needs proof The PR needs real behavior proof before ClawSweeper can clear the contributor ask. mantis: telegram-visible-proof Mantis should capture Telegram visible proof. P1 High-priority user-facing bug, regression, or broken workflow. merge-risk: 🚨 message-delivery 🚨 May drop, duplicate, misroute, suppress, or wrongly target messages. labels May 20, 2026
@clawsweeper

clawsweeper Bot commented May 20, 2026

Copy link
Copy Markdown
Contributor

ClawSweeper PR egg

🎁 Pass real behavior proof to wake the egg and unlock a hatchable treat.

Where did the egg go?
  • The egg game starts only after the PR passes the real-behavior proof check.
  • Before that, no creature or rarity is rolled. The treat waits for real proof.
  • This is still just collectible flavor: proof affects review readiness, not creature quality.

@pashpashpash
pashpashpash merged commit 448eb36 into main May 20, 2026
170 of 181 checks passed
@pashpashpash
pashpashpash deleted the revert-84397-fix/codex-message-tool-visible-replies branch May 20, 2026 05:20
SebTardif pushed a commit to SebTardif/openclaw that referenced this pull request May 24, 2026
SebTardif pushed a commit to SebTardif/openclaw that referenced this pull request May 24, 2026
SebTardif pushed a commit to SebTardif/openclaw that referenced this pull request May 24, 2026
github-actions Bot pushed a commit to Desicool/openclaw that referenced this pull request May 24, 2026
galiniliev pushed a commit to galiniliev/openclaw that referenced this pull request May 25, 2026
SebTardif pushed a commit to SebTardif/openclaw that referenced this pull request May 26, 2026
SebTardif pushed a commit to SebTardif/openclaw that referenced this pull request May 26, 2026
SebTardif pushed a commit to SebTardif/openclaw that referenced this pull request May 26, 2026
jameslcowan pushed a commit to jameslcowan/openclaw that referenced this pull request Jun 2, 2026
SYU8384 pushed a commit to SYU8384/openclaw that referenced this pull request Jun 3, 2026
sablehead pushed a commit to sablehead/openclaw that referenced this pull request Jun 10, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

agents Agent runtime and tooling extensions: codex gateway Gateway runtime maintainer Maintainer-authored PR mantis: telegram-visible-proof Mantis should capture Telegram visible proof. merge-risk: 🚨 message-delivery 🚨 May drop, duplicate, misroute, suppress, or wrongly target messages. P1 High-priority user-facing bug, regression, or broken workflow. rating: 🧂 unranked krab Not merge-ready due to missing proof or serious correctness/safety concerns. size: S status: 📣 needs proof The PR needs real behavior proof before ClawSweeper can clear the contributor ask.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant