Revert "fix: prompt Codex to send visible channel replies"#84442
Conversation
This reverts commit 47eb4ca.
|
Codex review: needs real behavior proof before merge. Workflow note: Future ClawSweeper reviews update this same comment in place. How this review workflow works
Summary Reproducibility: We have a high-confidence source-level reproduction of the patch regression: current tests and prompt snapshots require explicit message-tool delivery guidance, while the PR replaces it with generic wording. I did not run a live Telegram or Discord turn in this read-only review. PR rating Rank-up moves:
What the crustacean ranks mean
Shiny media proof means a screenshot, video, or linked artifact directly shows the changed behavior. Runtime, network, CSP, and security claims still need visible diagnostics. Real behavior proof Mantis proof suggestion Risk before merge
Maintainer options:
Next step before merge Security Review findings
Review detailsBest possible solution: Keep the current explicit delivery contract from #84397; if a prompt wording regression exists, replace it with narrower wording that still preserves the before-ending Do we have a high-confidence way to reproduce the issue? We have a high-confidence source-level reproduction of the patch regression: current tests and prompt snapshots require explicit message-tool delivery guidance, while the PR replaces it with generic wording. I did not run a live Telegram or Discord turn in this read-only review. Is this the best way to solve the issue? No. Reverting the current fix is not the best solution because it removes the explicit prompt contract that keeps message-tool-only Codex replies visible; a narrower, live-proven wording adjustment would be safer if a maintainer wants different copy. Label changes:
Label justifications:
Full review comments:
Overall correctness: patch is incorrect What I checked:
Likely related people:
Codex review notes: model gpt-5.5, reasoning high; reviewed against 5c39e0019d2f. |
|
ClawSweeper PR egg 🎁 Pass real behavior proof to wake the egg and unlock a hatchable treat. Where did the egg go?
|
…4397)" (openclaw#84442) This reverts commit 47eb4ca.
…4397)" (openclaw#84442) This reverts commit 47eb4ca.
…4397)" (openclaw#84442) This reverts commit 47eb4ca.
…4397)" (openclaw#84442) This reverts commit e21e7dd.
…4397)" (openclaw#84442) This reverts commit 47eb4ca.
…4397)" (openclaw#84442) This reverts commit 47eb4ca.
…4397)" (openclaw#84442) This reverts commit 47eb4ca.
…4397)" (openclaw#84442) This reverts commit 47eb4ca.
…4397)" (openclaw#84442) This reverts commit 31c0bb1.
…4397)" (openclaw#84442) This reverts commit 47eb4ca.
…4397)" (openclaw#84442) This reverts commit ff79a51.
Reverts #84397