fix(messages): apply TTS before message-tool sends#83543
Merged
Conversation
Contributor
|
ClawSweeper status: review started. I am starting a fresh review of this pull request: fix(messages): apply TTS before message-tool sends This is item 1/1 in the current shard. Shard 0/1. This placeholder means the worker is alive and reading the current context. I will edit this same comment with the actual review when the claws are done clicking. Crustacean status: shell secured, claws on keyboard, evidence pebbles being sorted. |
steipete
force-pushed
the
codex/fix-message-tool-tts-81598
branch
from
May 18, 2026 09:46
394ebed to
c9ce387
Compare
steipete
added
the
proof: override
galiniliev
pushed a commit
to galiniliev/openclaw
that referenced
this pull request
May 20, 2026
SebTardif
pushed a commit
to SebTardif/openclaw
that referenced
this pull request
May 24, 2026
SebTardif
pushed a commit
to SebTardif/openclaw
that referenced
this pull request
May 24, 2026
SebTardif
pushed a commit
to SebTardif/openclaw
that referenced
this pull request
May 24, 2026
github-actions Bot
pushed a commit
to Desicool/openclaw
that referenced
this pull request
May 24, 2026
galiniliev
pushed a commit
to galiniliev/openclaw
that referenced
this pull request
May 25, 2026
SebTardif
pushed a commit
to SebTardif/openclaw
that referenced
this pull request
May 26, 2026
SebTardif
pushed a commit
to SebTardif/openclaw
that referenced
this pull request
May 26, 2026
SebTardif
pushed a commit
to SebTardif/openclaw
that referenced
this pull request
May 26, 2026
jameslcowan
pushed a commit
to jameslcowan/openclaw
that referenced
this pull request
Jun 2, 2026
SYU8384
pushed a commit
to SYU8384/openclaw
that referenced
this pull request
Jun 3, 2026
sablehead
pushed a commit
to sablehead/openclaw
that referenced
this pull request
Jun 10, 2026
21 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
message_toolsends leave the runner, covering core outbound delivery, gateway plugin sends, and local plugin fallback sends.Fixes #81598.
Verification
node scripts/run-vitest.mjs src/infra/outbound/message-action-runner.core-send.test.ts src/infra/outbound/message-action-runner.plugin-dispatch.test.tspnpm buildpnpm check:changedvia Blacksmith Testboxtbx_01krx6y3mdxxgxg8khc4eybqfb/ https://github.com/openclaw/openclaw/actions/runs/26025333280.agents/skills/autoreview/scripts/autoreview --mode local(clean; helper used fallback reviewer after current Codex CLI rejected its legacy--uncommitted -invocation)git diff --checkReal behavior proof
Behavior addressed: message-tool sends now synthesize tagged TTS content before dispatch, so
[[tts:text]]...[[/tts:text]]becomes an outbound voice attachment instead of raw tag text in proactive/group-room sends.Real environment tested: source-level proof accepted by maintainer for this issue because the bug is the runner ordering boundary before core/gateway/plugin dispatch.
Exact steps or command run after this patch: targeted Vitest files, production build, changed-gate Testbox run, autoreview, and diff whitespace check listed above.
Evidence after fix: regression output shows 2 files / 24 tests passed after rebase; the tests assert
kind: "final"TTS application before core outbound delivery, gateway plugin dispatch, and local plugin fallback dispatch.Observed result after fix: all listed checks passed;
check:changedexited 0 in Testbox and current-basepnpm buildpassed.What was not tested: no live Discord/Telegram voice-note send; maintainer accepted source-level proof and this PR carries
proof: override.