fix: keep ACP turns on OpenClaw timeouts#82997
Conversation
|
Codex review: needs real behavior proof before merge. Summary Reproducibility: yes. from source inspection: acpx 0.7.0 applies Real behavior proof Next step before merge Security Review findings
Review detailsBest possible solution: Apply the no-prompt-timeout override to the Do we have a high-confidence way to reproduce the issue? Yes from source inspection: acpx 0.7.0 applies Is this the best way to solve the issue? No: changing only Full review comments:
Overall correctness: patch is incorrect Acceptance criteria:
What I checked:
Likely related people:
Remaining risk / open question:
Codex review notes: model gpt-5.5, reasoning high; reviewed against 327b0b8734d5. |
dbd3eed to
0080f39
Compare
|
Rebased onto current Verification after rebase:
Codex review also reran GitHub status: no required checks reported for this branch at merge time; newly queued non-required checks were still in progress. |
Summary
Fixes #79522
Verification
Behavior addressed: ACP/Codex background runs no longer let acpx synthesize a completed turn from partial progress after its adapter timeout.
Real environment tested: local OpenClaw checkout with acpx 0.7.0 package behavior inspected and focused Vitest coverage.
Exact steps or command run after this patch: focused runtime/service/manager Vitest commands above plus Codex review, format check, and diff check.
Evidence after fix: runtime wrapper passes timeoutMs 0 to delegate runTurn while service still passes constructor timeoutMs for non-turn runtime operations; manager partial-progress timeout test records ACP_TURN_FAILED instead of success.
Observed result after fix: all focused tests passed; Codex review reported no actionable regressions.
What was not tested: no live Codex ACP adapter run against a real long-running prompt in this PR.