feat(telegram): add progress assistant preview lane#82303
Conversation
|
Codex review: needs real behavior proof before merge. Reviewed June 20, 2026, 6:11 PM ET / 22:11 UTC. Summary PR surface: Source +56, Tests +62, Docs +18, Generated 0. Total +136 across 12 files. Reproducibility: not applicable. this is a feature PR rather than a bug report. Current-main source confirms the baseline behavior that Telegram progress mode drops answer-lane partials. Review metrics: 1 noteworthy metric.
Stored data model Merge readiness Overall follows the weaker of proof and patch quality, so missing proof can cap an otherwise strong patch. Rank-up moves:
Proof guidance:
Mantis proof suggestion Risk before merge
Maintainer options:
Next step before merge
Security Review detailsBest possible solution: Refresh the branch, keep the Telegram-only default-off shape only if maintainers accept the config surface, and merge after real Telegram proof shows the progress draft, assistant preview updates, preview cleanup, and final answer ordering. Do we have a high-confidence way to reproduce the issue? Not applicable; this is a feature PR rather than a bug report. Current-main source confirms the baseline behavior that Telegram progress mode drops answer-lane partials. Is this the best way to solve the issue? Yes on the proposed implementation shape, but not merge-ready. The patch is Telegram-scoped and default-off, while the clean merge result, real Telegram behavior, and product acceptance remain unresolved. AGENTS.md: found and applied where relevant. Codex review notes: model internal, reasoning high; reviewed against f18ff7551edc. Label changesLabel justifications:
Evidence reviewedPR surface: Source +56, Tests +62, Docs +18, Generated 0. Total +136 across 12 files. View PR surface stats
What I checked:
Likely related people:
What the crustacean ranks mean
Shiny media proof means a screenshot, video, or linked artifact directly shows the changed behavior. Runtime, network, CSP, and security claims still need visible diagnostics. How this review workflow works
|
This comment was marked as spam.
This comment was marked as spam.
|
@openclaw-mantis verify this PR on Telegram Desktop. Please generate before/after GIF evidence for the Telegram progress assistant preview lane. Use a slow reply that includes visible tool/status/progress updates and assistant answer partials. The proof should make main show only the existing progress/status lane while assistant partial text is absent, and this PR should show the new separate assistant preview lane updating while the progress lane remains visible. |
6e5a817 to
3ddc9d4
Compare
|
Update after review/CI refresh:
Local verification on the rebased branch:
|
3ddc9d4 to
ff8fd8b
Compare
ff8fd8b to
54b6236
Compare
|
Update after rebase onto current
Local verification on commit
GitHub proof/checks after push:
@clawsweeper re-review |
|
🦞🧹 I asked ClawSweeper to review this item again. Re-review progress:
|
|
Update after addressing the latest ClawSweeper review:
Local verification on commit
GitHub status after push:
Known remaining proof gap:
@clawsweeper re-review |
|
🦞🧹 I asked ClawSweeper to review this item again. Re-review progress:
|
a350460 to
1692fc3
Compare
|
Update after rebase onto current
Local verification:
Local note:
Early GitHub checks after push:
@clawsweeper re-review |
|
🦞🧹 I asked ClawSweeper to review this item again. Re-review progress:
|
1692fc3 to
48c33c3
Compare
|
@openclaw-mantis telegram desktop proof: with streaming.progress.assistantPreview=true, show the progress draft and separate assistant preview updating, then the preview clearing before final answer delivery. Please capture redacted visible Telegram Desktop or equivalent bot-to-bot live output proof for PR head 48c33c3. |
|
Update after addressing latest blockers:
Local verification on
Visible proof follow-up:
@clawsweeper re-review |
|
🦞🧹 I asked ClawSweeper to review this item again. Re-review progress:
|
|
Thanks for the implementation and tests. We are going to close this because the intended UX is already covered by the existing Telegram streaming modes: Appreciate the contribution. |
Summary
streaming.progress.assistantPreviewto enable assistant partial previews while staying inmode: "progress"Real behavior proof
mode: "progress"already shows the useful live tool/status/progress draft, but it drops assistant/Nexus-style answer partials. Switching toblock/partialis not acceptable because it replaces the existing progress-live behavior. This patch adds an opt-in second assistant preview lane for answer partials while leaving progress mode intact./Users/thomas/.openclaw/workspace/projects/openclaw-upstream/openclaw-telegram-dual-liveon branchfeat/telegram-progress-assistant-lane.Supplemental local verification:
progressmode unchanged by default (assistantPreview=false) and enables the new additive assistant preview only whenstreaming.progress.assistantPreview=true. The Telegram dispatch test covers the actual lane split: progress/tool updates remain on the progress draft and assistant partials update the separate assistant lane.Testing
npx pnpm config:channels:checknpx pnpm vitest run src/plugin-sdk/channel-streaming.test.ts extensions/telegram/src/bot-message-dispatch.test.ts extensions/telegram/src/lane-delivery.test.ts extensions/telegram/src/bot.helpers.test.tsnpx pnpm check:changedNotes
off,partial,block, andprogresssemantics stay unchanged by default.streaming.progress.assistantPreview: true.