Fix allowTailscale bypass for token auth in Serve mode#823
Merged
steipete merged 2 commits intoJan 13, 2026
Conversation
Contributor
|
Thanks Roshan! |
steipete
force-pushed
the
fix/820-tailscale-allow-token
branch
from
January 13, 2026 04:39
98ec8e1 to
b70298f
Compare
Contributor
|
Landed via temp rebase onto main.\n\n- Gate: pnpm lint && pnpm build && pnpm test\n- Land commit: b70298f\n- Merge commit: 8a9096c\n\nThanks @roshanasingh4! |
Contributor
|
Gate note: pnpm lint failed before build/test due to existing lint issues (src/commands/auth-choice.ts unused import MINIMAX_HOSTED_MODEL_REF; src/agents/pi-embedded-helpers.test.ts formatting). Build/test not run. |
victorarias
pushed a commit
to victorarias/clawdbot
that referenced
this pull request
Jan 13, 2026
lovewanwan
pushed a commit
to lovewanwan/openclaw
that referenced
this pull request
Apr 28, 2026
lovewanwan
pushed a commit
to lovewanwan/openclaw
that referenced
this pull request
Apr 28, 2026
…allow-token Fix allowTailscale bypass for token auth in Serve mode
5 tasks
github-actions Bot
pushed a commit
to Desicool/openclaw
that referenced
this pull request
May 9, 2026
github-actions Bot
pushed a commit
to Desicool/openclaw
that referenced
this pull request
May 9, 2026
…allow-token Fix allowTailscale bypass for token auth in Serve mode
This was referenced May 18, 2026
This was referenced Jul 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #820.
Problem:
gateway.auth.allowTailscalewas computed and logged astrue, butauthorizeGatewayConnect()enforcedtoken_missing/password_missingbefore checking Tailscale identity headers. In Tailscale Serve mode this prevents tailnet clients from authenticating viatailscale-user-*headers as documented.Solution: accept valid Tailscale Serve proxy requests (loopback + required
x-forwarded-*headers +tailscale-user-login) asmethod: tailscalebefore falling back to token/password checks. Keep the stricter behavior forauth.mode: none(tailscale required unless local-direct).Adds a regression test covering token-mode + allowTailscale + valid Serve headers.