feat(codex): bind CLI sessions from nodes#81747
Conversation
|
Codex review: needs maintainer review before merge. Summary Reproducibility: not applicable. as a feature PR rather than a bug report. The after-fix path is evidenced by PR-body Crabbox proof for real node-host list/resume behavior plus source inspection of the command routing. Real behavior proof Next step before merge Security Review detailsBest possible solution: Have maintainers review the dangerous node-command policy and Do we have a high-confidence way to reproduce the issue? Not applicable as a feature PR rather than a bug report. The after-fix path is evidenced by PR-body Crabbox proof for real node-host list/resume behavior plus source inspection of the command routing. Is this the best way to solve the issue? Unclear pending maintainer policy review: the implementation follows existing plugin node-host APIs and now uses the established Windows spawn helper, but accepting a dangerous node resume command and the binding UX is a product/security decision. What I checked:
Likely related people:
Remaining risk / open question:
Codex review notes: model gpt-5.5, reasoning high; reviewed against 66b98b72946f. |
aae2a2e to
3595cd3
Compare
3595cd3 to
d0406ac
Compare
|
Merged via pinned squash merge at a5c1956 after rebasing onto current main. Focused verification stayed green: formatter on touched files, temp-boundary lint, bundled extension oxlint, 96 Codex tests, extension typecheck, diff whitespace, plus AWS Crabbox proof run_a901a61e006f. No open duplicate PRs/issues found in the targeted Codex CLI session resume search. |
Summary
/codex sessions --host <node>and/codex resume <session-id> --host <node> --bind herefor binding a chat to an existing CLI sessioncodex exec resumeon the selected node, with docs and changelog coverageReal behavior proof
run_a901a61e006font3.large, OpenClaw2026.5.12-beta.6, realcodex-cli 0.130.0auth/session.codex.cli.sessions.listfollowed bycodex.cli.session.resume.PROOF_OK session=019e258d-bf7b-7ce1-bbb0-457ba23fa623after the resume handler returned the expected token.codex exec resume.Verification
pnpm exec oxfmt --check --threads=1 CHANGELOG.md docs/plugins/codex-harness.md extensions/codex/index.ts extensions/codex/src/command-formatters.ts extensions/codex/src/command-handlers.ts extensions/codex/src/commands.test.ts extensions/codex/src/conversation-binding-data.ts extensions/codex/src/conversation-binding.test.ts extensions/codex/src/conversation-binding.ts extensions/codex/src/node-cli-sessions.ts extensions/codex/src/node-cli-sessions.test.tspnpm run lint:tmp:no-random-messagingpnpm run lint:extensions:bundledOPENCLAW_VITEST_MAX_WORKERS=4 pnpm test extensions/codex/src/node-cli-sessions.test.ts extensions/codex/src/conversation-binding.test.ts extensions/codex/src/commands.test.ts(96 tests, including Windows.cmdCodex shim resolution)pnpm tsgo:extensionsgit diff --checkRelease branch
Validated the focused proof against
origin/release/2026.5.12before rebasing this PR ontomain. If this should ship in the current release line, the rebased commit to discuss for backport is27c9564081 feat(codex): bind CLI sessions from nodes.Maintainer discussion flags
Touches node command policy and Codex slash-command behavior; maintainer approved merge in chat.