Fix stale Control UI run status cleanup#81615
Conversation
|
Codex review: needs changes before merge. Summary Reproducibility: yes. at source level. With Real behavior proof Next step before merge Security Review findings
Review detailsBest possible solution: Finish the shared lifecycle approach by reconciling local run state on terminal Do we have a high-confidence way to reproduce the issue? Yes, at source level. With Is this the best way to solve the issue? No, not yet. The shared cleanup helper is the right direction, but the incremental terminal session-update path must also reconcile local Full review comments:
Overall correctness: patch is incorrect Acceptance criteria:
What I checked:
Likely related people:
Remaining risk / open question:
Codex review notes: model gpt-5.5, reasoning high; reviewed against 78eb92e62277. Re-review progress:
|
Summary
hasActiveRunstate when a run is done or interruptedFixes #76874.
Fixes #64220.
Refs #71630.
Verification
git diff --checkPATH=/Users/buns/.nvm/versions/node/v24.13.0/bin:$PATH pnpm exec oxfmt --check --threads=1 CHANGELOG.md ui/src/styles/chat/layout.css ui/src/ui/app-chat.ts ui/src/ui/app-gateway.node.test.ts ui/src/ui/app-gateway.ts ui/src/ui/app-render.helpers.ts ui/src/ui/app-render.ts ui/src/ui/app-tool-stream.node.test.ts ui/src/ui/app-tool-stream.ts ui/src/ui/app-view-state.ts ui/src/ui/app.ts ui/src/ui/chat/run-controls.test.ts ui/src/ui/chat/run-lifecycle.ts ui/src/ui/chat/status-indicators.ts ui/src/ui/controllers/chat.test.ts ui/src/ui/controllers/chat.ts ui/src/ui/controllers/sessions.test.ts ui/src/ui/controllers/sessions.ts ui/src/ui/views/chat.tsPATH=/Users/buns/.nvm/versions/node/v24.13.0/bin:$PATH pnpm test ui/src/ui/app-tool-stream.node.test.ts ui/src/ui/app-gateway.node.test.ts ui/src/ui/controllers/chat.test.ts ui/src/ui/controllers/sessions.test.ts ui/src/ui/app-chat.test.ts ui/src/ui/chat/run-controls.test.tsIn progress; completed simulated state showed Send +Done