Skip to content

fix(qqbot): support QQBOT_DATA_DIR environment variable#80248

Closed
KhanCold wants to merge 4 commits into
openclaw:mainfrom
KhanCold:fix/39461-qqbot-data-dir
Closed

fix(qqbot): support QQBOT_DATA_DIR environment variable#80248
KhanCold wants to merge 4 commits into
openclaw:mainfrom
KhanCold:fix/39461-qqbot-data-dir

Conversation

@KhanCold

@KhanCold KhanCold commented May 10, 2026

Copy link
Copy Markdown
Contributor

Summary

Respects QQBOT_DATA_DIR environment variable for QQBot data and media paths, with fallback to ~/.openclaw/qqbot.

Changes

  • Added getQQBotDataBaseDir() helper that checks process.env.QQBOT_DATA_DIR
  • Updated getQQBotDataPath(), getQQBotDataDir(), getQQBotMediaPath(), getQQBotMediaDir() to use the new helper
  • Uses normalizePath() for tilde expansion and path normalization
  • Updated JSDoc comments

Edge Cases Handled

  • QQBOT_DATA_DIR not set → falls back to ~/.openclaw/qqbot
  • QQBOT_DATA_DIR contains ~ → expanded via normalizePath()
  • QQBOT_DATA_DIR contains trailing slash → normalized via path.join()
  • Empty string QQBOT_DATA_DIR → treated as unset (falsy check)

Test Plan

  • Verify getQQBotDataDir() returns custom path when env var set
  • Verify fallback to ~/.openclaw/qqbot when env var unset
  • Verify subpaths work correctly with custom base dir

Fixes #39461

KhanCold added 2 commits May 10, 2026 00:50
@KhanCold
fix(active-memory): change status from 'empty' to 'no_relevant_memory…
f40184f 
…' for normal no-memory cases
@KhanCold
fix(qqbot): support QQBOT_DATA_DIR environment variable for custom da…
5dad3c6 
…ta directory

Respects QQBOT_DATA_DIR env var for QQBot data and media paths, falling back to ~/.openclaw/qqbot.

Fixes openclaw#39461
@openclaw-barnacle openclaw-barnacle Bot added size: XS triage: needs-real-behavior-proof Candidate: external PR needs after-fix proof from a real setup. labels May 10, 2026
KhanCold added 2 commits May 10, 2026 20:21
@KhanCold
fix(qqbot): support QQBOT_DATA_DIR environment variable for custom da…
2440d74 
…ta directory

Respects QQBOT_DATA_DIR env var for QQBot data and media paths, falling back to ~/.openclaw/qqbot.

Fixes openclaw#39461
@KhanCold
fix(qqbot): support QQBOT_DATA_DIR environment variable for custom da…
f8b8730 
…ta directory

Respects QQBOT_DATA_DIR env var for QQBot data and media paths, falling back to ~/.openclaw/qqbot.

Fixes openclaw#39461
@clawsweeper

clawsweeper Bot commented May 10, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

Thanks for the context here. I swept through the related work, and this is now duplicate or superseded.

Close as duplicate/superseded: this branch does not implement the stated QQBot data-dir fix, only carries an unrelated Active Memory hunk that is already on current main, while the actual QQBOT_DATA_DIR work is tracked in an open canonical PR.

So I’m closing this here and keeping the remaining discussion on the canonical linked item.

Review details

Best possible solution:

Keep this wrong branch closed and review a corrected QQBot-owned helper fix through #78253 or an equivalent replacement.

Do we have a high-confidence way to reproduce the issue?

Yes. Source inspection gives a high-confidence path: set QQBOT_DATA_DIR, then current-main QQBot data helpers still resolve under getHomeDir()/.openclaw/qqbot.

Is this the best way to solve the issue?

No. Centralizing the override in the QQBot helper is the right direction, but this PR does not touch QQBot and is superseded by the open canonical QQBot PR.

Security review:

Security review cleared: The submitted diff only changes an Active Memory status string and does not alter dependencies, workflows, secrets handling, or storage permissions.

What I checked:

  • Submitted diff is not QQBot: The PR files API shows exactly one changed file, extensions/active-memory/index.ts, adding no_relevant_memory to ActiveRecallResult and returning that status; it does not touch extensions/qqbot or any QQBot data-path helper. (extensions/active-memory/index.ts:2814, f8b8730350da)
  • Current main still has the QQBot bug: Current main's getQQBotDataPath still joins getHomeDir(), .openclaw, and qqbot directly, so QQBOT_DATA_DIR is not honored in the affected helper. (extensions/qqbot/src/engine/utils/platform.ts:43, afe26f51a3f8)
  • Canonical open PR tracks the stated fix: fix(qqbot): support QQBOT_DATA_DIR environment variable #78253 is open with the same QQBOT_DATA_DIR title and changes extensions/qqbot/src/engine/utils/platform.ts, platform tests, and QQBot docs. (extensions/qqbot/src/engine/utils/platform.ts:43, cb6be91e4f74)
  • Search confirms the duplicate cluster: GitHub search for QQBOT_DATA_DIR returned this PR, the open canonical PR, the linked bug, and two closed earlier attempts; no merged PR currently resolves the QQBot env-var bug.
  • Actual Active Memory hunk is already on main: Current main already contains status no_relevant_memory in Active Memory, and repository commit history for that path shows eda0316 classified the no-relevant status before this PR. (extensions/active-memory/index.ts:2814, eda0316af3e6)
  • Real behavior proof is absent: The PR body has an unchecked test plan and the PR issue/review comments contain no contributor-owned terminal output, logs, screenshots, recordings, or linked artifacts showing QQBot after-fix behavior. (f8b8730350da)

Likely related people:

  • steipete: Path history shows recent work on QQBot helper/storage surfaces and the current Active Memory no-relevant status implementation that overlaps the submitted hunk. (role: recent QQBot helper and Active Memory contributor; confidence: high; commits: a607661a71d8, 0ce0509856d9, eda0316af3e6; files: extensions/qqbot/src/engine/utils/platform.ts, extensions/qqbot/src/engine/utils/diagnostics.ts, extensions/active-memory/index.ts)
  • vincentkoc: GitHub path history shows recent commits touching the QQBot platform helper and diagnostics-adjacent engine utility area. (role: recent adjacent QQBot utility contributor; confidence: medium; commits: 3c8de6eb7243, 85520f664d02; files: extensions/qqbot/src/engine/utils/platform.ts, extensions/qqbot/src/engine/utils/diagnostics.ts)
  • cxyhhhhh: The affected QQBot engine utility, diagnostics, and storage-path surfaces trace back to the self-contained QQBot engine architecture extraction. (role: introduced broader QQBot engine architecture; confidence: medium; commits: 5e72e39c1852; files: extensions/qqbot/src/engine/utils/platform.ts, extensions/qqbot/src/engine/utils/diagnostics.ts, extensions/qqbot/src/engine/utils/data-paths.ts)

Codex review notes: model gpt-5.5, reasoning high; reviewed against afe26f51a3f8.

@clawsweeper clawsweeper Bot closed this May 10, 2026
@KhanCold
KhanCold deleted the fix/39461-qqbot-data-dir branch May 10, 2026 12:45
This was referenced Jun 16, 2026
Open
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

size: XS triage: needs-real-behavior-proof Candidate: external PR needs after-fix proof from a real setup.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[Bug]：路径错误

1 participant

@KhanCold