[codex] Fix npm-installed skill CLI PATH detection#80233
Conversation
|
Codex review: needs real behavior proof before merge. Summary Reproducibility: no. not as a high-confidence live reproduction. Source inspection shows the current gateway status path scans Real behavior proof Next step before merge Security Review detailsBest possible solution: Land a narrow PATH-bootstrap fix after redacted real gateway/Skills proof shows npm-global Do we have a high-confidence way to reproduce the issue? No, not as a high-confidence live reproduction. Source inspection shows the current gateway status path scans Is this the best way to solve the issue? Yes, the PR's narrow bootstrap change is the right layer because the UI is reporting backend Skills status. It still needs real behavior proof before merge. Acceptance criteria:
What I checked:
Likely related people:
Remaining risk / open question:
Codex review notes: model gpt-5.5, reasoning high; reviewed against 0451a9fb312c. |
Summary
NPM_CONFIG_PREFIX, lowercasenpm_config_prefix, user.npmrcprefix, OpenClaw-managed npm tool installs, and~/.npm-global/bin.Root cause
requires.binsthrough the gateway process PATH, while npm-installed skill CLIs can live in npm global prefix directories that were not included by the gateway's minimal PATH bootstrap.Verification
pnpm test src/infra/path-env.test.ts -- --reporter=verbosepnpm test src/agents/skills.buildworkspaceskillstatus.test.ts -- --reporter=verbosegit diff --checkpnpm check:changedFixes #80206