fix: explain missing provider model registration#80098
Conversation
|
Codex review: needs real behavior proof before merge. Summary Reproducibility: yes. The linked issue gives a concrete config and CLI sequence, and current source inspection shows the same path falls through to the generic Real behavior proof Next step before merge Security Review detailsBest possible solution: Land the narrow resolver diagnostic with regression coverage once real behavior proof shows the reported one-block provider setup now points operators to the missing provider model registration. Do we have a high-confidence way to reproduce the issue? Yes. The linked issue gives a concrete config and CLI sequence, and current source inspection shows the same path falls through to the generic Is this the best way to solve the issue? Yes. A targeted diagnostic in the model-resolution error path is narrower and safer than auto-mirroring config, and it matches the existing split between allowlist/default params and provider registration. What I checked:
Likely related people:
Remaining risk / open question:
Codex review notes: model gpt-5.5, reasoning high; reviewed against 4c1e6ba2f03b. |
|
Thanks. This is already covered on current main (
Closing as superseded by main. |
Summary
Unknown modelhint when a model exists inagents.defaults.modelsbut is not registered undermodels.providers[provider].models[].Test Plan
node scripts/run-vitest.mjs run --config test/vitest/vitest.agents-pi-embedded.config.ts src/agents/pi-embedded-runner/model.test.tsgit diff --checkFixes #80089