Fix Discord verbose tool progress delivery#80042
Conversation
|
Codex review: passed. Workflow note: Future ClawSweeper reviews update this same comment in place. How this review workflow works
Summary Reproducibility: yes. source-level: current main strips tool-looking Discord payload text at the front-channel sanitizer, suppresses channel message_tool_only progress, and only forwards compaction events in queued follow-up runs. I did not run a live Discord repro in this read-only review. Real behavior proof Mantis proof suggestion Next step before merge Security Review detailsBest possible solution: Land this narrow Discord delivery fix once exact-head checks finish, then close the linked regression and re-evaluate any remaining Discord status-draft follow-up separately. Do we have a high-confidence way to reproduce the issue? Yes, source-level: current main strips tool-looking Discord payload text at the front-channel sanitizer, suppresses channel message_tool_only progress, and only forwards compaction events in queued follow-up runs. I did not run a live Discord repro in this read-only review. Is this the best way to solve the issue? Yes, after the repair: the patch uses existing ReplyDispatchKind metadata to exempt only explicit tool payloads from final-reply sanitization, forwards queued progress through existing callbacks, and keeps final-reply privacy intact. What I checked:
Likely related people:
Remaining risk / open question:
Codex review notes: model gpt-5.5, reasoning high; reviewed against c93d6d8daa37. |
TurboTheTurtle
left a comment
There was a problem hiding this comment.
Found one issue in the queued follow-up progress forwarding.
b17d493 to
0442c1f
Compare
0442c1f to
43fc7a6
Compare
43fc7a6 to
8269454
Compare
f588275 to
65b233c
Compare
1ca3736 to
fd845e7
Compare
Summary: - The PR changes Discord reply delivery, sanitizer, and queued follow-up auto-reply paths so explicit verbose tool-progress payloads are delivered while final assistant replies still use the privacy sanitizer. - Reproducibility: yes. source-level: current main strips tool-looking Discord payload text at the front-chann ... ds compaction events in queued follow-up runs. I did not run a live Discord repro in this read-only review. Automerge notes: - Ran the ClawSweeper repair loop before final review. - Included post-review commit in the final squash: fix: gate queued follow-up progress when verbose is off - Included post-review commit in the final squash: fix: preserve queued verbose progress under preview suppression - Included post-review commit in the final squash: ci: rerun discord verbose progress PR - Included post-review commit in the final squash: fix: preserve Discord verbose progress after rebase - Included post-review commit in the final squash: fix: serialize discord queued progress - Included post-review commit in the final squash: Fix Discord verbose tool progress delivery Validation: - ClawSweeper review passed for head fd845e773ac6d649ee2dd7ff0defb4676b06b3da. - Required merge gates passed before the squash merge. Prepared head SHA: fd845e773ac6d649ee2dd7ff0defb4676b06b3da Review: openclaw/openclaw#80042 (comment) Co-authored-by: Clawsistant <[email protected]> Co-authored-by: anyech <[email protected]> Co-authored-by: OpenClaw Assistant <[email protected]> Co-authored-by: Shadow <[email protected]> Co-authored-by: clawsweeper <274271284+clawsweeper[bot]@users.noreply.github.com> Co-authored-by: clawsweeper[bot] <274271284+clawsweeper[bot]@users.noreply.github.com> Approved-by: thewilloftheshadow Co-authored-by: thewilloftheshadow <[email protected]>
Summary: - The PR changes Discord reply delivery, sanitizer, and queued follow-up auto-reply paths so explicit verbose tool-progress payloads are delivered while final assistant replies still use the privacy sanitizer. - Reproducibility: yes. source-level: current main strips tool-looking Discord payload text at the front-chann ... ds compaction events in queued follow-up runs. I did not run a live Discord repro in this read-only review. Automerge notes: - Ran the ClawSweeper repair loop before final review. - Included post-review commit in the final squash: fix: gate queued follow-up progress when verbose is off - Included post-review commit in the final squash: fix: preserve queued verbose progress under preview suppression - Included post-review commit in the final squash: ci: rerun discord verbose progress PR - Included post-review commit in the final squash: fix: preserve Discord verbose progress after rebase - Included post-review commit in the final squash: fix: serialize discord queued progress - Included post-review commit in the final squash: Fix Discord verbose tool progress delivery Validation: - ClawSweeper review passed for head fd845e773ac6d649ee2dd7ff0defb4676b06b3da. - Required merge gates passed before the squash merge. Prepared head SHA: fd845e773ac6d649ee2dd7ff0defb4676b06b3da Review: openclaw/openclaw#80042 (comment) Co-authored-by: Clawsistant <[email protected]> Co-authored-by: anyech <[email protected]> Co-authored-by: OpenClaw Assistant <[email protected]> Co-authored-by: Shadow <[email protected]> Co-authored-by: clawsweeper <274271284+clawsweeper[bot]@users.noreply.github.com> Co-authored-by: clawsweeper[bot] <274271284+clawsweeper[bot]@users.noreply.github.com> Approved-by: thewilloftheshadow Co-authored-by: thewilloftheshadow <[email protected]>
Summary: - The PR changes Discord reply delivery, sanitizer, and queued follow-up auto-reply paths so explicit verbose tool-progress payloads are delivered while final assistant replies still use the privacy sanitizer. - Reproducibility: yes. source-level: current main strips tool-looking Discord payload text at the front-chann ... ds compaction events in queued follow-up runs. I did not run a live Discord repro in this read-only review. Automerge notes: - Ran the ClawSweeper repair loop before final review. - Included post-review commit in the final squash: fix: gate queued follow-up progress when verbose is off - Included post-review commit in the final squash: fix: preserve queued verbose progress under preview suppression - Included post-review commit in the final squash: ci: rerun discord verbose progress PR - Included post-review commit in the final squash: fix: preserve Discord verbose progress after rebase - Included post-review commit in the final squash: fix: serialize discord queued progress - Included post-review commit in the final squash: Fix Discord verbose tool progress delivery Validation: - ClawSweeper review passed for head fd845e7. - Required merge gates passed before the squash merge. Prepared head SHA: fd845e7 Review: openclaw#80042 (comment) Co-authored-by: Clawsistant <[email protected]> Co-authored-by: anyech <[email protected]> Co-authored-by: OpenClaw Assistant <[email protected]> Co-authored-by: Shadow <[email protected]> Co-authored-by: clawsweeper <274271284+clawsweeper[bot]@users.noreply.github.com> Co-authored-by: clawsweeper[bot] <274271284+clawsweeper[bot]@users.noreply.github.com> Approved-by: thewilloftheshadow Co-authored-by: thewilloftheshadow <[email protected]>
Summary: - The PR changes Discord reply delivery, sanitizer, and queued follow-up auto-reply paths so explicit verbose tool-progress payloads are delivered while final assistant replies still use the privacy sanitizer. - Reproducibility: yes. source-level: current main strips tool-looking Discord payload text at the front-chann ... ds compaction events in queued follow-up runs. I did not run a live Discord repro in this read-only review. Automerge notes: - Ran the ClawSweeper repair loop before final review. - Included post-review commit in the final squash: fix: gate queued follow-up progress when verbose is off - Included post-review commit in the final squash: fix: preserve queued verbose progress under preview suppression - Included post-review commit in the final squash: ci: rerun discord verbose progress PR - Included post-review commit in the final squash: fix: preserve Discord verbose progress after rebase - Included post-review commit in the final squash: fix: serialize discord queued progress - Included post-review commit in the final squash: Fix Discord verbose tool progress delivery Validation: - ClawSweeper review passed for head fd845e7. - Required merge gates passed before the squash merge. Prepared head SHA: fd845e7 Review: openclaw#80042 (comment) Co-authored-by: Clawsistant <[email protected]> Co-authored-by: anyech <[email protected]> Co-authored-by: OpenClaw Assistant <[email protected]> Co-authored-by: Shadow <[email protected]> Co-authored-by: clawsweeper <274271284+clawsweeper[bot]@users.noreply.github.com> Co-authored-by: clawsweeper[bot] <274271284+clawsweeper[bot]@users.noreply.github.com> Approved-by: thewilloftheshadow Co-authored-by: thewilloftheshadow <[email protected]>
Summary: - The PR changes Discord reply delivery, sanitizer, and queued follow-up auto-reply paths so explicit verbose tool-progress payloads are delivered while final assistant replies still use the privacy sanitizer. - Reproducibility: yes. source-level: current main strips tool-looking Discord payload text at the front-chann ... ds compaction events in queued follow-up runs. I did not run a live Discord repro in this read-only review. Automerge notes: - Ran the ClawSweeper repair loop before final review. - Included post-review commit in the final squash: fix: gate queued follow-up progress when verbose is off - Included post-review commit in the final squash: fix: preserve queued verbose progress under preview suppression - Included post-review commit in the final squash: ci: rerun discord verbose progress PR - Included post-review commit in the final squash: fix: preserve Discord verbose progress after rebase - Included post-review commit in the final squash: fix: serialize discord queued progress - Included post-review commit in the final squash: Fix Discord verbose tool progress delivery Validation: - ClawSweeper review passed for head fd845e7. - Required merge gates passed before the squash merge. Prepared head SHA: fd845e7 Review: openclaw#80042 (comment) Co-authored-by: Clawsistant <[email protected]> Co-authored-by: anyech <[email protected]> Co-authored-by: OpenClaw Assistant <[email protected]> Co-authored-by: Shadow <[email protected]> Co-authored-by: clawsweeper <274271284+clawsweeper[bot]@users.noreply.github.com> Co-authored-by: clawsweeper[bot] <274271284+clawsweeper[bot]@users.noreply.github.com> Approved-by: thewilloftheshadow Co-authored-by: thewilloftheshadow <[email protected]>
Summary: - The PR changes Discord reply delivery, sanitizer, and queued follow-up auto-reply paths so explicit verbose tool-progress payloads are delivered while final assistant replies still use the privacy sanitizer. - Reproducibility: yes. source-level: current main strips tool-looking Discord payload text at the front-chann ... ds compaction events in queued follow-up runs. I did not run a live Discord repro in this read-only review. Automerge notes: - Ran the ClawSweeper repair loop before final review. - Included post-review commit in the final squash: fix: gate queued follow-up progress when verbose is off - Included post-review commit in the final squash: fix: preserve queued verbose progress under preview suppression - Included post-review commit in the final squash: ci: rerun discord verbose progress PR - Included post-review commit in the final squash: fix: preserve Discord verbose progress after rebase - Included post-review commit in the final squash: fix: serialize discord queued progress - Included post-review commit in the final squash: Fix Discord verbose tool progress delivery Validation: - ClawSweeper review passed for head fd845e7. - Required merge gates passed before the squash merge. Prepared head SHA: fd845e7 Review: openclaw#80042 (comment) Co-authored-by: Clawsistant <[email protected]> Co-authored-by: anyech <[email protected]> Co-authored-by: OpenClaw Assistant <[email protected]> Co-authored-by: Shadow <[email protected]> Co-authored-by: clawsweeper <274271284+clawsweeper[bot]@users.noreply.github.com> Co-authored-by: clawsweeper[bot] <274271284+clawsweeper[bot]@users.noreply.github.com> Approved-by: thewilloftheshadow Co-authored-by: thewilloftheshadow <[email protected]>
Summary: - The PR changes Discord reply delivery, sanitizer, and queued follow-up auto-reply paths so explicit verbose tool-progress payloads are delivered while final assistant replies still use the privacy sanitizer. - Reproducibility: yes. source-level: current main strips tool-looking Discord payload text at the front-chann ... ds compaction events in queued follow-up runs. I did not run a live Discord repro in this read-only review. Automerge notes: - Ran the ClawSweeper repair loop before final review. - Included post-review commit in the final squash: fix: gate queued follow-up progress when verbose is off - Included post-review commit in the final squash: fix: preserve queued verbose progress under preview suppression - Included post-review commit in the final squash: ci: rerun discord verbose progress PR - Included post-review commit in the final squash: fix: preserve Discord verbose progress after rebase - Included post-review commit in the final squash: fix: serialize discord queued progress - Included post-review commit in the final squash: Fix Discord verbose tool progress delivery Validation: - ClawSweeper review passed for head fd845e7. - Required merge gates passed before the squash merge. Prepared head SHA: fd845e7 Review: openclaw#80042 (comment) Co-authored-by: Clawsistant <[email protected]> Co-authored-by: anyech <[email protected]> Co-authored-by: OpenClaw Assistant <[email protected]> Co-authored-by: Shadow <[email protected]> Co-authored-by: clawsweeper <274271284+clawsweeper[bot]@users.noreply.github.com> Co-authored-by: clawsweeper[bot] <274271284+clawsweeper[bot]@users.noreply.github.com> Approved-by: thewilloftheshadow Co-authored-by: thewilloftheshadow <[email protected]>
Summary: - The PR changes Discord reply delivery, sanitizer, and queued follow-up auto-reply paths so explicit verbose tool-progress payloads are delivered while final assistant replies still use the privacy sanitizer. - Reproducibility: yes. source-level: current main strips tool-looking Discord payload text at the front-chann ... ds compaction events in queued follow-up runs. I did not run a live Discord repro in this read-only review. Automerge notes: - Ran the ClawSweeper repair loop before final review. - Included post-review commit in the final squash: fix: gate queued follow-up progress when verbose is off - Included post-review commit in the final squash: fix: preserve queued verbose progress under preview suppression - Included post-review commit in the final squash: ci: rerun discord verbose progress PR - Included post-review commit in the final squash: fix: preserve Discord verbose progress after rebase - Included post-review commit in the final squash: fix: serialize discord queued progress - Included post-review commit in the final squash: Fix Discord verbose tool progress delivery Validation: - ClawSweeper review passed for head fd845e7. - Required merge gates passed before the squash merge. Prepared head SHA: fd845e7 Review: openclaw#80042 (comment) Co-authored-by: Clawsistant <[email protected]> Co-authored-by: anyech <[email protected]> Co-authored-by: OpenClaw Assistant <[email protected]> Co-authored-by: Shadow <[email protected]> Co-authored-by: clawsweeper <274271284+clawsweeper[bot]@users.noreply.github.com> Co-authored-by: clawsweeper[bot] <274271284+clawsweeper[bot]@users.noreply.github.com> Approved-by: thewilloftheshadow Co-authored-by: thewilloftheshadow <[email protected]>
Summary: - The PR changes Discord reply delivery, sanitizer, and queued follow-up auto-reply paths so explicit verbose tool-progress payloads are delivered while final assistant replies still use the privacy sanitizer. - Reproducibility: yes. source-level: current main strips tool-looking Discord payload text at the front-chann ... ds compaction events in queued follow-up runs. I did not run a live Discord repro in this read-only review. Automerge notes: - Ran the ClawSweeper repair loop before final review. - Included post-review commit in the final squash: fix: gate queued follow-up progress when verbose is off - Included post-review commit in the final squash: fix: preserve queued verbose progress under preview suppression - Included post-review commit in the final squash: ci: rerun discord verbose progress PR - Included post-review commit in the final squash: fix: preserve Discord verbose progress after rebase - Included post-review commit in the final squash: fix: serialize discord queued progress - Included post-review commit in the final squash: Fix Discord verbose tool progress delivery Validation: - ClawSweeper review passed for head fd845e7. - Required merge gates passed before the squash merge. Prepared head SHA: fd845e7 Review: openclaw#80042 (comment) Co-authored-by: Clawsistant <[email protected]> Co-authored-by: anyech <[email protected]> Co-authored-by: OpenClaw Assistant <[email protected]> Co-authored-by: Shadow <[email protected]> Co-authored-by: clawsweeper <274271284+clawsweeper[bot]@users.noreply.github.com> Co-authored-by: clawsweeper[bot] <274271284+clawsweeper[bot]@users.noreply.github.com> Approved-by: thewilloftheshadow Co-authored-by: thewilloftheshadow <[email protected]>
Summary: - The PR changes Discord reply delivery, sanitizer, and queued follow-up auto-reply paths so explicit verbose tool-progress payloads are delivered while final assistant replies still use the privacy sanitizer. - Reproducibility: yes. source-level: current main strips tool-looking Discord payload text at the front-chann ... ds compaction events in queued follow-up runs. I did not run a live Discord repro in this read-only review. Automerge notes: - Ran the ClawSweeper repair loop before final review. - Included post-review commit in the final squash: fix: gate queued follow-up progress when verbose is off - Included post-review commit in the final squash: fix: preserve queued verbose progress under preview suppression - Included post-review commit in the final squash: ci: rerun discord verbose progress PR - Included post-review commit in the final squash: fix: preserve Discord verbose progress after rebase - Included post-review commit in the final squash: fix: serialize discord queued progress - Included post-review commit in the final squash: Fix Discord verbose tool progress delivery Validation: - ClawSweeper review passed for head fd845e7. - Required merge gates passed before the squash merge. Prepared head SHA: fd845e7 Review: openclaw#80042 (comment) Co-authored-by: Clawsistant <[email protected]> Co-authored-by: anyech <[email protected]> Co-authored-by: OpenClaw Assistant <[email protected]> Co-authored-by: Shadow <[email protected]> Co-authored-by: clawsweeper <274271284+clawsweeper[bot]@users.noreply.github.com> Co-authored-by: clawsweeper[bot] <274271284+clawsweeper[bot]@users.noreply.github.com> Approved-by: thewilloftheshadow Co-authored-by: thewilloftheshadow <[email protected]>
Summary: - The PR changes Discord reply delivery, sanitizer, and queued follow-up auto-reply paths so explicit verbose tool-progress payloads are delivered while final assistant replies still use the privacy sanitizer. - Reproducibility: yes. source-level: current main strips tool-looking Discord payload text at the front-chann ... ds compaction events in queued follow-up runs. I did not run a live Discord repro in this read-only review. Automerge notes: - Ran the ClawSweeper repair loop before final review. - Included post-review commit in the final squash: fix: gate queued follow-up progress when verbose is off - Included post-review commit in the final squash: fix: preserve queued verbose progress under preview suppression - Included post-review commit in the final squash: ci: rerun discord verbose progress PR - Included post-review commit in the final squash: fix: preserve Discord verbose progress after rebase - Included post-review commit in the final squash: fix: serialize discord queued progress - Included post-review commit in the final squash: Fix Discord verbose tool progress delivery Validation: - ClawSweeper review passed for head fd845e7. - Required merge gates passed before the squash merge. Prepared head SHA: fd845e7 Review: openclaw#80042 (comment) Co-authored-by: Clawsistant <[email protected]> Co-authored-by: anyech <[email protected]> Co-authored-by: OpenClaw Assistant <[email protected]> Co-authored-by: Shadow <[email protected]> Co-authored-by: clawsweeper <274271284+clawsweeper[bot]@users.noreply.github.com> Co-authored-by: clawsweeper[bot] <274271284+clawsweeper[bot]@users.noreply.github.com> Approved-by: thewilloftheshadow Co-authored-by: thewilloftheshadow <[email protected]>
Summary: - The PR changes Discord reply delivery, sanitizer, and queued follow-up auto-reply paths so explicit verbose tool-progress payloads are delivered while final assistant replies still use the privacy sanitizer. - Reproducibility: yes. source-level: current main strips tool-looking Discord payload text at the front-chann ... ds compaction events in queued follow-up runs. I did not run a live Discord repro in this read-only review. Automerge notes: - Ran the ClawSweeper repair loop before final review. - Included post-review commit in the final squash: fix: gate queued follow-up progress when verbose is off - Included post-review commit in the final squash: fix: preserve queued verbose progress under preview suppression - Included post-review commit in the final squash: ci: rerun discord verbose progress PR - Included post-review commit in the final squash: fix: preserve Discord verbose progress after rebase - Included post-review commit in the final squash: fix: serialize discord queued progress - Included post-review commit in the final squash: Fix Discord verbose tool progress delivery Validation: - ClawSweeper review passed for head fd845e7. - Required merge gates passed before the squash merge. Prepared head SHA: fd845e7 Review: openclaw#80042 (comment) Co-authored-by: Clawsistant <[email protected]> Co-authored-by: anyech <[email protected]> Co-authored-by: OpenClaw Assistant <[email protected]> Co-authored-by: Shadow <[email protected]> Co-authored-by: clawsweeper <274271284+clawsweeper[bot]@users.noreply.github.com> Co-authored-by: clawsweeper[bot] <274271284+clawsweeper[bot]@users.noreply.github.com> Approved-by: thewilloftheshadow Co-authored-by: thewilloftheshadow <[email protected]>
Summary: - The PR changes Discord reply delivery, sanitizer, and queued follow-up auto-reply paths so explicit verbose tool-progress payloads are delivered while final assistant replies still use the privacy sanitizer. - Reproducibility: yes. source-level: current main strips tool-looking Discord payload text at the front-chann ... ds compaction events in queued follow-up runs. I did not run a live Discord repro in this read-only review. Automerge notes: - Ran the ClawSweeper repair loop before final review. - Included post-review commit in the final squash: fix: gate queued follow-up progress when verbose is off - Included post-review commit in the final squash: fix: preserve queued verbose progress under preview suppression - Included post-review commit in the final squash: ci: rerun discord verbose progress PR - Included post-review commit in the final squash: fix: preserve Discord verbose progress after rebase - Included post-review commit in the final squash: fix: serialize discord queued progress - Included post-review commit in the final squash: Fix Discord verbose tool progress delivery Validation: - ClawSweeper review passed for head fd845e7. - Required merge gates passed before the squash merge. Prepared head SHA: fd845e7 Review: openclaw#80042 (comment) Co-authored-by: Clawsistant <[email protected]> Co-authored-by: anyech <[email protected]> Co-authored-by: OpenClaw Assistant <[email protected]> Co-authored-by: Shadow <[email protected]> Co-authored-by: clawsweeper <274271284+clawsweeper[bot]@users.noreply.github.com> Co-authored-by: clawsweeper[bot] <274271284+clawsweeper[bot]@users.noreply.github.com> Approved-by: thewilloftheshadow Co-authored-by: thewilloftheshadow <[email protected]>
Summary: - The PR changes Discord reply delivery, sanitizer, and queued follow-up auto-reply paths so explicit verbose tool-progress payloads are delivered while final assistant replies still use the privacy sanitizer. - Reproducibility: yes. source-level: current main strips tool-looking Discord payload text at the front-chann ... ds compaction events in queued follow-up runs. I did not run a live Discord repro in this read-only review. Automerge notes: - Ran the ClawSweeper repair loop before final review. - Included post-review commit in the final squash: fix: gate queued follow-up progress when verbose is off - Included post-review commit in the final squash: fix: preserve queued verbose progress under preview suppression - Included post-review commit in the final squash: ci: rerun discord verbose progress PR - Included post-review commit in the final squash: fix: preserve Discord verbose progress after rebase - Included post-review commit in the final squash: fix: serialize discord queued progress - Included post-review commit in the final squash: Fix Discord verbose tool progress delivery Validation: - ClawSweeper review passed for head fd845e7. - Required merge gates passed before the squash merge. Prepared head SHA: fd845e7 Review: openclaw#80042 (comment) Co-authored-by: Clawsistant <[email protected]> Co-authored-by: anyech <[email protected]> Co-authored-by: OpenClaw Assistant <[email protected]> Co-authored-by: Shadow <[email protected]> Co-authored-by: clawsweeper <274271284+clawsweeper[bot]@users.noreply.github.com> Co-authored-by: clawsweeper[bot] <274271284+clawsweeper[bot]@users.noreply.github.com> Approved-by: thewilloftheshadow Co-authored-by: thewilloftheshadow <[email protected]>
Restore verbose Discord tool-progress delivery across message-tool-only and queued follow-up paths, while preserving final-reply privacy boundaries.
Fixes #78365
Summary
Change Type (select all)
Scope (select all touched areas)
Linked Issue/PR
Real behavior proof
Root Cause
Regression Test Plan
User-visible / Behavior Changes
Discord verbose mode once again shows explicit tool/progress messages for affected message-tool-only and queued follow-up paths.
Diagram
Security Impact
Repro + Verification
Environment
Steps
Expected
Actual
Evidence
Human Verification
Review Conversations
Compatibility / Migration
Risks and Mitigations