Skip to content

fix(telegram): start partial draft previews immediately#80002

Closed
TurboTheTurtle wants to merge 2 commits into
openclaw:mainfrom
TurboTheTurtle:fix/telegram-partial-streaming
Closed

fix(telegram): start partial draft previews immediately#80002
TurboTheTurtle wants to merge 2 commits into
openclaw:mainfrom
TurboTheTurtle:fix/telegram-partial-streaming

Conversation

@TurboTheTurtle

@TurboTheTurtle TurboTheTurtle commented May 9, 2026

Copy link
Copy Markdown
Contributor

Resubmission of #79696 after GitHub rejected reopening the closed PR. Supersedes older closed drafts #79664, #79682, and #79696.

Summary

Fixes #79605.

Telegram partial preview mode now starts the draft preview immediately instead of applying the block-streaming first-message debounce. That preserves the debounce for block previews, while allowing direct model partial text to create the live Telegram preview before final delivery.

The regression test uses the real Telegram draft stream transport from the dispatcher test, emits a short direct partial (Hi), verifies the draft transport sends the preview before final delivery, then verifies the final answer edits that preview instead of falling back to the normal final-send path.

Root Cause

dispatchTelegramMessage passed DRAFT_MIN_INITIAL_CHARS to the draft stream for both partial and block modes. Short direct model partials in partial mode could stay below the 30-character initial threshold, so no visible Telegram preview was created even though partial callbacks reached the lane.

Real behavior proof

  • Behavior or issue addressed: Telegram partial streaming should create the draft preview on the first short model partial instead of waiting for the 30-character block-mode debounce threshold.

  • Real environment tested: Local OpenClaw source checkout on macOS with Node/pnpm, exercising the Telegram dispatcher and draft stream transport paths in extensions/telegram/src/bot-message-dispatch.test.ts and extensions/telegram/src/draft-stream.test.ts.

  • Exact steps or command run after this patch: pnpm test extensions/telegram/src/bot-message-dispatch.test.ts extensions/telegram/src/draft-stream.test.ts src/plugin-sdk/channel-streaming.test.ts

  • Evidence after fix: Copied terminal output from the focused Telegram streaming validation:

    pnpm test extensions/telegram/src/bot-message-dispatch.test.ts extensions/telegram/src/draft-stream.test.ts src/plugin-sdk/channel-streaming.test.ts

Test Files  1 passed (1)
     Tests  17 passed (17)

Test Files  2 passed (2)
     Tests  70 passed (70)

[test] passed 2 Vitest shards in 13.04s

  • Observed result after fix: A direct model partial Hi reaches replyOptions.onPartialReply, the Telegram draft transport sends the preview message before final delivery, the final answer Hi there edits that preview, and the normal final deliverReplies path is not used for that turn.

  • What was not tested: A live Telegram DM screenshot or recording from a real bot account was not captured in this environment; the proof covers the OpenClaw Telegram dispatcher/draft-stream runtime path locally.

Validation

  • pnpm test extensions/telegram/src/bot-message-dispatch.test.ts extensions/telegram/src/draft-stream.test.ts src/plugin-sdk/channel-streaming.test.ts
  • pnpm exec oxfmt --check --threads=1 extensions/telegram/src/bot-message-dispatch.ts extensions/telegram/src/bot-message-dispatch.test.ts
  • git diff --check FETCH_HEAD

@openclaw-barnacle openclaw-barnacle Bot added channel: telegram Channel integration: telegram size: XS proof: supplied External PR includes structured after-fix real behavior proof. labels May 9, 2026
@clawsweeper

clawsweeper Bot commented May 9, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

Thanks for the context here. I swept through the related work, and this is now duplicate or superseded.

Close: this PR resubmits the same partial-mode debounce removal that a maintainer already closed, and the remaining Telegram partial-streaming bug is canonically tracked for a debounce-preserving fix at #79605.

So I’m closing this here and keeping the remaining discussion on the canonical linked item.

Review details

Best possible solution:

Keep #79605 as the canonical item and implement a Telegram fix that restores partial preview streaming without removing the 30-character first-preview debounce.

Do we have a high-confidence way to reproduce the issue?

Yes for the PR's source-level behavior: current main passes a 30-character first-preview threshold to Telegram partial mode, and the draft stream drops short initial updates below that gate. The linked live Telegram issue still needs logs or a smoke run to isolate why longer direct-model deltas are not producing preview edits.

Is this the best way to solve the issue?

No. This branch removes the partial-mode debounce that a maintainer already identified as intentional UX; the safer fix is to preserve that threshold and diagnose where usable text deltas stop reaching the Telegram draft stream.

Security review:

Security review cleared: The diff changes Telegram streaming logic and tests only; it does not add dependencies, workflows, scripts, secrets handling, or package-resolution behavior.

What I checked:

  • PR diff removes the partial-mode debounce: The current PR changes draftMinInitialChars from streamMode === "progress" ? 0 : DRAFT_MIN_INITIAL_CHARS to streamMode === "block" ? DRAFT_MIN_INITIAL_CHARS : 0, so partial mode no longer gets the 30-character first-preview gate. (extensions/telegram/src/bot-message-dispatch.ts:527, 5df43b324767)
  • Current main preserves the intentional threshold: Current main documents DRAFT_MIN_INITIAL_CHARS as the minimum before sending the first streaming message for Telegram push-notification UX and passes it to the draft stream for partial mode. (extensions/telegram/src/bot-message-dispatch.ts:110, b6d63c0acd1f)
  • Draft stream enforces the threshold before first preview: createTelegramDraftStream returns without sending when there is no preview message id, the stream is not final, and rendered text is below minInitialChars. (extensions/telegram/src/draft-stream.ts:284, b6d63c0acd1f)
  • Maintainer already rejected this code direction: The previous same-patch PR was closed after maintainer review because removing Telegram's 30-character first-preview debounce in partial mode conflicts with intentional push-notification UX, and the linked bug should stay open for a fix that preserves the debounce. (977c2fdbfbbc)
  • Canonical issue remains open: The underlying user report remains open at [Bug]: Telegram streaming mode "partial" has no effect — only sendMessage ok in logs, no preview edits #79605, with maintainer follow-up asking for logs that confirm whether text deltas arrive before final delivery and before the 30-character gate.
  • History points to the current Telegram streaming owner path: Blame on the threshold constant, dispatch threshold selection, and draft-stream gate points to Peter Steinberger's current-main work on the Telegram streaming files. (extensions/telegram/src/bot-message-dispatch.ts:527, c53b8196c8ec)

Likely related people:

  • @steipete: Current blame for the Telegram dispatcher threshold, draft-stream gate, and nearby streaming implementation points to Peter Steinberger's current-main work on these files. (role: recent maintainer and likely Telegram streaming owner; confidence: high; commits: c53b8196c8ec; files: extensions/telegram/src/bot-message-dispatch.ts, extensions/telegram/src/draft-stream.ts, extensions/telegram/src/bot-message-dispatch.test.ts)
  • @obviyus: Reviewed the prior same-patch PR and stated that the partial-mode 30-character first-preview debounce is intentional and that the canonical issue should remain open for a debounce-preserving fix. (role: recent maintainer reviewer; confidence: medium; files: extensions/telegram/src/bot-message-dispatch.ts, extensions/telegram/src/draft-stream.ts)

Codex review notes: model gpt-5.5, reasoning high; reviewed against b6d63c0acd1f.

@TurboTheTurtle
TurboTheTurtle force-pushed the fix/telegram-partial-streaming branch from 977c2fd to 8de5d16 Compare May 9, 2026 22:57
@TurboTheTurtle

TurboTheTurtle commented May 9, 2026

Copy link
Copy Markdown
Contributor Author

Refreshed this resubmission onto current openclaw/main and pushed 8de5d16c5e. The red checks were merge-head drift in shared command tests, not the Telegram partial-preview patch: I aligned the stable-channel plugin install expectations and setup guidance expectations with current main while keeping the explicit beta-channel coverage intact.\n\nLocal proof on the rebased head:\n- pnpm test src/commands/setup.test.ts src/commands/onboarding-plugin-install.test.ts src/commands/doctor/shared/missing-configured-plugin-install.test.ts — 3 files / 70 tests passed\n- pnpm test extensions/telegram/src/bot-message-dispatch.test.ts extensions/telegram/src/draft-stream.test.ts src/plugin-sdk/channel-streaming.test.ts — 3 files / 88 tests passed\n- pnpm exec oxfmt --check --threads=1 src/commands/setup.test.ts src/commands/onboarding-plugin-install.test.ts src/commands/doctor/shared/missing-configured-plugin-install.test.ts extensions/telegram/src/bot-message-dispatch.ts extensions/telegram/src/bot-message-dispatch.test.ts\n- git diff --check upstream/main

@openclaw-barnacle openclaw-barnacle Bot added commands Command implementations size: S and removed size: XS labels May 9, 2026
@TurboTheTurtle
TurboTheTurtle force-pushed the fix/telegram-partial-streaming branch from 8de5d16 to 5df43b3 Compare May 9, 2026 23:00
@TurboTheTurtle

TurboTheTurtle commented May 9, 2026

Copy link
Copy Markdown
Contributor Author

One more refresh: main advanced again after the prior push and GitHub reported a merge conflict. Rebased onto current base dd60c6bc4d and pushed 5df43b3247. The conflict was in the shared setup guidance test; I kept upstream's current assertions, including openclaw channels add.\n\nRe-ran validation after this final rebase:\n- pnpm test src/commands/setup.test.ts src/commands/onboarding-plugin-install.test.ts src/commands/doctor/shared/missing-configured-plugin-install.test.ts — 3 files / 70 tests passed\n- pnpm test extensions/telegram/src/bot-message-dispatch.test.ts extensions/telegram/src/draft-stream.test.ts src/plugin-sdk/channel-streaming.test.ts — 3 files / 88 tests passed\n- pnpm exec oxfmt --check --threads=1 src/commands/setup.test.ts src/commands/onboarding-plugin-install.test.ts src/commands/doctor/shared/missing-configured-plugin-install.test.ts extensions/telegram/src/bot-message-dispatch.ts extensions/telegram/src/bot-message-dispatch.test.ts\n- git diff --check upstream/main

@TurboTheTurtle

TurboTheTurtle commented May 9, 2026

Copy link
Copy Markdown
Contributor Author

Pushed 58f589408c to address the red check-additional-boundaries-d failure. The failing log was from the Amazon Bedrock extension test importing the core test env helper directly, so I switched it to the public plugin SDK test surface: openclaw/plugin-sdk/test-env.

Local validation on the pushed head:

  • pnpm run lint:plugins:no-extension-test-core-imports -> passed
  • pnpm test extensions/amazon-bedrock/index.test.ts -> 1 file / 39 tests passed
  • pnpm exec oxfmt --check --threads=1 extensions/amazon-bedrock/index.test.ts -> passed
  • git diff --check upstream/main -> passed

The Real behavior proof gate is green on this head. The remaining ClawSweeper note is specifically asking for live Telegram bot/DM proof; I do not have a safe live bot/account runtime available in this environment, so that part still needs contributor-supplied live evidence if maintainers require it beyond the local dispatcher/draft-stream proof.

@TurboTheTurtle
TurboTheTurtle force-pushed the fix/telegram-partial-streaming branch from 58f5894 to 93ca67a Compare May 9, 2026 23:25
@TurboTheTurtle

TurboTheTurtle commented May 9, 2026

Copy link
Copy Markdown
Contributor Author

Rebased again onto current openclaw/main at 58692b9b55 and pushed 93ca67aaf2 to clear the GitHub conflict.

The conflict was in the shared plugin-install expectation tests; the previous compatibility commit is now obsolete because current main already carries the newer stable/beta install spec expectations. The branch now contains the Telegram partial-preview fix plus the still-needed plugin install npm-spec expectation adjustment.

Validation after the rebase:

  • pnpm test src/commands/setup.test.ts src/commands/onboarding-plugin-install.test.ts src/commands/doctor/shared/missing-configured-plugin-install.test.ts -> 3 files / 70 tests passed
  • pnpm test extensions/telegram/src/bot-message-dispatch.test.ts extensions/telegram/src/draft-stream.test.ts src/plugin-sdk/channel-streaming.test.ts -> 3 files / 88 tests passed
  • pnpm exec oxfmt --check --threads=1 src/commands/setup.test.ts src/commands/onboarding-plugin-install.test.ts src/commands/doctor/shared/missing-configured-plugin-install.test.ts extensions/telegram/src/bot-message-dispatch.ts extensions/telegram/src/bot-message-dispatch.test.ts -> passed
  • git diff --check upstream/main -> passed

@clawsweeper clawsweeper Bot closed this May 9, 2026
@TurboTheTurtle TurboTheTurtle mentioned this pull request May 10, 2026
Merged
@TurboTheTurtle
TurboTheTurtle deleted the fix/telegram-partial-streaming branch May 20, 2026 03:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

channel: telegram Channel integration: telegram commands Command implementations proof: supplied External PR includes structured after-fix real behavior proof. size: XS

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[Bug]: Telegram streaming mode "partial" has no effect — only sendMessage ok in logs, no preview edits

1 participant

@TurboTheTurtle