feat(voice-call): add Telnyx realtime media streams#79324
feat(voice-call): add Telnyx realtime media streams#79324ifthikar-razik wants to merge 1 commit into
Conversation
|
Codex review: needs real behavior proof before merge. Summary Reproducibility: yes. for the review finding by source inspection: the PR stores provider metadata in the stream token and then reads Real behavior proof Next step before merge Security Review findings
Review detailsBest possible solution: Preserve provider metadata through stream-token consumption, add focused coverage that Telnyx outbound audio emits Telnyx-shaped media/clear behavior, keep docs/changelog aligned, and require redacted live Telnyx call proof before merge. Do we have a high-confidence way to reproduce the issue? Yes for the review finding by source inspection: the PR stores provider metadata in the stream token and then reads Is this the best way to solve the issue? No: the direction is plausible, but the current diff is not mergeable because it drops the provider metadata needed to select Telnyx outbound audio framing. The safer solution is to preserve that metadata through Full review comments:
Overall correctness: patch is incorrect What I checked:
Likely related people:
Remaining risk / open question:
Codex review notes: model gpt-5.5, reasoning high; reviewed against 2d1f4f909ed6. |
|
Closing this PR because the target repo/format is incorrect. We'll reopen using the correct workflow. |
Summary
streaming_startsupport for realtime voice bridgesrealtime.enabledwith Telnyx while preserving Twilio, Plivo, mock, and dev fallback behaviorValidation
npm test -- extensions/voice-call/src/config.test.ts extensions/voice-call/src/providers/telnyx.test.ts extensions/voice-call/src/webhook/realtime-handler.test.tsnpm run lint -- extensions/voice-call/index.ts extensions/voice-call/README.md extensions/voice-call/src/config.ts extensions/voice-call/src/providers/base.ts extensions/voice-call/src/providers/telnyx.ts extensions/voice-call/src/webhook/realtime-handler.ts extensions/voice-call/src/webhook/realtime-audio-pacer.ts extensions/voice-call/src/manager.ts extensions/voice-call/src/runtime.ts extensions/voice-call/src/types.ts extensions/voice-call/src/config.test.ts extensions/voice-call/src/providers/telnyx.test.ts extensions/voice-call/src/webhook/realtime-handler.test.tsnpm run format:check -- extensions/voice-call/index.ts extensions/voice-call/README.md extensions/voice-call/src/config.ts extensions/voice-call/src/providers/base.ts extensions/voice-call/src/providers/telnyx.ts extensions/voice-call/src/webhook/realtime-handler.ts extensions/voice-call/src/webhook/realtime-audio-pacer.ts extensions/voice-call/src/manager.ts extensions/voice-call/src/runtime.ts extensions/voice-call/src/types.ts extensions/voice-call/src/config.test.ts extensions/voice-call/src/providers/telnyx.test.ts extensions/voice-call/src/webhook/realtime-handler.test.tsnpm run tsgo:test:extensionsnpm run build