fix(ui): read exec security from tools config#79207
Conversation
|
Codex review: needs real behavior proof before merge. Summary Reproducibility: yes. by source inspection: current main reads Real behavior proof Next step before merge Security Review detailsBest possible solution: Land the narrow extraction change after maintainer review once the PR body includes real Control UI proof showing Quick Settings displays the active Do we have a high-confidence way to reproduce the issue? Yes, by source inspection: current main reads Is this the best way to solve the issue? Yes for the code direction: reading What I checked:
Likely related people:
Remaining risk / open question:
Codex review notes: model gpt-5.5, reasoning high; reviewed against df069f7b0222. |
3040d5c to
d5924aa
Compare
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: d5924aac97
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| @@ -181,6 +181,7 @@ Docs: https://docs.openclaw.ai | |||
| - Gateway/macOS: `openclaw gateway stop --disable` now persists the LaunchAgent disable bit even after a previous bootout left the service not loaded, keeping the explicit stay-down path reliable. (#78412) Thanks @wdeveloper16. | |||
| - Control UI/chat: hide retired and non-public Google Gemini model IDs from chat model catalogs and route the bare `gemini-3-pro` alias to Gemini 3.1 Pro Preview instead of the shut-down Gemini 3 Pro Preview. Thanks @BunsDev. | |||
| - CLI/install: refuse state-mutating OpenClaw CLI runs as root by default, keep an explicit `OPENCLAW_ALLOW_ROOT=1` escape hatch for intentional root/container use, and update DigitalOcean setup guidance to run OpenClaw as a non-root user. Fixes #67478. Thanks @Jerry-Xin and @natechicago. | |||
| - Control UI/settings: show the active `tools.exec.security` policy in Quick Settings instead of stale agent-default exec security. | |||
There was a problem hiding this comment.
Add required contributor attribution to changelog entry
The new changelog bullet is missing a Thanks @author attribution, which violates the repo rule in AGENTS.md (Docs / Changelog: “contributor-facing added entries should include at least one Thanks @author attribution”). This makes the entry non-compliant with the documented changelog contract and should be fixed in the same commit.
Useful? React with 👍 / 👎.
d5924aa to
27e75bb
Compare
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 27e75bb460
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| @@ -181,6 +181,7 @@ Docs: https://docs.openclaw.ai | |||
| - Gateway/macOS: `openclaw gateway stop --disable` now persists the LaunchAgent disable bit even after a previous bootout left the service not loaded, keeping the explicit stay-down path reliable. (#78412) Thanks @wdeveloper16. | |||
| - Control UI/chat: hide retired and non-public Google Gemini model IDs from chat model catalogs and route the bare `gemini-3-pro` alias to Gemini 3.1 Pro Preview instead of the shut-down Gemini 3 Pro Preview. Thanks @BunsDev. | |||
| - CLI/install: refuse state-mutating OpenClaw CLI runs as root by default, keep an explicit `OPENCLAW_ALLOW_ROOT=1` escape hatch for intentional root/container use, and update DigitalOcean setup guidance to run OpenClaw as a non-root user. Fixes #67478. Thanks @Jerry-Xin and @natechicago. | |||
| - Control UI/settings: show the active `tools.exec.security` policy in Quick Settings instead of stale agent-default exec security. | |||
There was a problem hiding this comment.
Add missing contributor attribution to changelog entry
This new contributor-facing changelog bullet is missing a Thanks @author attribution, which violates the documented changelog contract in AGENTS.md (Docs / Changelog section). Leaving it un-attributed makes the entry non-compliant with repo release-note requirements and should be fixed in this commit.
Useful? React with 👍 / 👎.
7253ffe to
bb5ca5e
Compare
bb5ca5e to
53df44b
Compare
Summary
agents.defaults.exec.security.tools.exec.security.config.tools.exec.security.Verification
git diff --check origin/main..HEADpnpm test ui/src/ui/app-render.assistant-avatar.test.ts— 4 passednode -e 'console.log(process.platform, process.version)'—darwin v25.9.0Real behavior proof
tools.exec.securityinstead of stale agent-default exec security.pnpm test ui/src/ui/app-render.assistant-avatar.test.tsTest Files 1 passed (1); Tests 4 passed (4)tools.exec.security: "full"with stale agent defaultdenyand Quick Settings receivesfull.Security Impact
Risks and Mitigations
tools.exec.security; the test locks that path.Linked Issue
Closes #79247