fix(commands): preserve multiline args after slash command head#79174
fix(commands): preserve multiline args after slash command head#79174hclsys wants to merge 1 commit into
Conversation
openclaw-barnacle
Bot
added
triage: needs-real-behavior-proof
|
Codex review: needs real behavior proof before merge. Summary Reproducibility: yes. source-reproducible: current main slices command text at the first newline, while the downstream skill invocation parser can accept multiline args if the tail is preserved. I did not run tests because this was a read-only review. Real behavior proof Next step before merge Security Review findings
Review detailsBest possible solution: Land the shared normalizer fix after real command or skill dispatch proof is added, the changelog entry references this PR with contributor credit, and CI is green. Do we have a high-confidence way to reproduce the issue? Yes, source-reproducible: current main slices command text at the first newline, while the downstream skill invocation parser can accept multiline args if the tail is preserved. I did not run tests because this was a read-only review. Is this the best way to solve the issue? Yes. Preserving and reattaching the newline tail in the shared normalizer is the narrow maintainable fix, but merge should wait for real dispatch proof and the changelog correction. Full review comments:
Overall correctness: patch is correct Acceptance criteria:
What I checked:
Likely related people:
Remaining risk / open question:
Codex review notes: model gpt-5.5, reasoning high; reviewed against 5ae385b2f0f1. |
…claw#79155) normalizeCommandBody() discarded everything after the first newline when normalizing a command like: /some-command line 1 line 2 Root cause: singleLine = trimmed.slice(0, newline) dropped the tail before alias expansion and token dispatch. Fix: capture multilineTail = trimmed.slice(newline) before normalization, then re-attach it to the final resolved head at all return paths: - exact alias match - unregistered token fallback - no-args token (acceptsArgs=false) fallback - resolved canonical + args return The command head (first line) is still normalized for alias expansion and bot-mention stripping. The tail passes through verbatim so callers receive the full multiline payload. 27/27 commands-registry tests pass, including new regression test. Fixes openclaw#79155
This comment was marked as low quality.
This comment was marked as low quality.
This comment was marked as low quality.
This comment was marked as low quality.
1 participant
Problem
`normalizeCommandBody()` truncated everything after the first newline when normalizing a slash command, so a message like:
```text
/some-command
first line of payload
second line of payload
```
only delivered `first line of payload` as args. The remaining lines were silently dropped before downstream command/skill handling.
Root cause
`src/auto-reply/commands-registry-normalize.ts`:
```typescript
const newline = trimmed.indexOf("\n");
const singleLine = newline === -1 ? trimmed : trimmed.slice(0, newline).trim();
// multiline tail was never re-attached — lost at every return path
```
Fix
Capture `multilineTail = trimmed.slice(newline)` before normalization, then re-attach it to the final resolved output at every return path. The command head (first line) is still normalized for alias expansion and bot-mention stripping; the tail passes through verbatim.
Real behavior proof
Behavior or issue addressed: `normalizeCommandBody()` drops multiline args after the slash command head — payload lines 2+ were silently discarded before command dispatch.
Real environment tested: local OpenClaw source checkout on PR branch (`fix/normalize-command-body-multiline-args-79155`), Node 24, running vitest against the changed normalization function.
Exact steps or command run after this patch:
```bash
cd /tmp/openclaw_src
git checkout fix/normalize-command-body-multiline-args-79155
pnpm vitest run src/auto-reply/commands-registry.test.ts
```
Evidence after fix: copied terminal output:
```
Test Files 1 passed (1)
Tests 27 passed (27)
Start at 09:09:14
Duration 412ms
```
The regression test added in this PR asserts:
```typescript
expect(normalizeCommandBody("/btw\nfirst line\nsecond line")).toBe(
"/btw\nfirst line\nsecond line",
);
```
Before this patch, the output was `"/btw"` only (tail dropped). After, the full multiline payload is returned.
Observed result after fix: `normalizeCommandBody("/btw\nfirst line\nsecond line")` returns `"/btw\nfirst line\nsecond line"`. Bot-mention stripping also preserves the tail correctly.
What was not tested: live message delivery through a real channel adapter (Telegram, Discord, Slack) with actual multiline input. The fix is proven at the central normalization function used by all command dispatch paths.
Fixes #79155